Re: [Xen-devel] [PATCH v6 13/14] x86: add iommu_ops to modify and flush IOMMU mappings

2018-09-12 Thread Jan Beulich
>>> On 23.08.18 at 11:47, wrote: > +static int iommuop_map(struct xen_iommu_op_map *op) > +{ > +struct domain *d, *currd = current->domain; > +struct domain_iommu *iommu = dom_iommu(currd); > +bool readonly = op->flags & XEN_IOMMUOP_map_readonly; > +bfn_t bfn = _bfn(op->bfn); > +

Re: [Xen-devel] [PATCH 1/5] xentrace_format: print timestamps in nanoseconds

2018-09-12 Thread Dario Faggioli
On Tue, 2018-09-11 at 16:54 +0100, George Dunlap wrote: > On 09/11/2018 04:19 PM, Andrii Anisov wrote: > > > > On 11.09.18 13:44, George Dunlap wrote: > > > What I do in xenalyze is to have the timestamps in seconds, but > > > always > > > print down to the nanosecond. (For this I actually break

Re: [Xen-devel] [PATCH 3/5] xentrace_format: combine 64-bit LE values from traces

2018-09-12 Thread Dario Faggioli
On Tue, 2018-09-11 at 15:23 +0300, Andrii Anisov wrote: > Hello George, > > > On 11.09.18 13:48, George Dunlap wrote: > > I like the idea; but what does 'LE' mean in this context? > > Little endian. Most significant 32bit word is at a higher index in > the > array. > I did get it, but it took i

Re: [Xen-devel] [PATCH 4/5] formats: allign trace record format to the current code

2018-09-12 Thread Dario Faggioli
On Mon, 2018-09-10 at 19:41 +0300, Andrii Anisov wrote: > From: Andrii Anisov > > Allign rtds:repl_budget trace record format to the current code. > Right. This is (most likely) my fault. Sorry :-P > Signed-off-by: Andrii Anisov > Reviewed-by: Dario Faggioli Regards, Dario -- <> (Raistlin

[Xen-devel] [PATCH v6 3/3] x86/altp2m: Add a hvmop for querying the suppress #VE bit

2018-09-12 Thread Adrian Pop
Signed-off-by: Adrian Pop Acked-by: Tamas K Lengyel --- tools/libxc/include/xenctrl.h | 2 ++ tools/libxc/xc_altp2m.c | 26 +++ xen/arch/x86/hvm/hvm.c | 19 ++ xen/arch/x86/mm/mem_access.c| 45 + xen/include/publ

[Xen-devel] [PATCH v6 1/3] x86/mm: Change default value for suppress #VE in set_mem_access()

2018-09-12 Thread Adrian Pop
From: Vlad Ioan Topan The default value for the "suppress #VE" bit set by set_mem_access() currently depends on whether the call is made from the same domain (the bit is set when called from another domain and cleared if called from the same domain). This patch changes that behavior to inherit th

[Xen-devel] [PATCH v6 2/3] x86/altp2m: Add a hvmop for setting the suppress #VE bit

2018-09-12 Thread Adrian Pop
Introduce a new hvmop, HVMOP_altp2m_set_suppress_ve, which allows a domain to change the value of the #VE suppress bit for a page. Add a libxc wrapper for invoking this hvmop. Signed-off-by: Adrian Pop Acked-by: Wei Liu Acked-by: Tamas K Lengyel --- Changes in v5: - remove the "set_" from stru

[Xen-devel] [PATCH v6 0/3] Add hvmops for setting and getting the suppress #VE bit

2018-09-12 Thread Adrian Pop
As the code stands right now, after DomU has enabled #VE using HVMOP_altp2m_vcpu_enable_notify, all its pages have the #VE suppress bit cleared, generating #VEs for any EPT violation. There is currently no way to change the value of the #VE suppress bit for a page from a domain; it can only be don

Re: [Xen-devel] [PATCH v2 1/1] cameraif: add ABI for para-virtual camera

2018-09-12 Thread Hans Verkuil
On 09/11/2018 10:29 AM, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > This is the ABI for the two halves of a para-virtualized > camera driver which extends Xen's reach multimedia capabilities even > farther enabling it for video conferencing, In-Vehicle Infotainment, > high

[Xen-devel] [ovmf test] 127522: all pass - PUSHED

2018-09-12 Thread osstest service owner
flight 127522 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/127522/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 5c9ac43f47865bb9b13608fd7ae1d39ab73ef397 baseline version: ovmf 1ad635b283812283e8db4

Re: [Xen-devel] [PATCH v6 13/14] x86: add iommu_ops to modify and flush IOMMU mappings

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 08:04 > To: Paul Durrant > Cc: Julien Grall ; Andrew Cooper > ; Wei Liu ; George > Dunlap ; Ian Jackson ; > Stefano Stabellini ; xen-devel de...@lists.xenproject.org>; Konrad Rzeszutek Wilk > ; T

Re: [Xen-devel] [PATCH v6 11/14] x86: add iommu_op to enable modification of IOMMU mappings

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 07:54 > To: Paul Durrant > Cc: Julien Grall ; Andrew Cooper > ; George Dunlap > ; Ian Jackson ; Wei Liu > ; Stefano Stabellini ; xen- > devel ; Konrad Rzeszutek Wilk > ; Tim (Xen.org) > Subject:

Re: [Xen-devel] [PATCH 2/6] xen/sched: Use %*pb[l] instead of cpumask_scn{, list}printf()

2018-09-12 Thread Dario Faggioli
On Fri, 2018-09-07 at 15:42 +0100, George Dunlap wrote: > On 09/06/2018 01:08 PM, Andrew Cooper wrote: > > This removes all use of keyhandler_scratch as a bounce-buffer for > > the rendered > > string. In some cases, collapse combine adjacent printk()'s which > > are writing > > parts of the same

Re: [Xen-devel] [PATCH v6 10/14] mm / iommu: split need_iommu() into has_iommu_pt() and need_iommu_pt_sync()

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 07:45 > To: Paul Durrant > Cc: Brian Woods ; Suravee Suthikulpanit > ; Julien Grall ; > Razvan Cojocaru ; Andrew Cooper > ; George Dunlap > ; Ian Jackson ; Wei Liu > ; Jun Nakajima ; Kevin Tian >

Re: [Xen-devel] [PATCH 5/6] xen/bitmap: Drop all bitmap_scn{, list}printf() infrastructure

2018-09-12 Thread Dario Faggioli
On Thu, 2018-09-06 at 13:08 +0100, Andrew Cooper wrote: > All callers have been convered to using %*pb[l]. In the unlikely > case that > future code wants to retain this functionaly, it can be replicated in > a more > convenient fashon with snprintf(). > > Signed-off-by: Andrew Cooper > Reviewed

Re: [Xen-devel] [PATCH] drivers/block/xen-blkback/common.h: use DIV_ROUND_UP instead of reimplementing its function

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 07:45, wrote: > --- a/drivers/block/xen-blkback/common.h > +++ b/drivers/block/xen-blkback/common.h > @@ -65,7 +65,7 @@ > (XEN_PAGES_PER_INDIRECT_FRAME / XEN_PAGES_PER_SEGMENT) > > #define MAX_INDIRECT_PAGES \ > - ((MAX_INDIRECT_SEGMENTS + SEGS_PER_INDIRECT_FRAME -

Re: [Xen-devel] [PATCH v3 2/3] x86/viridan: Clean up Viridian MSR infrastructure

2018-09-12 Thread Sergey Dyasli
On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: > Rename the functions to guest_{rd,wr}msr_viridian() for consistency, and > because the _regs() suffix isn't very appropriate. > > Update them to take a vcpu pointer rather than presuming that they act on > current, which is safe for all imp

Re: [Xen-devel] [PATCH] schedule: move last_run_time to the credit scheduler privates

2018-09-12 Thread Dario Faggioli
On Tue, 2018-09-11 at 11:10 +0300, Andrii Anisov wrote: > From: Andrii Anisov > > The structure member last_run_time is used by a credit scheduler > only. > So move it from a generic vcpu sctructure to the credit scheduler > private > vcpu definition. > > Signed-off-by: Andrii Anisov > --- > >

Re: [Xen-devel] [PATCH 5/5] formats: print time values as decimals

2018-09-12 Thread Dario Faggioli
On Tue, 2018-09-11 at 11:33 +0100, George Dunlap wrote: > On 09/10/2018 05:41 PM, Andrii Anisov wrote: > > From: Andrii Anisov > > > > For convinience, print RTDS budget and deadline values as decimals. > > I agree, this is a lot better. > > Signed-off-by: Andrii Anisov > > Acked-by: George D

Re: [Xen-devel] [xen-unstable test] 127504: regressions - FAIL

2018-09-12 Thread Roger Pau Monné
On Wed, Sep 12, 2018 at 01:39:26AM +, osstest service owner wrote: > flight 127504 xen-unstable real [real] > http://logs.test-lab.xenproject.org/osstest/logs/127504/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-amd64-

Re: [Xen-devel] Xen 4.12 Development Update

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 08:54, wrote: > === x86 === > > * guest resource mapping (v18) > - Paul Durrant That's all gone in by now? Paul? > * hypervisor x86 instruction emulator additions (v4) > - Jan Beulich Where's this "v4" coming from? The presently relevant series is at v2 right now, w

Re: [Xen-devel] Xen 4.12 Development Update

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 09:21 > To: Paul Durrant ; Juergen Gross > > Cc: xen-devel > Subject: Re: Xen 4.12 Development Update > > >>> On 12.09.18 at 08:54, wrote: > > === x86 === > > > > * guest resource mapping (v18

Re: [Xen-devel] [PATCH v8 1/6] iommu: rename iommu_dom0_strict and iommu_passthrough

2018-09-12 Thread Roger Pau Monné
On Fri, Sep 07, 2018 at 11:07:34AM +0200, Roger Pau Monne wrote: > To iommu_hwdom_strict and iommu_hwdom_passthrough which is more > descriptive of their usage. Also change their type from bool_t to > bool. > > No functional change. > > Signed-off-by: Roger Pau Monné > Reviewed-by: Jan Beulich

Re: [Xen-devel] [PATCH v6 13/14] x86: add iommu_ops to modify and flush IOMMU mappings

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 10:02, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 12 September 2018 08:04 >> >> >>> On 23.08.18 at 11:47, wrote: >> > +static int iommuop_map(struct xen_iommu_op_map *op) >> > +{ >> > +struct domain *d, *currd = current->domain; >> > +struct domain

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-12 Thread Sergey Dyasli
On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: > Rename them to guest_{rd,wr}msr_xen() for consistency, and because the _regs > suffix isn't very appropriate. > > Update them to take a vcpu pointer rather than presuming that they act on > current, and switch to using X86EMUL_* return valu

Re: [Xen-devel] Xen 4.12 Development Update

2018-09-12 Thread Juergen Gross
On 12/09/18 10:20, Jan Beulich wrote: On 12.09.18 at 08:54, wrote: >> === x86 === >> >> * guest resource mapping (v18) >> - Paul Durrant > > That's all gone in by now? Paul? > >> * hypervisor x86 instruction emulator additions (v4) >> - Jan Beulich > > Where's this "v4" coming fro

Re: [Xen-devel] [PATCH v2 2/4] x86/mm: use optional cache in guest_walk_tables()

2018-09-12 Thread Jan Beulich
>>> On 11.09.18 at 18:17, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 11 September 2018 14:15 >> >> --- a/xen/arch/x86/mm/guest_walk.c >> +++ b/xen/arch/x86/mm/guest_walk.c >> @@ -92,8 +92,13 @@ guest_walk_tables(struct vcpu *v, struct >> #if GUEST_PAGING_LEVELS >= 4 /* 64-bi

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 07 September 2018 12:11 > To: Paul Durrant > Cc: George Dunlap ; Kevin Tian > ; xen-devel > Subject: Re: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops > > >>> On 23.08.18 at 11:47, wrote: > > This pa

[Xen-devel] [libvirt test] 127524: regressions - FAIL

2018-09-12 Thread osstest service owner
flight 127524 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/127524/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 123814 build-amd64-libvirt

Re: [Xen-devel] [PATCH v2 3/4] x86/HVM: implement memory read caching

2018-09-12 Thread Jan Beulich
>>> On 11.09.18 at 18:20, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 11 September 2018 14:15 >> >> @@ -2664,9 +2685,35 @@ void hvm_dump_emulation_state(const char >> hvmemul_ctxt->insn_buf); >> } >> >> +struct hvmemul_cache *hvmemul_cache_init(unsigned int nents

Re: [Xen-devel] Xen 4.12 Development Update

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 10:30, wrote: > On 12/09/18 10:20, Jan Beulich wrote: > On 12.09.18 at 08:54, wrote: >>> === x86 === >>> >>> * guest resource mapping (v18) >>> - Paul Durrant >> >> That's all gone in by now? Paul? >> >>> * hypervisor x86 instruction emulator additions (v4) >>> -

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 10:31, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 07 September 2018 12:11 >> >> >>> On 23.08.18 at 11:47, wrote: >> > This patch adds a new method to the VT-d IOMMU implementation to find >> the >> > MFN currently mapped by the specified BFN along with a w

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 09:44 > To: Paul Durrant > Cc: George Dunlap ; Kevin Tian > ; xen-devel > Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops > > >>> On 12.09.18 at 10:31, wrote: > >> From:

Re: [Xen-devel] [PATCH v2 3/4] x86/HVM: implement memory read caching

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 09:38 > To: Paul Durrant > Cc: Andrew Cooper ; George Dunlap > ; Wei Liu ; xen-devel > > Subject: RE: [PATCH v2 3/4] x86/HVM: implement memory read caching > > >>> On 11.09.18 at 18:20, wrote:

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Paul Durrant > Sent: 12 September 2018 09:45 > To: 'Jan Beulich' > Cc: xen-devel ; Kevin Tian > ; George Dunlap > Subject: Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Paul Durrant > Sent: 12 September 2018 09:52 > To: Paul Durrant ; 'Jan Beulich' > > Cc: xen-devel ; Kevin Tian > ; George Dunlap > Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops > > > -Original Message- > > From: Xen-devel [mai

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 10:45, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 12 September 2018 09:44 >> To: Paul Durrant >> Cc: George Dunlap ; Kevin Tian >> ; xen-devel >> Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops >> >> >

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 10:53, wrote: >> From: Paul Durrant >> Sent: 12 September 2018 09:52 >> >> > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On >> Behalf >> > Of Paul Durrant >> > Sent: 12 September 2018 09:45 >> > >> > > From: Jan Beulich [mailto:jbeul...@suse.com] >> > > Sent

Re: [Xen-devel] [PATCH v3] xen:arm: Populate arm64 image header

2018-09-12 Thread Andre Przywara
Hi, On 11/09/2018 17:48, Amit Singh Tomar wrote: > This patch adds image size and flags to XEN image header. It uses > those fields according to the updated Linux kernel image definition. > > With this patch bootloader can now place XEN image anywhere in system > RAM at 2MB aligned address withou

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 10:03 > To: Paul Durrant > Cc: George Dunlap ; Kevin Tian > ; xen-devel > Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops > > >>> On 12.09.18 at 10:53, wrote: > >> From:

[Xen-devel] [PATCH] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case

2018-09-12 Thread Jan Beulich
The function does two translations in one go for a single guest access. Any failure of the first translation step (guest linear -> guest physical), resulting in #PF, ought to take precedence over any failure of the second step (guest physical -> host physical). Bail out of the loop early solely whe

Re: [Xen-devel] [PATCH v6 12/14] memory: add get_paged_gfn() as a wrapper...

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Jan Beulich > Sent: 11 September 2018 15:56 > To: Paul Durrant > Cc: Stefano Stabellini ; Wei Liu > ; Konrad Rzeszutek Wilk ; > George Dunlap ; Andrew Cooper > ; Ian Jackson ; Tim > (Xen.o

Re: [Xen-devel] [RFC PATCH 1/2] xen/arm: Add Amlogic S905 SoC early printk support

2018-09-12 Thread Julien Grall
On 09/12/2018 07:43 AM, Amit Tomer wrote: Hello, I am trying to understand why Linux is doing it. Do you expect all U-Boot version to do it? It's because Linux doesn't really trust u-boot and initializes every thing again ? You don't know the state of the UART once you left U-boot. For e

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-12 Thread Andrew Cooper
On 12/09/18 09:29, Sergey Dyasli wrote: > On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: >> Rename them to guest_{rd,wr}msr_xen() for consistency, and because the _regs >> suffix isn't very appropriate. >> >> Update them to take a vcpu pointer rather than presuming that they act on >> curr

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 11:05, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 12 September 2018 10:03 >> >> A HVM guest using the PV IOMMU is quite fine, but it shouldn't talk to >> it in terms of MFNs. >> > > Well, it has to talk MFNs at some level, surely? The output of the IOMMU

Re: [Xen-devel] [PATCH] drivers/block/xen-blkback/common.h: use DIV_ROUND_UP instead of reimplementing its function

2018-09-12 Thread Roger Pau Monné
Adding Julien how did the work to support XEN_PAGE_SIZE != PAGE_SIZE. On Wed, Sep 12, 2018 at 02:14:26AM -0600, Jan Beulich wrote: > >>> On 12.09.18 at 07:45, wrote: > > --- a/drivers/block/xen-blkback/common.h > > +++ b/drivers/block/xen-blkback/common.h > > @@ -65,7 +65,7 @@ > > (XEN_PAGES_

Re: [Xen-devel] [PATCH v6 12/14] memory: add get_paged_gfn() as a wrapper...

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 11:10, wrote: >> From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf >> Of Jan Beulich >> Sent: 11 September 2018 15:56 >> >> >>> On 23.08.18 at 11:47, wrote: >> > ...for some uses of get_page_from_gfn(). >> > >> > There are many occurences of the followi

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 10:13 > To: Paul Durrant > Cc: George Dunlap ; Kevin Tian > ; xen-devel > Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops > > >>> On 12.09.18 at 11:05, wrote: > >> From:

Re: [Xen-devel] [PATCH v2 1/1] cameraif: add ABI for para-virtual camera

2018-09-12 Thread Hans Verkuil
On 09/11/18 10:29, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > This is the ABI for the two halves of a para-virtualized > camera driver which extends Xen's reach multimedia capabilities even > farther enabling it for video conferencing, In-Vehicle Infotainment, > high defin

Re: [Xen-devel] [PATCH] drivers/block/xen-blkback/common.h: use DIV_ROUND_UP instead of reimplementing its function

2018-09-12 Thread Roger Pau Monné
Sorry, I've failed to add Julien in my previous reply. On Wed, Sep 12, 2018 at 11:13:50AM +0200, Roger Pau Monné wrote: > Adding Julien how did the work to support XEN_PAGE_SIZE != PAGE_SIZE. > > On Wed, Sep 12, 2018 at 02:14:26AM -0600, Jan Beulich wrote: > > >>> On 12.09.18 at 07:45, wrote: >

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 11:12, wrote: > On 12/09/18 09:29, Sergey Dyasli wrote: >> On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: >>> @@ -822,13 +818,13 @@ int wrmsr_hypervisor_regs(uint32_t idx, uint64_t val) >>> if ( p2m_is_paging(t) ) >>> { >>> p2m

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 11:15, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 12 September 2018 10:13 >> To: Paul Durrant >> Cc: George Dunlap ; Kevin Tian >> ; xen-devel >> Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops >> >> >

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-12 Thread Andrew Cooper
On 12/09/18 10:17, Jan Beulich wrote: On 12.09.18 at 11:12, wrote: >> On 12/09/18 09:29, Sergey Dyasli wrote: >>> On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: @@ -822,13 +818,13 @@ int wrmsr_hypervisor_regs(uint32_t idx, uint64_t val) if ( p2m_is_paging(t) )

Re: [Xen-devel] [PATCH] schedule: move last_run_time to the credit scheduler privates

2018-09-12 Thread Andrii Anisov
Hello Dario, On 12.09.18 11:14, Dario Faggioli wrote: I think that, while we're doing this, we should take the chance to convert the type to s_time_t too. Good point, as well as renaming scurr. -- *Andrii Anisov* ___ Xen-devel mailing list Xen-dev

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 10:21 > To: Paul Durrant > Cc: George Dunlap ; Kevin Tian > ; xen-devel > Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops > > >>> On 12.09.18 at 11:15, wrote: > >> -

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-12 Thread Sergey Dyasli
On Wed, 2018-09-12 at 10:12 +0100, Andrew Cooper wrote: > On 12/09/18 09:29, Sergey Dyasli wrote: > > On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: > > > Rename them to guest_{rd,wr}msr_xen() for consistency, and because the > > > _regs > > > suffix isn't very appropriate. > > > > > > U

[Xen-devel] [PATCH v2] x86/mm: Suppresses vm_events caused by page-walks

2018-09-12 Thread Alexandru Isaila
The original version of the patch emulated the current instruction (which, as a side-effect, emulated the page-walk as well), however we need finer-grained control. We want to emulate the page-walk, but still get an EPT violation event if the current instruction would trigger one. This patch perfor

Re: [Xen-devel] [PATCH] drivers/block/xen-blkback/common.h: use DIV_ROUND_UP instead of reimplementing its function

2018-09-12 Thread Julien Grall
Hi, On 09/12/2018 10:16 AM, Roger Pau Monné wrote: On Wed, Sep 12, 2018 at 11:13:50AM +0200, Roger Pau Monné wrote: Adding Julien how did the work to support XEN_PAGE_SIZE != PAGE_SIZE. On Wed, Sep 12, 2018 at 02:14:26AM -0600, Jan Beulich wrote: On 12.09.18 at 07:45, wrote: --- a/drivers/b

[Xen-devel] [xen-unstable-coverity test] 127530: all pass - PUSHED

2018-09-12 Thread osstest service owner
flight 127530 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/127530/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 1dfb8e6e0948912d1fd96d6ed9034527c5c74f31 baseline version: xen 1d06

Re: [Xen-devel] [PATCH] libxl: made vm mac address assignment deterministic

2018-09-12 Thread Marcus Granado
Wei Liu writes ("Re: [PATCH] libxl: made vm mac address assignment deterministic"): On Wed, Sep 05, 2018 at 12:25:55PM +, Joshua Perrett wrote: > Uses MD5 on the host mac address, vm name and vif index to generate the > last three bytes of the vm mac address (for each vm). There is no such

[Xen-devel] [ovmf test] 127528: all pass - PUSHED

2018-09-12 Thread osstest service owner
flight 127528 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/127528/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 4423f0bc613b5451feaa546c3f330ad625d65638 baseline version: ovmf 5c9ac43f47865bb9b1360

Re: [Xen-devel] [PATCH v6 12/14] memory: add get_paged_gfn() as a wrapper...

2018-09-12 Thread George Dunlap
On 09/12/2018 10:15 AM, Jan Beulich wrote: On 12.09.18 at 11:10, wrote: >>> From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf >>> Of Jan Beulich >>> Sent: 11 September 2018 15:56 >>> >> On 23.08.18 at 11:47, wrote: ...for some uses of get_page_from_gfn(). >>>

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 11:24, wrote: > On 12/09/18 10:17, Jan Beulich wrote: > On 12.09.18 at 11:12, wrote: >>> On 12/09/18 09:29, Sergey Dyasli wrote: On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: > @@ -822,13 +818,13 @@ int wrmsr_hypervisor_regs(uint32_t idx, uint64_t >

Re: [Xen-devel] [PATCH v6 12/14] memory: add get_paged_gfn() as a wrapper...

2018-09-12 Thread Paul Durrant
> -Original Message- > From: George Dunlap [mailto:george.dun...@citrix.com] > Sent: 12 September 2018 11:02 > To: Jan Beulich ; Paul Durrant > > Cc: Julien Grall ; Andrew Cooper > ; Ian Jackson ; Wei > Liu ; Stefano Stabellini ; xen- > devel ; Konrad Rzeszutek Wilk > ; Tim (Xen.org) > Su

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 11:30, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 12 September 2018 10:21 >> To: Paul Durrant >> Cc: George Dunlap ; Kevin Tian >> ; xen-devel >> Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops >> >> >

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 11:08 > To: Paul Durrant > Cc: George Dunlap ; Kevin Tian > ; xen-devel > Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops > > >>> On 12.09.18 at 11:30, wrote: > >> -

Re: [Xen-devel] [PATCH v2 1/1] cameraif: add ABI for para-virtual camera

2018-09-12 Thread Oleksandr Andrushchenko
Hi, Hans! Thank you for valuable comments and valid concerns! On 09/12/2018 10:52 AM, Hans Verkuil wrote: On 09/11/2018 10:29 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko This is the ABI for the two halves of a para-virtualized camera driver which extends Xen's reach mult

Re: [Xen-devel] [PATCH v6 12/14] memory: add get_paged_gfn() as a wrapper...

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 12:01, wrote: > On 09/12/2018 10:15 AM, Jan Beulich wrote: > On 12.09.18 at 11:10, wrote: From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf Of Jan Beulich Sent: 11 September 2018 15:56 >>> On 23.08.18 at 11:47, wrote: > .

Re: [Xen-devel] [PATCH v2 1/1] cameraif: add ABI for para-virtual camera

2018-09-12 Thread Oleksandr Andrushchenko
On 09/12/2018 12:16 PM, Hans Verkuil wrote: On 09/11/18 10:29, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko This is the ABI for the two halves of a para-virtualized camera driver which extends Xen's reach multimedia capabilities even farther enabling it for video conferencing,

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-12 Thread Andrew Cooper
On 12/09/18 10:46, Sergey Dyasli wrote: > On Wed, 2018-09-12 at 10:12 +0100, Andrew Cooper wrote: >> On 12/09/18 09:29, Sergey Dyasli wrote: >>> On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: Rename them to guest_{rd,wr}msr_xen() for consistency, and because the _regs suffi

Re: [Xen-devel] [PATCH v7 2/8] libxl: introduce a new structure to represent static shared memory regions

2018-09-12 Thread Julien Grall
On 09/12/2018 12:09 AM, Stefano Stabellini wrote: + +/* Constants for libxl_static_shm */ +#define LIBXL_SSHM_RANGE_UNKNOWN UINT64_MAX +#define LIBXL_SSHM_ID_MAXLEN128 Why do you need to bound the size of the string? It is passed by the user, it is good to be clear about the max size?

Re: [Xen-devel] [PATCH] drivers/block/xen-blkback/common.h: use DIV_ROUND_UP instead of reimplementing its function

2018-09-12 Thread Roger Pau Monné
On Wed, Sep 12, 2018 at 10:48:42AM +0100, Julien Grall wrote: > Hi, > > On 09/12/2018 10:16 AM, Roger Pau Monné wrote: > > On Wed, Sep 12, 2018 at 11:13:50AM +0200, Roger Pau Monné wrote: > > > Adding Julien how did the work to support XEN_PAGE_SIZE != PAGE_SIZE. > > > > > > On Wed, Sep 12, 2018

[Xen-devel] [linux-linus test] 127516: regressions - FAIL

2018-09-12 Thread osstest service owner
flight 127516 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/127516/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs. 125898

Re: [Xen-devel] [PATCH] libxl: made vm mac address assignment deterministic

2018-09-12 Thread George Dunlap
On 09/12/2018 10:54 AM, Marcus Granado wrote: >> Wei Liu writes ("Re: [PATCH] libxl: made vm mac address assignment >> deterministic"): >>> On Wed, Sep 05, 2018 at 12:25:55PM +, Joshua Perrett wrote: >>> > Uses MD5 on the host mac address, vm name and vif index to generate >>> the >>> > last th

Re: [Xen-devel] [PATCH v2 08/13] optee: add support for RPC SHM buffers

2018-09-12 Thread Julien Grall
Hi Volodymyr, On 09/11/2018 08:30 PM, Volodymyr Babchuk wrote: On 11.09.18 14:53, Julien Grall wrote: On 10/09/18 18:44, Volodymyr Babchuk wrote: On 10.09.18 16:01, Julien Grall wrote: On 03/09/18 17:54, Volodymyr Babchuk wrote: OP-TEE usually uses the same idea with command buffers (see pre

Re: [Xen-devel] [PATCH v2 09/13] optee: add support for arbitrary shared memory

2018-09-12 Thread Julien Grall
On 09/11/2018 08:33 PM, Volodymyr Babchuk wrote: Hi Julien, Hi, On 11.09.18 16:37, Julien Grall wrote: Hi Volodymyr, On 10/09/18 19:04, Volodymyr Babchuk wrote: On 10.09.18 17:02, Julien Grall wrote: On 03/09/18 17:54, Volodymyr Babchuk wrote: [...] +    if ( !pages_data_xen_start )

[Xen-devel] [PATCH v7 4/6] iommu: don't domain_crash() inside iommu_map/unmap_page()

2018-09-12 Thread Paul Durrant
This patch removes the implicit domain_crash() from iommu_map(), unmap_page() and iommu_iotlb_flush() and turns them into straightforward wrappers that check the existence of the relevant iommu_op and call through to it. This makes them usable by PV IOMMU code to be delivered in future patches. Thi

[Xen-devel] [PATCH v7 2/6] iommu: make use of type-safe DFN and MFN in exported functions

2018-09-12 Thread Paul Durrant
This patch modifies the declaration of the entry points to the IOMMU sub-system to use dfn_t and mfn_t in place of unsigned long. A subsequent patch will similarly modify the methods in the iommu_ops structure. Signed-off-by: Paul Durrant Reviewed-by: Wei Liu Reviewed-by: Kevin Tian Acked-by: J

[Xen-devel] [PATCH v7 3/6] iommu: push use of type-safe DFN and MFN into iommu_ops

2018-09-12 Thread Paul Durrant
This patch modifies the methods in struct iommu_ops to use type-safe DFN and MFN. This follows on from the prior patch that modified the functions exported in xen/iommu.h. Signed-off-by: Paul Durrant Reviewed-by: Wei Liu Reviewed-by: Kevin Tian Acked-by: Jan Beulich --- Cc: Suravee Suthikulpan

[Xen-devel] [PATCH v7 1/6] iommu: introduce the concept of DFN...

2018-09-12 Thread Paul Durrant
...meaning 'device DMA frame number' i.e. a frame number mapped in the IOMMU (rather than the MMU) and hence used for DMA address translation. This patch is a largely cosmetic change that substitutes the terms 'gfn' and 'gaddr' for 'dfn' and 'daddr' in all the places where the frame number or addr

[Xen-devel] [PATCH v7 5/6] memory: add check_get_page_from_gfn() as a wrapper...

2018-09-12 Thread Paul Durrant
...for some uses of get_page_from_gfn(). There are many occurences of the following pattern in the code: q = ? P2M_ALLOC : P2M_UNSHARE; page = get_page_from_gfn(d, gfn, &p2mt, q); if ( p2m_is_paging(p2mt) ) { if ( page ) put_page(page); p2m_mem_pagin

[Xen-devel] [PATCH v7 0/6] paravirtual IOMMU pre-requisites and clean-up

2018-09-12 Thread Paul Durrant
This series contains pre-requisites and clean-up needed for paravirtual IOMMU support. I have separated these patches to avoid further delaying their application whilst I re-work the implementation of paravirtual IOMMU after review of v6 of the series. Several of them already have all necessary ac

[Xen-devel] [PATCH v7 6/6] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Paul Durrant
This patch adds a new method to the VT-d IOMMU implementation to find the MFN currently mapped by the specified DFN along with a wrapper function in generic IOMMU code to call the implementation if it exists. This patch also cleans up the initializers in intel_iommu_map_page() and uses array-style

Re: [Xen-devel] [PATCH v2] xen/vcpu: Rework sanity checks in vcpu_create()

2018-09-12 Thread Jason Andryuk
On Tue, Sep 11, 2018 at 12:48 PM Andrew Cooper wrote: > > Poisoning idle_vcpu[0] with the sanity debug value isn't actually a clever > idea, because it passes a NULL pointer check but isn't a usable vcpu. It is > also the reason for the (!is_idle_domain(d) || vcpu_id) part of the existing > sanit

[Xen-devel] [distros-debian-squeeze test] 75204: trouble: blocked/broken

2018-09-12 Thread Platform Team regression test user
flight 75204 distros-debian-squeeze real [real] http://osstest.xensource.com/osstest/logs/75204/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-pvopsbroken build-i386

Re: [Xen-devel] [PATCH v7 1/6] iommu: introduce the concept of DFN...

2018-09-12 Thread Andrew Cooper
On 12/09/18 12:30, Paul Durrant wrote: > diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h > index e35d941f3c..19d5d55d79 100644 > --- a/xen/include/xen/iommu.h > +++ b/xen/include/xen/iommu.h > @@ -23,11 +23,37 @@ > #include > #include > #include > +#include > #include > #in

Re: [Xen-devel] v4.19-rc3, wrong pageflags in dom0

2018-09-12 Thread Juergen Gross
On 10/09/18 17:03, Olaf Hering wrote: > Am Mon, 10 Sep 2018 14:49:07 +0200 > schrieb Olaf Hering : > >> After reboot I tried to start my HVM domU, this is what I get in dom0: >> [ 223.019451] page:ea007bed9040 count:1 mapcount:-1 >> mapping: index:0x0 > > this also happens w

Re: [Xen-devel] [PATCH] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 10:10 > To: xen-devel > Cc: Andrew Cooper ; Paul Durrant > > Subject: [PATCH] x86/HVM: correct hvmemul_map_linear_addr() for multi- > page case > > The function does two translations in one go f

Re: [Xen-devel] [PATCH v8 1/6] iommu: rename iommu_dom0_strict and iommu_passthrough

2018-09-12 Thread Suravee Suthikulpanit
Roger, On 9/7/18 4:07 PM, Roger Pau Monne wrote: To iommu_hwdom_strict and iommu_hwdom_passthrough which is more descriptive of their usage. Also change their type from bool_t to bool. No functional change. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich Reviewed-by: Kevin Tian Reviewe

Re: [Xen-devel] [PATCH v8 3/6] iommu: make iommu_inclusive_mapping a suboption of dom0-iommu

2018-09-12 Thread Suravee Suthikulpanit
On 9/7/18 4:07 PM, Roger Pau Monne wrote: Introduce a new dom0-iommu=map-inclusive generic option that supersedes iommu_inclusive_mapping. The previous behavior is preserved and the option should only be enabled by default on Intel hardware. Signed-off-by: Roger Pau Monné Reviewed-by: Paul Dur

Re: [Xen-devel] [PATCH v8 6/6] x86/iommu: add map-reserved dom0-iommu option to map reserved memory ranges

2018-09-12 Thread Suravee Suthikulpanit
On 9/7/18 4:07 PM, Roger Pau Monne wrote: Several people have reported hardware issues (malfunctioning USB controllers) due to iommu page faults on Intel hardware. Those faults are caused by missing RMRR (VTd) entries in the ACPI tables. Those can be worked around on VTd hardware by manually ad

[Xen-devel] [PATCH v4 1/3] x86/msr: Dispatch Xen and Viridian MSRs from guest_{wr, rd}msr()

2018-09-12 Thread Andrew Cooper
Despite the complicated diff in {svm,vmx}_msr_write_intercept(), it is just the 0 case losing one level of indentation, as part of removing the call to wrmsr_hypervisor_regs(). The case blocks in guest_{wr,rd}msr() use raw numbers, partly for consistency with the CPUID side of things, but mainly b

Re: [Xen-devel] [PATCH v7 1/6] iommu: introduce the concept of DFN...

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper > Sent: 12 September 2018 12:49 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Kevin Tian ; Stefano Stabellini > ; Wei Liu ; Suravee > Suthikulpanit ; Julien Grall > ; Jan Beulich > Subject: Re: [Xen-devel] [PATCH v7 1/6] iommu: introdu

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-12 Thread Andrew Cooper
On 12/09/18 11:05, Jan Beulich wrote: On 12.09.18 at 11:24, wrote: >> On 12/09/18 10:17, Jan Beulich wrote: >> On 12.09.18 at 11:12, wrote: On 12/09/18 09:29, Sergey Dyasli wrote: > On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: >> @@ -822,13 +818,13 @@ int wrmsr_hy

Re: [Xen-devel] [PATCH] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 13:51, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 12 September 2018 10:10 >> To: xen-devel >> Cc: Andrew Cooper ; Paul Durrant >> >> Subject: [PATCH] x86/HVM: correct hvmemul_map_linear_addr() for multi- >> page case >> >> T

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 12:09, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 12 September 2018 11:08 >> To: Paul Durrant >> Cc: George Dunlap ; Kevin Tian >> ; xen-devel >> Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops >> >> >

Re: [Xen-devel] [PATCH v7 1/6] iommu: introduce the concept of DFN...

2018-09-12 Thread Roger Pau Monné
On Wed, Sep 12, 2018 at 12:30:23PM +0100, Paul Durrant wrote: > diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h > index e35d941f3c..19d5d55d79 100644 > --- a/xen/include/xen/iommu.h > +++ b/xen/include/xen/iommu.h > @@ -23,11 +23,37 @@ > #include > #include > #include > +#inclu

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 13:15 > To: Paul Durrant > Cc: George Dunlap ; Kevin Tian > ; xen-devel > Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops > > >>> On 12.09.18 at 12:09, wrote: > >> -

Re: [Xen-devel] [PATCH v2 1/1] cameraif: add ABI for para-virtual camera

2018-09-12 Thread Hans Verkuil
On 09/12/18 12:09, Oleksandr Andrushchenko wrote: > Hi, Hans! > > Thank you for valuable comments and valid concerns! > > On 09/12/2018 10:52 AM, Hans Verkuil wrote: >> On 09/11/2018 10:29 AM, Oleksandr Andrushchenko wrote: >>> From: Oleksandr Andrushchenko >>> >>> This is the ABI for the two ha

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 14:22, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 12 September 2018 13:15 >> To: Paul Durrant >> Cc: George Dunlap ; Kevin Tian >> ; xen-devel >> Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops >> >> >

  1   2   >