Re: [Xen-devel] [Qemu-devel] [PATCH] RFC: chardev: mark the calls that allow an implicit mux monitor

2018-08-24 Thread Markus Armbruster
Marc-André Lureau writes: > This is mostly for readability of the code. Let's make it clear which > callers can create an implicit monitor when the chardev is muxed. > > This will also enforce a safer behaviour, as we don't really support > creating monitor anywhere/anytime at the moment. > > The

Re: [Xen-devel] [PATCH] xen/gntdev: fix up blockable calls to mn_invl_range_start

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 07:03:28, Juergen Gross wrote: > On 23/08/18 21:09, Michal Hocko wrote: > > On Thu 23-08-18 10:06:53, Boris Ostrovsky wrote: > >> On 08/23/2018 09:51 AM, Michal Hocko wrote: > >>> On Thu 23-08-18 22:44:07, Tetsuo Handa wrote: > On 2018/08/23 21:07, Michal Hocko wrote: > > d

Re: [Xen-devel] [PATCH v2 00/10] arm: add one kconfig option per platform

2018-08-24 Thread Julien Grall
On 24/08/18 00:33, Stefano Stabellini wrote: Hi all, Hi, This patch series introduces one kconfig option for each remaing platform under platforms/. Each kconfig option enables the required drivers in Xen. Cheers, Stefano Changes in v2: - remove all platform options except for thunderx

Re: [Xen-devel] [PATCH v2 1/6] xen/arm: add THUNDERX kconfig

2018-08-24 Thread Julien Grall
Hi, On 24/08/18 00:33, Stefano Stabellini wrote: Add a kconfig option for Cavium ThunderX platforms. > Signed-off-by: Stefano Stabellini CC: mja...@caviumnetworks.com CC: zi@cavium.com --- Changes in v2: - remove HAS_SMMU --- xen/arch/arm/platforms/Kconfig | 13 + xen/arch/a

Re: [Xen-devel] [PATCH v2 6/6] xen/arm: introduce NO_PLAT

2018-08-24 Thread Julien Grall
Hi, On 24/08/18 00:33, Stefano Stabellini wrote: Add a Kconfig option to select no specific platform support. That's not entirely true. After this series applied, there are still some obj-y present in the Makefile. Cheers, Signed-off-by: Stefano Stabellini --- xen/arch/arm/platforms/K

Re: [Xen-devel] [PATCH v2 3/6] xen/arm: add RCAR2 kconfig

2018-08-24 Thread Julien Grall
Hi, On 24/08/18 00:33, Stefano Stabellini wrote: Add a kconfig option for Renesas Rcar2 platforms. Signed-off-by: Stefano Stabellini Reviewed-by: Andrii Anisov CC: iurii.konovale...@globallogic.com --- xen/arch/arm/platforms/Kconfig | 11 +++ xen/arch/arm/platforms/Makefile | 2 +

Re: [Xen-devel] Backport request - 3a2b8525b883baa87fe89b3da58f5c09fa599b99 to staging-4.9

2018-08-24 Thread Wei Liu
CC Ian On Fri, Aug 24, 2018 at 12:32:57PM +1000, Steven Haigh wrote: > Commit: > http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=3a2b8525b883baa87fe89b3da58f5c09fa599b99 > > I've also run across this building the staging-4.9 branch on RHEL7. > > Build errors with: > gcc -m64 -DBUILD_ID -fno

Re: [Xen-devel] Unable to build staging-4.9 on RHEL6

2018-08-24 Thread Wei Liu
Cc Anthony On Fri, Aug 24, 2018 at 12:56:49PM +1000, Steven Haigh wrote: > Hi all, > > When trying to build both xen and qemu-xen from the staging-4.9 branches, > I'm running into issues compiling. > > Errors start with: > > BUILDSTDERR: sse.c: In function 'simd_test': > BUILDSTDERR: sse.c:319:

Re: [Xen-devel] [xen-4.9-testing test] 126201: regressions - FAIL

2018-08-24 Thread Wei Liu
On Wed, Aug 22, 2018 at 04:52:27PM -0600, Jim Fehlig wrote: > On 08/21/2018 05:14 AM, Jan Beulich wrote: > > > > > On 21.08.18 at 03:11, wrote: > > > flight 126201 xen-4.9-testing real [real] > > > http://logs.test-lab.xenproject.org/osstest/logs/126201/ > > > > > > Regressions :-( > > > > > > T

Re: [Xen-devel] [PATCH v3 2/6] xen/arm: zynqmp: Forward plaform specific firmware calls

2018-08-24 Thread Julien Grall
Hi, On 24/08/18 00:56, Stefano Stabellini wrote: On Thu, 23 Aug 2018, Julien Grall wrote: Hi Stefano, 2018 01:01 AM, Stefano Stabellini wrote: From: "Edgar E. Iglesias" From: Edgar E. Iglesias Introduce zynqmp_eemi: a function resposible for implementing access s/resposible/responsible/

Re: [Xen-devel] [linux-3.18 bisection] complete test-amd64-amd64-xl-shadow

2018-08-24 Thread Wei Liu
On Fri, Aug 24, 2018 at 12:58:43AM +, osstest service owner wrote: > branch xen-unstable > xenbranch xen-unstable > job test-amd64-amd64-xl-shadow > testid guest-start > > Tree: linux > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git > Tree: linuxfirmware git://xenbits.x

Re: [Xen-devel] L1TF, and future work

2018-08-24 Thread Dario Faggioli
On Wed, 2018-08-15 at 14:17 +0100, Andrew Cooper wrote: > Hello, > > Now that the embargo on XSA-273 is up, we can start publicly > discussing > the remaining work do, because there is plenty to do. In no > particular > order... > > > [...] > > 5) Core-aware scheduling. At the moment, Xen will

[Xen-devel] [qemu-mainline test] 126411: tolerable FAIL - PUSHED

2018-08-24 Thread osstest service owner
flight 126411 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/126411/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stopfail like 126322 test-amd64-i386-xl-qemuu-win7-amd64

Re: [Xen-devel] [linux-3.18 bisection] complete test-amd64-amd64-xl-shadow

2018-08-24 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 24 August 2018 10:13 > To: osstest service owner > Cc: xen-devel@lists.xenproject.org; Wei Liu ; Paul > Durrant > Subject: Re: [Xen-devel] [linux-3.18 bisection] complete test-amd64-amd64- > xl-shadow > > On Fri, A

Re: [Xen-devel] [linux-3.18 bisection] complete test-amd64-amd64-xl-shadow

2018-08-24 Thread Wei Liu
On Fri, Aug 24, 2018 at 10:30:26AM +0100, Paul Durrant wrote: > > > For bisection revision-tuple graph see: > > >http://logs.test-lab.xenproject.org/osstest/results/bisect/linux- > > 3.18/test-amd64-amd64-xl-shadow.guest-start.html > > > Revision IDs in each graph node refer, respectively, to t

Re: [Xen-devel] [linux-3.18 bisection] complete test-amd64-amd64-xl-shadow

2018-08-24 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 24 August 2018 10:35 > To: Paul Durrant > Cc: Wei Liu ; osstest service owner ad...@xenproject.org>; xen-devel@lists.xenproject.org > Subject: Re: [Xen-devel] [linux-3.18 bisection] complete test-amd64-amd64- > xl-s

Re: [Xen-devel] An issue in sharing the pages again in xen-memshare

2018-08-24 Thread sepanta s
Hi again, I debugged the kernel codes and found out the root cause. The sharing is not done for some pages causing error -E2BIG which is due to reference count being more than one. This prevents hypervor to nominate the page. As much as I know about this issue, the page that I want to nominate and

Re: [Xen-devel] [linux-3.18 bisection] complete test-amd64-amd64-xl-shadow

2018-08-24 Thread Wei Liu
On Fri, Aug 24, 2018 at 10:35:52AM +0100, Paul Durrant wrote: > > -Original Message- > > From: Wei Liu [mailto:wei.l...@citrix.com] > > Sent: 24 August 2018 10:35 > > To: Paul Durrant > > Cc: Wei Liu ; osstest service owner > ad...@xenproject.org>; xen-devel@lists.xenproject.org > > Subje

[Xen-devel] [linux-4.9 bisection] complete test-amd64-amd64-xl

2018-08-24 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-xl testid guest-start Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tr

Re: [Xen-devel] [linux-3.18 bisection] complete test-amd64-amd64-xl-shadow

2018-08-24 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 24 August 2018 10:38 > To: Paul Durrant > Cc: Wei Liu ; osstest service owner ad...@xenproject.org>; xen-devel@lists.xenproject.org > Subject: Re: [Xen-devel] [linux-3.18 bisection] complete test-amd64-amd64- > xl-s

Re: [Xen-devel] An issue in sharing the pages again in xen-memshare

2018-08-24 Thread Razvan Cojocaru
On 8/24/18 8:07 AM, sepanta s wrote: > I debugged the kernel codes and found out the root cause. > The sharing is not done for some pages causing error -E2BIG which is due > to reference count being more than one. This prevents hypervor to > nominate the page. As much as I know about this issue, th

Re: [Xen-devel] [linux-3.18 bisection] complete test-amd64-amd64-xl-shadow

2018-08-24 Thread Wei Liu
On Fri, Aug 24, 2018 at 10:44:09AM +0100, Paul Durrant wrote: > > -Original Message- > > From: Wei Liu [mailto:wei.l...@citrix.com] > > Sent: 24 August 2018 10:38 > > To: Paul Durrant > > Cc: Wei Liu ; osstest service owner > ad...@xenproject.org>; xen-devel@lists.xenproject.org > > Subje

Re: [Xen-devel] [linux-3.18 bisection] complete test-amd64-amd64-xl-shadow

2018-08-24 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 24 August 2018 10:50 > To: Paul Durrant > Cc: Wei Liu ; osstest service owner ad...@xenproject.org>; xen-devel@lists.xenproject.org > Subject: Re: [Xen-devel] [linux-3.18 bisection] complete test-amd64-amd64- > xl-s

[Xen-devel] [PATCH] hvmloader: fix build with LLVM Linker

2018-08-24 Thread Roger Pau Monne
The hvmloader binary generated when using LLVM LD doesn't work properly and seems to get stuck while trying to generate and load the ACPI tables. This is caused by the layout of the binary when linked with LLVM LD. LLVM LD has a different default linker script that GNU LD, and the resulting hvmloa

Re: [Xen-devel] [linux-3.18 bisection] complete test-amd64-amd64-xl-shadow

2018-08-24 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Paul Durrant > Sent: 24 August 2018 10:52 > To: Wei Liu > Cc: xen-devel@lists.xenproject.org; Wei Liu ; osstest > service owner > Subject: Re: [Xen-devel] [linux-3.18 bisection] complete

[Xen-devel] [libvirt test] 126429: regressions - FAIL

2018-08-24 Thread osstest service owner
flight 126429 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/126429/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 123814 build-amd64-libvirt

Re: [Xen-devel] [PATCH v7 3/6] iommu: make iommu_inclusive_mapping a suboption of dom0-iommu

2018-08-24 Thread Roger Pau Monné
On Wed, Aug 22, 2018 at 10:45:28AM +0100, Wei Liu wrote: > On Wed, Aug 22, 2018 at 09:51:57AM +0200, Roger Pau Monne wrote: > > Introduce a new dom0-iommu=map-inclusive generic option that > > supersedes iommu_inclusive_mapping. The previous behavior is preserved > > and the option should only be e

Re: [Xen-devel] [libvirt test] 126429: regressions - FAIL

2018-08-24 Thread Wei Liu
On Fri, Aug 24, 2018 at 10:25:49AM +, osstest service owner wrote: > flight 126429 libvirt real [real] > http://logs.test-lab.xenproject.org/osstest/logs/126429/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > build-i386-libv

Re: [Xen-devel] [PATCH v7 4/6] mm: introduce a helper to get the memory type of a page

2018-08-24 Thread Roger Pau Monné
On Wed, Aug 22, 2018 at 10:45:34AM +0100, Wei Liu wrote: > On Wed, Aug 22, 2018 at 09:51:58AM +0200, Roger Pau Monne wrote: > > Returns all the memory types applicable to a page. > > > > This function is unimplemented for ARM. > > > > Signed-off-by: Roger Pau Monné > > Reviewed-by: Jan Beulich

[Xen-devel] [distros-debian-jessie test] 75115: regressions - FAIL

2018-08-24 Thread Platform Team regression test user
flight 75115 distros-debian-jessie real [real] http://osstest.xensource.com/osstest/logs/75115/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-i386-jessie-netboot-pvgrub 19 guest-start/debian.repeat fail REGR. vs. 75078 tes

[Xen-devel] [PATCH] tools: building IPXE should be determined by CONFIG_IPXE

2018-08-24 Thread Wei Liu
Signed-off-by: Wei Liu --- tools/firmware/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/firmware/Makefile b/tools/firmware/Makefile index ed1a1318f6..cf304fc578 100644 --- a/tools/firmware/Makefile +++ b/tools/firmware/Makefile @@ -15,7 +15,7 @@ SUBDIRS-$(CONF

Re: [Xen-devel] [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Tetsuo Handa
Two more worries for this patch. > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c > @@ -178,12 +178,18 @@ void amdgpu_mn_unlock(struct amdgpu_mn *mn) > * > * @amn: our notifier > */ > -static void amdgpu_mn_read_lock(struct amdgpu_mn *amn) > +st

Re: [Xen-devel] [PATCH] xen-netfront: wait xenbus state change when load module manually

2018-08-24 Thread Jiri Slaby
On 07/30/2018, 10:18 AM, Xiao Liang wrote: > On 07/29/2018 11:30 PM, David Miller wrote: >> From: Xiao Liang >> Date: Fri, 27 Jul 2018 17:56:08 +0800 >> >>> @@ -1330,6 +1331,11 @@ static struct net_device >>> *xennet_create_dev(struct xenbus_device *dev) >>>   netif_carrier_off(netdev); >>>  

Re: [Xen-devel] [PATCH] xen-netfront: wait xenbus state change when load module manually

2018-08-24 Thread Juergen Gross
On 24/08/18 13:12, Jiri Slaby wrote: > On 07/30/2018, 10:18 AM, Xiao Liang wrote: >> On 07/29/2018 11:30 PM, David Miller wrote: >>> From: Xiao Liang >>> Date: Fri, 27 Jul 2018 17:56:08 +0800 >>> @@ -1330,6 +1331,11 @@ static struct net_device *xennet_create_dev(struct xenbus_device *dev

Re: [Xen-devel] [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 19:54:19, Tetsuo Handa wrote: > Two more worries for this patch. > > > > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c > > @@ -178,12 +178,18 @@ void amdgpu_mn_unlock(struct amdgpu_mn *mn) > > * > > * @amn: our notifier > >

Re: [Xen-devel] [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 19:54:19, Tetsuo Handa wrote: [...] > > --- a/mm/hmm.c > > +++ b/mm/hmm.c > > @@ -177,16 +177,19 @@ static void hmm_release(struct mmu_notifier *mn, > > struct mm_struct *mm) > > up_write(&hmm->mirrors_sem); > > } > > > > -static void hmm_invalidate_range_start(struct mmu

Re: [Xen-devel] [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Christian König
Am 24.08.2018 um 13:32 schrieb Michal Hocko: On Fri 24-08-18 19:54:19, Tetsuo Handa wrote: Two more worries for this patch. --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c @@ -178,12 +178,18 @@ void amdgpu_mn_unlock(struct amdgpu_mn *mn) * * @a

Re: [Xen-devel] [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 13:43:16, Christian König wrote: > Am 24.08.2018 um 13:32 schrieb Michal Hocko: > > On Fri 24-08-18 19:54:19, Tetsuo Handa wrote: > > > Two more worries for this patch. > > > > > > > > > > > > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c > > > > +++ b/drivers/gpu/drm/amd/amdgpu

Re: [Xen-devel] [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Christian König
Am 24.08.2018 um 13:52 schrieb Michal Hocko: On Fri 24-08-18 13:43:16, Christian König wrote: Am 24.08.2018 um 13:32 schrieb Michal Hocko: On Fri 24-08-18 19:54:19, Tetsuo Handa wrote: Two more worries for this patch. --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c +++ b/drivers/gpu/drm/amd/a

Re: [Xen-devel] [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 13:57:52, Christian König wrote: > Am 24.08.2018 um 13:52 schrieb Michal Hocko: > > On Fri 24-08-18 13:43:16, Christian König wrote: [...] > > > That won't work like this there might be multiple > > > invalidate_range_start()/invalidate_range_end() pairs open at the same > > > time

[Xen-devel] [PATCH] xenforeignmemory: work around bug in older privcmd

2018-08-24 Thread Paul Durrant
Versions of linux privcmd prior to commit dc9eab6fd94d ("return -ENOTTY for unimplemented IOCTLs") will return -EINVAL rather than the conventional -ENOTTY for unimplemented codes. This breaks the error path in libxenforeignmemory resource mapping, which only translates ENOTTY into EOPNOTSUPP to in

Re: [Xen-devel] [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Christian König
Am 24.08.2018 um 14:03 schrieb Michal Hocko: On Fri 24-08-18 13:57:52, Christian König wrote: Am 24.08.2018 um 13:52 schrieb Michal Hocko: On Fri 24-08-18 13:43:16, Christian König wrote: [...] That won't work like this there might be multiple invalidate_range_start()/invalidate_range_end() p

Re: [Xen-devel] [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 14:18:44, Christian König wrote: > Am 24.08.2018 um 14:03 schrieb Michal Hocko: > > On Fri 24-08-18 13:57:52, Christian König wrote: > > > Am 24.08.2018 um 13:52 schrieb Michal Hocko: > > > > On Fri 24-08-18 13:43:16, Christian König wrote: > > [...] > > > > > That won't work like t

Re: [Xen-devel] [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Christian König
Am 24.08.2018 um 14:33 schrieb Michal Hocko: On Fri 24-08-18 14:18:44, Christian König wrote: Am 24.08.2018 um 14:03 schrieb Michal Hocko: On Fri 24-08-18 13:57:52, Christian König wrote: Am 24.08.2018 um 13:52 schrieb Michal Hocko: On Fri 24-08-18 13:43:16, Christian König wrote: [...] Tha

Re: [Xen-devel] [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 14:52:26, Christian König wrote: > Am 24.08.2018 um 14:33 schrieb Michal Hocko: [...] > > Thiking about it some more, I can imagine that a notifier callback which > > performs an allocation might trigger a memory reclaim and that in turn > > might trigger a notifier to be invoked an

Re: [Xen-devel] [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Tetsuo Handa
On 2018/08/24 20:36, Michal Hocko wrote: >> That is, this API seems to be currently used by only out-of-tree users. Since >> we can't check that nobody has memory allocation dependency, I think that >> hmm_invalidate_range_start() should return -EAGAIN if blockable == false for >> now. > > The co

[Xen-devel] [ovmf test] 126526: regressions - FAIL

2018-08-24 Thread osstest service owner
flight 126526 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/126526/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 126482 version targeted for testi

Re: [Xen-devel] [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Christian König
Am 24.08.2018 um 15:01 schrieb Michal Hocko: On Fri 24-08-18 14:52:26, Christian König wrote: Am 24.08.2018 um 14:33 schrieb Michal Hocko: [...] Thiking about it some more, I can imagine that a notifier callback which performs an allocation might trigger a memory reclaim and that in turn might

Re: [Xen-devel] [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 15:10:08, Christian König wrote: > Am 24.08.2018 um 15:01 schrieb Michal Hocko: > > On Fri 24-08-18 14:52:26, Christian König wrote: > > > Am 24.08.2018 um 14:33 schrieb Michal Hocko: > > [...] > > > > Thiking about it some more, I can imagine that a notifier callback which > > > >

Re: [Xen-devel] [PATCH] xenforeignmemory: work around bug in older privcmd

2018-08-24 Thread Wei Liu
On Fri, Aug 24, 2018 at 01:16:26PM +0100, Paul Durrant wrote: > Versions of linux privcmd prior to commit dc9eab6fd94d ("return -ENOTTY > for unimplemented IOCTLs") will return -EINVAL rather than the conventional > -ENOTTY for unimplemented codes. This breaks the error path in > libxenforeignmemor

Re: [Xen-devel] [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Christian König
Am 24.08.2018 um 15:24 schrieb Michal Hocko: On Fri 24-08-18 15:10:08, Christian König wrote: Am 24.08.2018 um 15:01 schrieb Michal Hocko: On Fri 24-08-18 14:52:26, Christian König wrote: Am 24.08.2018 um 14:33 schrieb Michal Hocko: [...] Thiking about it some more, I can imagine that a noti

Re: [Xen-devel] [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 22:02:23, Tetsuo Handa wrote: > On 2018/08/24 20:36, Michal Hocko wrote: > >> That is, this API seems to be currently used by only out-of-tree users. > >> Since > >> we can't check that nobody has memory allocation dependency, I think that > >> hmm_invalidate_range_start() should r

Re: [Xen-devel] [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 15:28:33, Christian König wrote: > Am 24.08.2018 um 15:24 schrieb Michal Hocko: > > On Fri 24-08-18 15:10:08, Christian König wrote: > > > Am 24.08.2018 um 15:01 schrieb Michal Hocko: > > > > On Fri 24-08-18 14:52:26, Christian König wrote: > > > > > Am 24.08.2018 um 14:33 schrieb M

Re: [Xen-devel] [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Christian König
Am 24.08.2018 um 15:40 schrieb Michal Hocko: On Fri 24-08-18 15:28:33, Christian König wrote: Am 24.08.2018 um 15:24 schrieb Michal Hocko: On Fri 24-08-18 15:10:08, Christian König wrote: Am 24.08.2018 um 15:01 schrieb Michal Hocko: On Fri 24-08-18 14:52:26, Christian König wrote: Am 24.08.2

Re: [Xen-devel] [PATCH v3 0/5] xen/blk: persistent grant rework

2018-08-24 Thread Juergen Gross
On 17/08/18 17:59, Roger Pau Monné wrote: > On Mon, Aug 13, 2018 at 04:01:09PM +0200, Juergen Gross wrote: >> Persistent grants are used in the Xen's blkfront/blkback drivers to >> avoid mapping/unmapping of I/O buffers in the backend for each I/O. >> >> While this speeds up processing quite a bit

Re: [Xen-devel] [PATCH v2 00/11] x86/paravirt: several cleanups

2018-08-24 Thread Juergen Gross
On 13/08/18 09:37, Juergen Gross wrote: > This series removes some no longer needed stuff from paravirt > infrastructure and puts large quantities of paravirt ops under a new > config option PARAVIRT_XXL which is selected by XEN_PV only. > > A pvops kernel without XEN_PV being configured is about

Re: [Xen-devel] [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 15:44:03, Christian König wrote: > Am 24.08.2018 um 15:40 schrieb Michal Hocko: > > On Fri 24-08-18 15:28:33, Christian König wrote: > > > Am 24.08.2018 um 15:24 schrieb Michal Hocko: > > > > On Fri 24-08-18 15:10:08, Christian König wrote: > > > > > Am 24.08.2018 um 15:01 schrieb M

Re: [Xen-devel] [PATCH v2] xen: move pv irq related functions under CONFIG_XEN_PV umbrella

2018-08-24 Thread Juergen Gross
On 08/08/18 17:13, Boris Ostrovsky wrote: > x86 maintainers, this needs you ack too even though it has "xen" tag in > the subject, thanks. Ping? Juergen > > > On 08/08/2018 02:19 AM, Juergen Gross wrote: >> All functions in arch/x86/xen/irq.c and arch/x86/xen/xen-asm*.S are >> specific to PV

Re: [Xen-devel] [PATCH v2] xen: move pv irq related functions under CONFIG_XEN_PV umbrella

2018-08-24 Thread Thomas Gleixner
On Fri, 24 Aug 2018, Juergen Gross wrote: > On 08/08/18 17:13, Boris Ostrovsky wrote: > > x86 maintainers, this needs you ack too even though it has "xen" tag in > > the subject, thanks. > > Ping? I thought I sent one already, but here you go: Acked-by: Thomas Gleixner ___

Re: [Xen-devel] [PATCH] tools: building IPXE should be determined by CONFIG_IPXE

2018-08-24 Thread Roger Pau Monné
On Fri, Aug 24, 2018 at 11:54:04AM +0100, Wei Liu wrote: > Signed-off-by: Wei Liu Reviewed-by: Roger Pau Monné ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v2 01/11] x86/paravirt: make paravirt_patch_call() and paravirt_patch_jmp() static

2018-08-24 Thread Thomas Gleixner
On Mon, 13 Aug 2018, Juergen Gross wrote: > paravirt_patch_call() and paravirt_patch_jmp() are used in paravirt.c > only. Convert them to static. > > Signed-off-by: Juergen Gross Reviewed-by: Thomas Gleixner ___ Xen-devel mailing list Xen-devel@list

Re: [Xen-devel] [PATCH v2 02/11] x86/paravirt: remove clobbers parameter from paravirt patch functions

2018-08-24 Thread Thomas Gleixner
On Mon, 13 Aug 2018, Juergen Gross wrote: > The clobbers parameter from paravirt_patch_default() et al isn't used > any longer. Remove it. > > Signed-off-by: Juergen Gross Reviewed-by: Thomas Gleixner ___ Xen-devel mailing list Xen-devel@lists.xenpr

Re: [Xen-devel] [PATCH v2 03/11] x86/paravirt: remove clobbers from struct paravirt_patch_site

2018-08-24 Thread Thomas Gleixner
On Mon, 13 Aug 2018, Juergen Gross wrote: > There is no need any longer to store the clobbers in struct > paravirt_patch_site. Remove clobbers from the struct and from the > related macros. > > While at it fix some lines longer than 80 characters. > > Signed-off-by: Juergen Gross Reviewed-by:

Re: [Xen-devel] [Qemu-devel] [PATCH] RFC: chardev: mark the calls that allow an implicit mux monitor

2018-08-24 Thread Marc-André Lureau
Hi On Fri, Aug 24, 2018 at 9:37 AM Markus Armbruster wrote: > > Marc-André Lureau writes: > > > This is mostly for readability of the code. Let's make it clear which > > callers can create an implicit monitor when the chardev is muxed. > > > > This will also enforce a safer behaviour, as we don't

[Xen-devel] [PATCH v1] x86/mm: Suppresses vm_events caused by page-walks

2018-08-24 Thread Alexandru Isaila
The original version of the patch emulated the current instruction (which, as a side-effect, emulated the page-walk as well), however we need finer-grained control. We want to emulate the page-walk, but still get an EPT violation event if the current instruction would trigger one. This patch perfor

Re: [Xen-devel] [PATCH v2 09/11] x86/paravirt: move the Xen-only pv_irq_ops under the PARAVIRT_XXL umbrella

2018-08-24 Thread Peter Zijlstra
On Mon, Aug 13, 2018 at 09:37:37AM +0200, Juergen Gross wrote: > Some of the paravirt ops defined in pv_irq_ops are for Xen PV guests > only. Define them only if CONFIG_PARAVIRT_XXL is set. > diff --git a/arch/x86/include/asm/paravirt_types.h > b/arch/x86/include/asm/paravirt_types.h > index e652e

Re: [Xen-devel] [PATCH v2 10/11] x86/paravirt: move the Xen-only pv_mmu_ops under the PARAVIRT_XXL umbrella

2018-08-24 Thread Peter Zijlstra
On Mon, Aug 13, 2018 at 09:37:38AM +0200, Juergen Gross wrote: > struct pv_mmu_ops { > + /* TLB operations */ > + void (*flush_tlb_user)(void); > + void (*flush_tlb_kernel)(void); > + void (*flush_tlb_one_user)(unsigned long addr); > + void (*flush_tlb_others)(const struct cpum

Re: [Xen-devel] [PATCH v2 09/11] x86/paravirt: move the Xen-only pv_irq_ops under the PARAVIRT_XXL umbrella

2018-08-24 Thread Juergen Gross
On 24/08/18 16:10, Peter Zijlstra wrote: > On Mon, Aug 13, 2018 at 09:37:37AM +0200, Juergen Gross wrote: >> Some of the paravirt ops defined in pv_irq_ops are for Xen PV guests >> only. Define them only if CONFIG_PARAVIRT_XXL is set. >> diff --git a/arch/x86/include/asm/paravirt_types.h >> b/arch

Re: [Xen-devel] [PATCH v2 10/11] x86/paravirt: move the Xen-only pv_mmu_ops under the PARAVIRT_XXL umbrella

2018-08-24 Thread Juergen Gross
On 24/08/18 16:12, Peter Zijlstra wrote: > On Mon, Aug 13, 2018 at 09:37:38AM +0200, Juergen Gross wrote: >> struct pv_mmu_ops { >> +/* TLB operations */ >> +void (*flush_tlb_user)(void); >> +void (*flush_tlb_kernel)(void); >> +void (*flush_tlb_one_user)(unsigned long addr); >> +

Re: [Xen-devel] [PATCH] xen-netfront: wait xenbus state change when load module manually

2018-08-24 Thread Boris Ostrovsky
On 08/24/2018 07:26 AM, Juergen Gross wrote: > On 24/08/18 13:12, Jiri Slaby wrote: >> On 07/30/2018, 10:18 AM, Xiao Liang wrote: >>> On 07/29/2018 11:30 PM, David Miller wrote: From: Xiao Liang Date: Fri, 27 Jul 2018 17:56:08 +0800 > @@ -1330,6 +1331,11 @@ static struct net_dev

Re: [Xen-devel] [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Jerome Glisse
On Fri, Aug 24, 2018 at 07:54:19PM +0900, Tetsuo Handa wrote: > Two more worries for this patch. [...] > > > --- a/mm/hmm.c > > +++ b/mm/hmm.c > > @@ -177,16 +177,19 @@ static void hmm_release(struct mmu_notifier *mn, > > struct mm_struct *mm) > > up_write(&hmm->mirrors_sem); > > } > >

[Xen-devel] [linux-linus test] 126412: regressions - FAIL

2018-08-24 Thread osstest service owner
flight 126412 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/126412/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-shadow 7 xen-boot fail REGR. vs. 125898 test-amd64-i386-xl-

Re: [Xen-devel] [PATCH v2 00/11] x86/paravirt: several cleanups

2018-08-24 Thread Peter Zijlstra
On Fri, Aug 24, 2018 at 03:52:55PM +0200, Juergen Gross wrote: > Ping? Looking good; although I messed it up a little bit by adding a new paravirt function. Thanks for doing this! ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.

[Xen-devel] [ovmf baseline-only test] 75113: tolerable FAIL

2018-08-24 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75113 ovmf real [real] http://osstest.xensource.com/osstest/logs/75113/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-ovmf-amd64 10 debian-hvm-install fail like 75111 test

Re: [Xen-devel] [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Tetsuo Handa
On 2018/08/24 22:32, Michal Hocko wrote: > On Fri 24-08-18 22:02:23, Tetsuo Handa wrote: >> I worry that (currently >> out-of-tree) users of this API are involving work / recursion. > > I do not give a slightest about out-of-tree modules. They will have to > accomodate to the new API. I have no pr

Re: [Xen-devel] [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Jerome Glisse
On Fri, Aug 24, 2018 at 02:33:41PM +0200, Michal Hocko wrote: > On Fri 24-08-18 14:18:44, Christian König wrote: > > Am 24.08.2018 um 14:03 schrieb Michal Hocko: > > > On Fri 24-08-18 13:57:52, Christian König wrote: > > > > Am 24.08.2018 um 13:52 schrieb Michal Hocko: > > > > > On Fri 24-08-18 13:

Re: [Xen-devel] [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Jerome Glisse
On Fri, Aug 24, 2018 at 11:52:25PM +0900, Tetsuo Handa wrote: > On 2018/08/24 22:32, Michal Hocko wrote: > > On Fri 24-08-18 22:02:23, Tetsuo Handa wrote: > >> I worry that (currently > >> out-of-tree) users of this API are involving work / recursion. > > > > I do not give a slightest about out-of

Re: [Xen-devel] Backport request - 3a2b8525b883baa87fe89b3da58f5c09fa599b99 to staging-4.9

2018-08-24 Thread Ian Jackson
Wei Liu writes ("Re: [Xen-devel] Backport request - 3a2b8525b883baa87fe89b3da58f5c09fa599b99 to staging-4.9"): > On Fri, Aug 24, 2018 at 12:32:57PM +1000, Steven Haigh wrote: > > Commit: > > http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=3a2b8525b883baa87fe89b3da58f5c09fa599b99 > > > > I've

Re: [Xen-devel] [PATCH] tools: building IPXE should be determined by CONFIG_IPXE

2018-08-24 Thread Ian Jackson
Wei Liu writes ("[PATCH] tools: building IPXE should be determined by CONFIG_IPXE"): > Signed-off-by: Wei Liu Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] xenforeignmemory: work around bug in older privcmd

2018-08-24 Thread Ian Jackson
Paul Durrant writes ("[PATCH] xenforeignmemory: work around bug in older privcmd"): > Versions of linux privcmd prior to commit dc9eab6fd94d ("return -ENOTTY > for unimplemented IOCTLs") will return -EINVAL rather than the conventional > -ENOTTY for unimplemented codes. This breaks the error path

[Xen-devel] [PATCH] rombios: work around clang's -Waddress-of-packed-member

2018-08-24 Thread Wei Liu
Building rombios with clang XXX fails with: tcgbios.c:1519:34: error: taking address of packed member 'u' of class or structure 'pushad_regs_t' may result in an unaligned pointer value [-Werror,-Waddress-of-packed-member] ®s->u.r32.edx);

[Xen-devel] [PATCH v2] automation: enable building rombios with clang

2018-08-24 Thread Wei Liu
Previously it is disabled because the embedded ipxe can't be built with clang. Now that ipxe is split out we can use --with-system-ipxe to work around the issue. Signed-off-by: Wei Liu --- automation/scripts/build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/automation

Re: [Xen-devel] [PATCH] rombios: work around clang's -Waddress-of-packed-member

2018-08-24 Thread Doug Goldstein
On Fri, Aug 24, 2018 at 04:22:15PM +0100, Wei Liu wrote: > Building rombios with clang XXX fails with: > > tcgbios.c:1519:34: error: taking address of packed member 'u' of class or > structure 'pushad_regs_t' may result in an unaligned pointer value > [-Werror,-Waddress-of-packed-member] >

Re: [Xen-devel] [PATCH v2] automation: enable building rombios with clang

2018-08-24 Thread Doug Goldstein
On Fri, Aug 24, 2018 at 04:22:47PM +0100, Wei Liu wrote: > Previously it is disabled because the embedded ipxe can't be built > with clang. Now that ipxe is split out we can use --with-system-ipxe > to work around the issue. > > Signed-off-by: Wei Liu > --- > +# iPXE cannot be built with clan

Re: [Xen-devel] [PATCH] rombios: work around clang's -Waddress-of-packed-member

2018-08-24 Thread Wei Liu
On Fri, Aug 24, 2018 at 10:30:37AM -0500, Doug Goldstein wrote: > On Fri, Aug 24, 2018 at 04:22:15PM +0100, Wei Liu wrote: > > Building rombios with clang XXX fails with: Oops, I have meant to replace XXX with the right version number. Will fix that while committing. > > > > tcgbios.c:1519:34:

Re: [Xen-devel] [PATCH] rombios: work around clang's -Waddress-of-packed-member

2018-08-24 Thread Wei Liu
On Fri, Aug 24, 2018 at 04:32:15PM +0100, Wei Liu wrote: > On Fri, Aug 24, 2018 at 10:30:37AM -0500, Doug Goldstein wrote: > > On Fri, Aug 24, 2018 at 04:22:15PM +0100, Wei Liu wrote: > > > Building rombios with clang XXX fails with: > > Oops, I have meant to replace XXX with the right version num

Re: [Xen-devel] [PATCH v2] automation: enable building rombios with clang

2018-08-24 Thread Wei Liu
On Fri, Aug 24, 2018 at 10:32:24AM -0500, Doug Goldstein wrote: > On Fri, Aug 24, 2018 at 04:22:47PM +0100, Wei Liu wrote: > > Previously it is disabled because the embedded ipxe can't be built > > with clang. Now that ipxe is split out we can use --with-system-ipxe > > to work around the issue. >

[Xen-devel] [seabios baseline-only test] 75114: regressions - FAIL

2018-08-24 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75114 seabios real [real] http://osstest.xensource.com/osstest/logs/75114/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-win10-i386 10 windows-installfail

Re: [Xen-devel] [Xen-users] Xen shutdown fails to release DRBD device

2018-08-24 Thread Valentin Vidic
On Wed, Aug 22, 2018 at 06:23:01PM +0200, Valentin Vidic wrote: > On Wed, Aug 22, 2018 at 05:51:54PM +0200, Roger Pau Monné wrote: > > Can you add some debug prints to check if xen_blkif_disconnect is > > indeed returning EBUSY (or some error) and that's preventing the > > device from closing corre

Re: [Xen-devel] [PATCH 16/34] x86/hvm: enclose hvm_enabled and hvm_funcs in CONFIG_HVM

2018-08-24 Thread Wei Liu
On Mon, Aug 20, 2018 at 07:04:09AM -0600, Jan Beulich wrote: > >>> On 17.08.18 at 17:12, wrote: > > This helps to take advantage of dead code elimination. Turn > > hvm_enabled into proper bool while at it. > > > > Providing an empty hvm_funcs resolves a lot of undefined references to > > it in th

Re: [Xen-devel] [PATCH 22/34] x86/mm: put HVM only code under CONFIG_HVM

2018-08-24 Thread Wei Liu
On Sun, Aug 19, 2018 at 07:27:22PM +0300, Razvan Cojocaru wrote: > On 8/17/18 6:12 PM, Wei Liu wrote: > > Going through the code, nested EPT, EPT, and ALTP2M depend on HVM code. Put > > these components under CONFIG_HVM. This further requires putting one > > of the vm event under CONFIG_HVM. > > >

Re: [Xen-devel] [PATCH 27/34] x86: make hvm_inject_* functions build when !CONFIG_HVM

2018-08-24 Thread Wei Liu
On Tue, Aug 21, 2018 at 10:37:24AM +0200, Roger Pau Monné wrote: > On Fri, Aug 17, 2018 at 04:12:45PM +0100, Wei Liu wrote: > > They reference hvm_inject_event which is HVM code (not compiled). They > > aren't used by code outside HVM code anyway. > > Can you put all the functions inside of an #if

Re: [Xen-devel] [PATCH 29/34] x86/mm: put paging_update_nestedmode under CONFIG_HVM

2018-08-24 Thread Wei Liu
On Tue, Aug 21, 2018 at 05:41:49AM -0600, Jan Beulich wrote: > >>> On 17.08.18 at 17:12, wrote: > > Nested HVM is not enabled when !CONFIG_HVM. > > All callers of the function sit under hvm/, so once again I don't see > why the function needs to remain available with an empty body. Yes the whole

Re: [Xen-devel] [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 23:52:25, Tetsuo Handa wrote: > On 2018/08/24 22:32, Michal Hocko wrote: > > On Fri 24-08-18 22:02:23, Tetsuo Handa wrote: > >> I worry that (currently > >> out-of-tree) users of this API are involving work / recursion. > > > > I do not give a slightest about out-of-tree modules. T

Re: [Xen-devel] [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-08-24 Thread Michal Hocko
On Fri 24-08-18 11:12:40, Jerome Glisse wrote: [...] > I am fine with Michal patch, i already said so couple month ago first time > this discussion did pop up, Michal you can add: > > Reviewed-by: Jérôme Glisse So I guess the below is the patch you were talking about? From f7ac75277d526dccd011f

Re: [Xen-devel] [Xen-users] Xen shutdown fails to release DRBD device

2018-08-24 Thread Valentin Vidic
On Fri, Aug 24, 2018 at 06:22:32PM +0200, Valentin Vidic wrote: > Managed to reproduce this and xen_blkif_disconnect is always returning 0 > like you expected. So this is some other issue, and from what I can tell > blkdev_put of the underlying drbd device gets called some time after > xenbus_swit

[Xen-devel] [linux-4.9 test] 126440: regressions - FAIL

2018-08-24 Thread osstest service owner
flight 126440 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/126440/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-rumprun-amd64 12 guest-startfail REGR. vs. 125183 test-amd64-amd64-xl

[Xen-devel] [PATCH 0/6] xen/arm: SMCCC fixup and improvement

2018-08-24 Thread Julien Grall
Hi all, This patch series contains fixup and improvement for the SMCCC subsystem. Patch #1 - #2 are candidates for backporting. Cheers, Julien Grall (3): xen/arm: cpufeature: Add helper to check constant caps xen/arm: smccc: Add wrapper to automatically select the calling convention x

[Xen-devel] [PATCH 5/6] xen/arm: smccc: Add wrapper to automatically select the calling convention

2018-08-24 Thread Julien Grall
Signed-off-by: Julien Grall --- xen/arch/arm/psci.c | 4 xen/include/asm-arm/cpufeature.h | 3 ++- xen/include/asm-arm/smccc.h | 8 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/psci.c b/xen/arch/arm/psci.c index 3cf5ecf0f3..941eec921b

[Xen-devel] [PATCH 2/6] xen/arm: smccc-1.1: Handle function result as parameters

2018-08-24 Thread Julien Grall
From: Marc Zyngier If someone has the silly idea to write something along those lines: extern u64 foo(void); void bar(struct arm_smccc_res *res) { arm_smccc_1_1_smc(0xbad, foo(), res); } they are in for a surprise, as this gets compiled as:

  1   2   >