Re: [Xen-devel] [PATCH v5 0/10] arm: more kconfig configurability and small default configs

2018-06-12 Thread Jan Beulich
>>> On 12.06.18 at 02:41, wrote: > On Wed, 6 Jun 2018, Jan Beulich wrote: >> >>> On 05.06.18 at 19:52, wrote: >> >> > >> > On 04/06/18 18:23, Stefano Stabellini wrote: >> >> Hi all, >> >> >> >> This patch series is the first step toward building a small certifiable >> >> Xen hypervisor for ARM

[Xen-devel] [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen

2018-06-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko This is the sync up with the canonical definitions of the input, sound and display protocols in Xen. Changes to kbdif: 1. Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file. 2. Add new XenStore feature fie

[Xen-devel] [PATCH v5 0/3] Input: xen-kbdfront - allow better run-time configuration

2018-06-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Hi, all! This patch series synchronizes Xen canonical protocol definitions which allow the last two patches in the series to update Xen kbdfront driver with a fix and v5 of the patch to allow better run-time configuration for xen-kbdfront. As xen-kbdfront patches r

[Xen-devel] [PATCH v5 2/3] Input: xen-kbdfront - fix multi-touch XenStore node's locations

2018-06-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko kbdif protocol describes multi-touch device parameters as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by reading the parameters as defined by the protocol. Fixes: 49aac8204da5 ("Input: xen-kbdfront - add mul

[Xen-devel] [PATCH v5 3/3] Input: xen-kbdfront - allow better run-time configuration

2018-06-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko It is now only possible to control if multi-touch virtual device is created or not (via the corresponding XenStore entries), but keyboard and pointer devices are always created. In some cases this is not desirable. For example, if virtual keyboard device is exposed t

Re: [Xen-devel] 4.11.0 RC1 panic

2018-06-12 Thread Jan Beulich
>>> On 10.06.18 at 12:57, wrote: > (XEN) Xen call trace: > (XEN)[] mm.c#dec_linear_entries+0x12/0x20 > (XEN)[] mm.c#_put_page_type+0x13e/0x350 > (XEN)[] _spin_lock+0xd/0x50 > (XEN)[] mm.c#put_page_from_l2e+0xdf/0x110 > (XEN)[] free_page_type+0x2f9/0x790 > (XEN)[] mm.c#_put_

Re: [Xen-devel] [PATCH v2 4/9] x86/vmx: Support remote access to the MSR lists

2018-06-12 Thread Jan Beulich
>>> On 08.06.18 at 20:48, wrote: > At the moment, all modifications of the MSR lists are in current context. > However, future changes may need to put MSR_EFER into the lists from domctl > hypercall context. > > Plumb a struct vcpu parameter down through the infrastructure, and use > vmx_vmcs_{en

Re: [Xen-devel] [PATCH v2 5/9] x86/vmx: Improvements to LBR MSR handling

2018-06-12 Thread Jan Beulich
>>> On 08.06.18 at 20:48, wrote: > @@ -3106,14 +3104,13 @@ static int vmx_msr_write_intercept(unsigned int msr, > uint64_t msr_content) > for ( ; (rc == 0) && lbr->count; lbr++ ) > for ( i = 0; (rc == 0) && (i < lbr->count); i++ ) > if ( (rc = vm

Re: [Xen-devel] [PATCH v2 6/9] x86/vmx: Pass an MSR value into vmx_msr_add()

2018-06-12 Thread Jan Beulich
>>> On 08.06.18 at 20:48, wrote: > The main purpose of this change is to allow us to set a specific MSR value, > without needing to know whether there is already a load/save list slot for it. > > Previously, callers wanting this property needed to call both vmx_add_*_msr() > and vmx_write_*_msr()

Re: [Xen-devel] [PATCH v2 8/9] x86/vmx: Support removing MSRs from the host/guest load/save lists

2018-06-12 Thread Jan Beulich
>>> On 08.06.18 at 20:48, wrote: > --- a/xen/arch/x86/hvm/vmx/vmcs.c > +++ b/xen/arch/x86/hvm/vmx/vmcs.c > @@ -1452,6 +1452,74 @@ int vmx_add_msr(struct vcpu *v, uint32_t msr, uint64_t > val, > return rc; > } > > +int vmx_del_msr(struct vcpu *v, uint32_t msr, enum vmx_msr_list_type type)

Re: [Xen-devel] [PATCH v2 5/9] x86/vmx: Improvements to LBR MSR handling

2018-06-12 Thread Andrew Cooper
On 12/06/2018 09:15, Jan Beulich wrote: On 08.06.18 at 20:48, wrote: >> @@ -3106,14 +3104,13 @@ static int vmx_msr_write_intercept(unsigned int msr, >> uint64_t msr_content) >> for ( ; (rc == 0) && lbr->count; lbr++ ) >> for ( i = 0; (rc == 0) && (i < lbr->count

Re: [Xen-devel] [PATCH v2 9/9] x86/vmx: Don't leak EFER.NXE into guest context

2018-06-12 Thread Jan Beulich
>>> On 08.06.18 at 20:48, wrote: > @@ -1646,22 +1637,71 @@ static void vmx_update_guest_cr(struct vcpu *v, > unsigned int cr, > > static void vmx_update_guest_efer(struct vcpu *v) > { > -unsigned long vm_entry_value; > +unsigned long entry_ctls, guest_efer = v->arch.hvm_vcpu.guest_efe

Re: [Xen-devel] [PATCH v2 5/9] x86/vmx: Improvements to LBR MSR handling

2018-06-12 Thread Jan Beulich
>>> On 12.06.18 at 10:51, wrote: > On 12/06/2018 09:15, Jan Beulich wrote: > On 08.06.18 at 20:48, wrote: >>> @@ -3106,14 +3104,13 @@ static int vmx_msr_write_intercept(unsigned int >>> msr, > uint64_t msr_content) >>> for ( ; (rc == 0) && lbr->count; lbr++ ) >>>

[Xen-devel] [xen-4.8-testing test] 124070: regressions - trouble: blocked/broken/fail/pass

2018-06-12 Thread osstest service owner
flight 124070 xen-4.8-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/124070/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-xsm broken build-armhf-xsm 5 host-b

[Xen-devel] [libvirt test] 124095: regressions - FAIL

2018-06-12 Thread osstest service owner
flight 124095 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/124095/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 123814 build-i386-libvirt

Re: [Xen-devel] [PATCH v5 07/10] arm: add a tiny kconfig configuration

2018-06-12 Thread Julien Grall
Hi Stefano, On 12/06/18 01:50, Stefano Stabellini wrote: On Tue, 5 Jun 2018, Julien Grall wrote: Hi Stefano, On 04/06/18 18:24, Stefano Stabellini wrote: Add a tiny kconfig configuration. Enabled NULL and Credit schedulers. Support only 8 cpus. It only carries non-default options (use make

Re: [Xen-devel] [PATCH for-4.11] scripts/add_maintainers.pl: Don't call get_maintainers.pl with -f

2018-06-12 Thread Julien Grall
On 06/06/18 11:06, Julien Grall wrote: Hi, On 05/06/18 19:26, Lars Kurth wrote: On 05/06/2018, 19:15, "Juergen Gross" wrote: On 05/06/18 18:39, Julien Grall wrote: > The option -f of scripts/get_maintainers.pl will return the maintainers > of a given file, *not* the list

[Xen-devel] [OSSTEST PATCH] seabios: Switch from git:// to https://

2018-06-12 Thread Ian Jackson
Currently git.seabios.org is down. https is better anyway. CC: Anthony PERARD Signed-off-by: Ian Jackson --- ap-common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ap-common b/ap-common index 5e7cfde..a967ac6 100644 --- a/ap-common +++ b/ap-common @@ -47,7 +47,7 @@ : ${

Re: [Xen-devel] [PATCH for-4.11] scripts/add_maintainers.pl: Don't call get_maintainers.pl with -f

2018-06-12 Thread Ian Jackson
Julien Grall writes ("Re: [PATCH for-4.11] scripts/add_maintainers.pl: Don't call get_maintainers.pl with -f"): > On 06/06/18 11:06, Julien Grall wrote: > > I will commit the patch once we branched. > > I was about to commit but I forgot that I would need a ack from someone > in "THE REST". > >

Re: [Xen-devel] [libvirt] Likely build race, "/usr/bin/ld: cannot find -lvirt"

2018-06-12 Thread Jiri Denemark
On Thu, May 24, 2018 at 15:52:55 -0600, Jim Fehlig wrote: > On 05/24/2018 04:27 AM, Ian Jackson wrote: > > Ian Jackson writes ("Likely build race, "/usr/bin/ld: cannot find -lvirt""): > >> tl;dr: > >> > >> I think there is a bug in libvirt's build system which, with > >> low probability, causes a b

Re: [Xen-devel] [PATCH v1 04/13] xen/arm: Add ARCH_WORKAROUND_2 probing

2018-06-12 Thread Julien Grall
Hi Stefano, On 12/06/18 00:14, Stefano Stabellini wrote: On Tue, 5 Jun 2018, Julien Grall wrote: As for Spectre variant-2, we rely on SMCCC 1.1 to provide the discovery mechanism for detecting the SSBD mitigation. A new capability is also allocated for that purpose, and a config option. This

Re: [Xen-devel] [PATCH for-4.11] scripts/add_maintainers.pl: Don't call get_maintainers.pl with -f

2018-06-12 Thread Jan Beulich
>>> On 12.06.18 at 12:44, wrote: > On 06/06/18 11:06, Julien Grall wrote: >> On 05/06/18 19:26, Lars Kurth wrote: >>> This change in behaviour was mistakenly introduced in one of the later >>> revisions (can't recall which), when we refactored the call to >>> get_maintainers.pl >> >> Thank you!

Re: [Xen-devel] [PATCH v1 05/13] xen/arm: Add command line option to control SSBD mitigation

2018-06-12 Thread Julien Grall
Hi Stefano, On 12/06/18 00:15, Stefano Stabellini wrote: On Tue, 5 Jun 2018, Julien Grall wrote: /* * Assembly code may use the variable directly, so we need to make sure * it fits in a register. @@ -251,19 +286,17 @@ static bool has_ssbd_mitigation(const struct arm_cpu_capabilities *e

Re: [Xen-devel] [PATCH for-4.11] scripts/add_maintainers.pl: Don't call get_maintainers.pl with -f

2018-06-12 Thread Julien Grall
On 12/06/18 12:18, Jan Beulich wrote: On 12.06.18 at 12:44, wrote: On 06/06/18 11:06, Julien Grall wrote: On 05/06/18 19:26, Lars Kurth wrote: This change in behaviour was mistakenly introduced in one of the later revisions (can't recall which), when we refactored the call to get_maintainer

[Xen-devel] [PATCH v3 09/13] xen/arm64: Add generic assembly macros

2018-06-12 Thread Julien Grall
Add assembly macros to simplify assembly code: - adr_cpu_info: Get the address to the current cpu_info structure - ldr_this_cpu: Load a per-cpu value This is part of XSA-263. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- Changes in v2: - Add Stefano's revi

[Xen-devel] [PATCH v3 13/13] xen/arm: Avoid to use current everywhere in enter_hypervisor_head

2018-06-12 Thread Julien Grall
Using current is fairly expensive, so save up into a variable. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- Changes in v2: - Add Stefano's reviewed-by --- xen/arch/arm/traps.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/xen/

[Xen-devel] [PATCH v3 01/13] xen/arm: domain: Zero the per-vCPU cpu_info

2018-06-12 Thread Julien Grall
A stack is allocated per vCPU to be used by Xen. The allocation is done with alloc_xenheap_pages that does not zero the memory returned. However the top of the stack is containing information that will be used to store the initial state of the vCPU (see struct cpu_info). Some of the fields may not

[Xen-devel] [PATCH v3 11/13] xen/arm: Kconfig: Move HARDEN_BRANCH_PREDICTOR under "Architecture features"

2018-06-12 Thread Julien Grall
At the moment, HARDEN_BRANCH_PREDICTOR is not in any section making impossible for the user to unselect it. Also, it looks like we require to use 'expert = "y"' for showing the option in expert mode. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- Changes in v2: - A

[Xen-devel] [PATCH v3 00/13] xen/arm: SSBD (aka Spectre-v4) mitigation (XSA-263)

2018-06-12 Thread Julien Grall
Hi all, This patch series implement the Xen hypervisor side of the "Spectre-v4" (CVE-2018-3639) mitigation known as "Speculative Store Bypass Disable" (SSBD). More information can be found at: https://bugs.chromium.org/p/project-zero/issues/detail?id=1528 https://developer.arm.com/support/ar

[Xen-devel] [PATCH v3 10/13] xen/arm64: Implement a fast path for handling SMCCC_ARCH_WORKAROUND_2

2018-06-12 Thread Julien Grall
The function ARM_SMCCC_ARCH_WORKAROUND_2 will be called by the guest for enabling/disabling the ssbd mitigation. So we want the handling to be as fast as possible. The new sequence will forward guest's ARCH_WORKAROUND_2 call to EL3 and also track the state of the workaround per-vCPU. Note that si

[Xen-devel] [PATCH v3 08/13] xen/arm: alternatives: Add dynamic patching feature

2018-06-12 Thread Julien Grall
This is based on the Linux commit dea5e2a4c5bc "arm64: alternatives: Add dynamic patching feature" written by Marc Zyngier: We've so far relied on a patching infrastructure that only gave us a single alternative, without any way to provide a range of potential replacement instructions.

[Xen-devel] [PATCH v3 06/13] xen/arm: Add ARCH_WORKAROUND_2 support for guests

2018-06-12 Thread Julien Grall
In order to offer ARCH_WORKAROUND_2 support to guests, we need to track the state of the workaround per-vCPU. The field 'pad' in cpu_info is now repurposed to store flags easily accessible in assembly. As the hypervisor will always run with the workaround enabled, we may need to enable (on guest e

[Xen-devel] [PATCH v3 03/13] xen/arm: setup: Check errata for boot CPU later on

2018-06-12 Thread Julien Grall
Some errata will rely on the SMCCC version which is detected by psci_init(). This is part of XSA-263. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- Changes in v2: - Add Stefano's reviewed-by --- xen/arch/arm/setup.c | 8 ++-- 1 file changed, 6 insertions(+),

[Xen-devel] [PATCH v3 04/13] xen/arm: Add ARCH_WORKAROUND_2 probing

2018-06-12 Thread Julien Grall
As for Spectre variant-2, we rely on SMCCC 1.1 to provide the discovery mechanism for detecting the SSBD mitigation. A new capability is also allocated for that purpose, and a config option. This is part of XSA-263. Signed-off-by: Julien Grall --- Changes in v3: - required should b

[Xen-devel] [PATCH v3 07/13] xen/arm: Simplify alternative patching of non-writable region

2018-06-12 Thread Julien Grall
During the MMU setup process, Xen will set SCTLR_EL2.WNX (Write-Non-eXecutable) bit. Because of that, the alternative code need to re-mapped the region in a difference place in order to modify the text section. At the moment, the function patching the code is only aware of the re-mapped region. Th

[Xen-devel] [PATCH v3 02/13] xen/arm64: entry: Use named label in guest_sync

2018-06-12 Thread Julien Grall
This will improve readability for future changes. This is part of XSA-263. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- Changes in v2: - Add Stefano's reviewed-by --- xen/arch/arm/arm64/entry.S | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[Xen-devel] [PATCH v3 05/13] xen/arm: Add command line option to control SSBD mitigation

2018-06-12 Thread Julien Grall
On a system where the firmware implements ARCH_WORKAROUND_2, it may be useful to either permanently enable or disable the workaround for cases where the user decides that they'd rather not get a trap overhead, and keep the mitigation permanently on or off instead of switching it on exception entry/

[Xen-devel] [PATCH v3 12/13] xen/arm: smccc: Fix indentation in ARM_SMCCC_ARCH_WORKAROUND_1_FID

2018-06-12 Thread Julien Grall
Signed-off-by: Julien Grall Acked-by: Stefano Stabellini --- Changes in v2: - Add Stefano's acked-by --- xen/include/asm-arm/smccc.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/include/asm-arm/smccc.h b/xen/include/asm-arm/smccc.h index a6804cec99..

[Xen-devel] [OSSTEST PATCH 10/11] TestSupport: substeps: work if steps in ad-hoc tests take >1s

2018-06-12 Thread Ian Jackson
When running by hand, OSSTEST_TESTID is not set. We provide a value with the time and the pid in it, so that rerunning the script by hand works, even though in production this would result in multiple identically-named substeps. But we need to fix this value for the duration of the script. Otherw

[Xen-devel] [OSSTEST PATCH 01/11] ts-xen-install: Drop obsolete --check and $checkmode

2018-06-12 Thread Ian Jackson
Since 5edec3222ff14b8200d5b41ed9af3c8d04c27314 ts-xen-build-check: reimplementation ... in 2011 we have a fully general version, and the --check option is no longer used. And since 467d6239daa352483ec8fef003bd4fc723702b77 pygrub: guest kernel install: move target_extract_jobdist_path into Osst

[Xen-devel] [OSSTEST PATCH 00/11] dmrestrict audit: Preparatory fixes

2018-06-12 Thread Ian Jackson
From: Ian Jackson While working on auditing dm restriction, I came up with these miscellaneous improvements, bugfixes, slightly refactorings, and minor new features. I intend to push them to osstest pretest soon to get them out of my queue. Ian Jackson (11): ts-xen-install: Drop obsolete --ch

[Xen-devel] [OSSTEST PATCH 04/11] TestSupport: Break out target_extract_distpart

2018-06-12 Thread Ian Jackson
No functional change. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 10 +- ts-xen-install | 4 +--- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm index cebeb0d..6de566c 100644 --- a/Osstest/TestSupport.p

[Xen-devel] [OSSTEST PATCH 09/11] sg-run-job: add some comments about guest state

2018-06-12 Thread Ian Jackson
Signed-off-by: Ian Jackson --- sg-run-job | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sg-run-job b/sg-run-job index e1dc2d2..0a3f688 100755 --- a/sg-run-job +++ b/sg-run-job @@ -604,11 +604,13 @@ proc test-guest-migr {g} { } proc test-guest {g} { +# guest is expected to be runni

[Xen-devel] [OSSTEST PATCH 07/11] config: ExtraDebs: replace with DebianExtraPackages

2018-06-12 Thread Ian Jackson
`ExtraDebs' is a silly name. Also the semantics are rather inflexible; we might want to install specific packages rather than the contents of a whole directory. And, document it. This variable has only just been introduced, so hopefully it is OK to replace and rename it now without causing too m

[Xen-devel] [OSSTEST PATCH 05/11] ResourceCondition: Break out PropCompareBase

2018-06-12 Thread Ian Jackson
Make a base class so we can easily invent other kinds of resource property condition. The child is responsible only for stringification and the actual comparison. These classes does not need Exporter, so drop all that. Use `use parent' to import the base class. Signed-off-by: Ian Jackson ---

[Xen-devel] [OSSTEST PATCH 06/11] ResourceCondition: Provide PropEq

2018-06-12 Thread Ian Jackson
This can be used, for example, with the following entry in a hostflags runvar: PropEq:Firmware:uefi Signed-off-by: Ian Jackson --- Osstest/ResourceCondition/PropEq.pm | 38 + 1 file changed, 38 insertions(+) create mode 100644 Osstest/ResourceCondition/Pro

[Xen-devel] [OSSTEST PATCH 11/11] TestSupport: guest_var_boolean: Understand `y' and `1' as well

2018-06-12 Thread Ian Jackson
Previously this would treat `y' and `1' as false, which is very confusing. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm index 7bc40f3..d8ed02d 100644 --- a/Osstest/TestSup

[Xen-devel] [OSSTEST PATCH 08/11] ts-xen-install: DebianExtraPackages: call apt-get -f install

2018-06-12 Thread Ian Jackson
Currently this is just a precaution. Signed-off-by: Ian Jackson --- ts-xen-install | 1 + 1 file changed, 1 insertion(+) diff --git a/ts-xen-install b/ts-xen-install index d3a9d11..9913e85 100755 --- a/ts-xen-install +++ b/ts-xen-install @@ -99,6 +99,7 @@ sub some_extradebs ($) { target

[Xen-devel] [OSSTEST PATCH 03/11] sg-run-job: Allow suppression of consequences of per-host-ts fail

2018-06-12 Thread Ian Jackson
Signed-off-by: Ian Jackson --- sg-run-job | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/sg-run-job b/sg-run-job index aa97ee6..e1dc2d2 100755 --- a/sg-run-job +++ b/sg-run-job @@ -216,7 +216,8 @@ proc testid_matches_globs {testid globs} { # where STATUS

Re: [Xen-devel] 4.11.0 RC1 panic

2018-06-12 Thread Manuel Bouyer
On Tue, Jun 12, 2018 at 01:57:35AM -0600, Jan Beulich wrote: > Let's focus on this scenario for now, as it is under better (timing) control > on the Xen side. Below is a first debugging patch which > - avoids the ASSERT() in question, instead triggering a printk(), in the hope > that the data log

[Xen-devel] [OSSTEST PATCH 02/11] cs-adjust-flight: Allow adjusting play flights after start

2018-06-12 Thread Ian Jackson
Specifically, rather than simply bombing out, if the flight already has steps, we call dbfl_check again with an empty list of OK blessings. dbfl_check will then bomb out, unless the flight's blessing or intended blessing is `play'. If it doesn't bomb out, we print a message. Signed-off-by: Ian J

[Xen-devel] [distros-debian-snapshot test] 74858: tolerable FAIL

2018-06-12 Thread Platform Team regression test user
flight 74858 distros-debian-snapshot real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/74858/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-i386-daily-netboot-pvgrub 11 guest-start fail like 74781 test-amd64-i386-i386-we

Re: [Xen-devel] [PATCH] xen/altp2m: set access_required properly for all altp2ms

2018-06-12 Thread Jan Beulich
>>> On 11.06.18 at 17:12, wrote: > --- a/xen/arch/x86/domain.c > +++ b/xen/arch/x86/domain.c > @@ -38,6 +38,7 @@ > #include > #include > #include > +#include Not the least to avoid this I think ... > @@ -719,6 +720,22 @@ int arch_domain_soft_reset(struct domain *d) > return ret; > }

Re: [Xen-devel] [PATCH] xen/altp2m: set access_required properly for all altp2ms

2018-06-12 Thread Razvan Cojocaru
Thanks for the review! On 06/12/2018 03:23 PM, Jan Beulich wrote: On 11.06.18 at 17:12, wrote: >> --- a/xen/arch/x86/domain.c >> +++ b/xen/arch/x86/domain.c >> @@ -38,6 +38,7 @@ >> #include >> #include >> #include >> +#include > > Not the least to avoid this I think ... > >> @@ -719

Re: [Xen-devel] [PATCH 1/2] VT-d: re-phrase logic in vtd_set_hwdom_mapping() for clarity

2018-06-12 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Paul Durrant > Sent: 11 June 2018 11:35 > To: Roger Pau Monne > Cc: Kevin Tian ; Stefano Stabellini > ; Wei Liu ; Andrew Cooper > ; Tim (Xen.org) ; George > Dunlap ; Julien Grall ; > Jan B

Re: [Xen-devel] [PATCH 07/11] x86/xen: Add support for Hygon's Dhyana Family 18h processor

2018-06-12 Thread puwen
> (heavily shrinking the Cc list) > > >>> On 09.06.18 at 15:23, wrote: > > This patch enables the Xen Hypervisor support to Hygon > > Family 18h CPU: > > - Add Hygon support in Xen PMU arch init codes. > > - Add Hygon support in PMU MSR read/write codes. > > - Add Hygon support in read PMC codes.

Re: [Xen-devel] [PATCH] xen/altp2m: set access_required properly for all altp2ms

2018-06-12 Thread Jan Beulich
>>> On 12.06.18 at 14:35, wrote: > On 06/12/2018 03:23 PM, Jan Beulich wrote: > On 11.06.18 at 17:12, wrote: >>> --- a/xen/common/domctl.c >>> +++ b/xen/common/domctl.c >>> @@ -1094,6 +1094,8 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) >>> u_domctl) >>> domain_pause(d

Re: [Xen-devel] [libvirt] Likely build race, "/usr/bin/ld: cannot find -lvirt"

2018-06-12 Thread Eric Blake
On 06/12/2018 06:11 AM, Jiri Denemark wrote: I hit the same race twice on aarch64 and ppc64 and I can confirm the installation phase fails if libvirt.la is installed later than libraries which link to it. However, the dependencies seem to be set correctly in the Makefiles. But it looks like they

[Xen-devel] [linux-4.9 test] 124084: regressions - FAIL

2018-06-12 Thread osstest service owner
flight 124084 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/124084/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-amd64 7 xen-bootfail REGR. vs. 122969 test-amd64-amd64-xl-s

[Xen-devel] [ovmf test] 124091: regressions - FAIL

2018-06-12 Thread osstest service owner
flight 124091 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/124091/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 124058 version targeted for testi

[Xen-devel] [PATCH v2 2/6] libxl: add backend type and id to vkb

2018-06-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov New field backend_type is added to vkb device in order to have QEMU and user space backend simultaneously. Each vkb backend shall read appropriate XS entry and service only own frontends. Id is a string field which used by the backend to indentify the frontend. Signed-off

[Xen-devel] [PATCH v2 1/6] libxl: move vkb device to libxl_vkb.c

2018-06-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Logically it is better to move vkb to separate file as vkb device used not only by vfb and console. Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- tools/libxl/Makefile| 2 +- tools/libxl/libxl_console.c | 53 - tools/lib

[Xen-devel] [PATCH v2 5/6] docs: add vkb device to xl.cfg and xl

2018-06-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- docs/man/xl.cfg.pod.5.in | 24 docs/man/xl.pod.1.in | 22 ++ 2 files changed, 46 insertions(+) diff --git a/docs/man/xl.cfg.pod.5.in b/docs/man/xl.cfg.pod.5.in index

[Xen-devel] [PATCH v2 3/6] libxl: vkb add list and info functions

2018-06-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- tools/libxl/libxl.h | 10 +++ tools/libxl/libxl_types.idl | 11 tools/libxl/libxl_utils.h | 3 + tools/libxl/libxl_vkb.c | 127 +++- 4 files changed, 149 insert

[Xen-devel] [PATCH v2 0/6] libxl: create standalone vkb device

2018-06-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Changes since initial: * id field is changed to unique_id in libxl_device_vkb to be comply with protocol; * use XENKBD_FIELD_... defines from protocol to address xen store entries and fields in domain config file; * add support of new protocol parameters: - XE

[Xen-devel] [PATCH v2 4/6] xl: add vkb config parser and CLI

2018-06-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- tools/xl/Makefile | 2 +- tools/xl/xl.h | 3 + tools/xl/xl_cmdtable.c | 16 + tools/xl/xl_parse.c| 76 - tools/xl/xl_parse.h| 2 +- tools/xl/xl_vkb.c | 147

[Xen-devel] [PATCH v2 6/6] libxl: vkb add extended parameters

2018-06-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add parsing and adding to xen store following extended parameters: * feature-disable-keyboard * feature-disable-pointer * feature-abs-pointer * feature-multi-touch * feature-raw-pointer * width * height * multi-touch-width * multi-touch-height * multi-touch-num-contacts S

[Xen-devel] [PATCH v3 7/9] xen/gntdev: Add initial support for dma-buf UAPI

2018-06-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Add UAPI and IOCTLs for dma-buf grant device driver extension: the extension allows userspace processes and kernel modules to use Xen backed dma-buf implementation. With this extension grant references to the pages of an imported dma-buf can be exported for other dom

[Xen-devel] [PATCH v3 3/9] xen/balloon: Share common memory reservation routines

2018-06-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Memory {increase|decrease}_reservation and VA mappings update/reset code used in balloon driver can be made common, so other drivers can also re-use the same functionality without open-coding. Create a dedicated file for the shared code and export corresponding symbo

[Xen-devel] [PATCH v3 1/9] xen/grant-table: Export gnttab_{alloc|free}_pages as GPL

2018-06-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Only gnttab_{alloc|free}_pages are exported as EXPORT_SYMBOL while all the rest are exported as EXPORT_SYMBOL_GPL, thus effectively making it not possible for non-GPL driver modules to use grant table module. Export gnttab_{alloc|free}_pages as EXPORT_SYMBOL_GPL so a

[Xen-devel] [PATCH v3 8/9] xen/gntdev: Implement dma-buf export functionality

2018-06-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko 1. Create a dma-buf from grant references provided by the foreign domain. By default dma-buf is backed by system memory pages, but by providing GNTDEV_DMA_FLAG_XXX flags it can also be created as a DMA write-combine/coherent buffer, e.g. allocated with co

[Xen-devel] [PATCH v3 0/9] xen: dma-buf support for grant device

2018-06-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko This work is in response to my previous attempt to introduce Xen/DRM zero-copy driver [1] to enable Linux dma-buf API [2] for Xen based frontends/backends. There is also an existing hyper_dmabuf approach available [3] which, if reworked to utilize the proposed soluti

[Xen-devel] [PATCH v3 6/9] xen/gntdev: Make private routines/structures accessible

2018-06-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko This is in preparation for adding support of DMA buffer functionality: make map/unmap related code and structures, used privately by gntdev, ready for dma-buf extension, which will re-use these. Rename corresponding structures as those become non-private to gntdev no

[Xen-devel] [PATCH v3 5/9] xen/gntdev: Allow mappings for DMA buffers

2018-06-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Allow mappings for DMA backed buffers if grant table module supports such: this extends grant device to not only map buffers made of balloon pages, but also from buffers allocated with dma_alloc_xxx. Signed-off-by: Oleksandr Andrushchenko --- drivers/xen/gntdev.c

[Xen-devel] [PATCH v3 9/9] xen/gntdev: Implement dma-buf import functionality

2018-06-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko 1. Import a dma-buf with the file descriptor provided and export granted references to the pages of that dma-buf into the array of grant references. 2. Add API to close all references to an imported buffer, so it can be released by the owner. This is only v

[Xen-devel] [PATCH v3 4/9] xen/grant-table: Allow allocating buffers suitable for DMA

2018-06-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Extend grant table module API to allow allocating buffers that can be used for DMA operations and mapping foreign grant references on top of those. The resulting buffer is similar to the one allocated by the balloon driver in terms that proper memory reservation is m

[Xen-devel] [PATCH v3 2/9] xen/grant-table: Make set/clear page private code shared

2018-06-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Make set/clear page private code shared and accessible to other kernel modules which can re-use these instead of open-coding. Signed-off-by: Oleksandr Andrushchenko Reviewed-by: Boris Ostrovsky --- drivers/xen/grant-table.c | 54 +-

Re: [Xen-devel] [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen

2018-06-12 Thread Juergen Gross
On 12/06/18 09:48, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > This is the sync up with the canonical definitions of the input, > sound and display protocols in Xen. > > Changes to kbdif: > 1. Add missing string constants for {feature|request}-raw-pointer >to align wit

Re: [Xen-devel] [PATCH v5 2/3] Input: xen-kbdfront - fix multi-touch XenStore node's locations

2018-06-12 Thread Juergen Gross
On 12/06/18 09:48, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > kbdif protocol describes multi-touch device parameters as a > part of frontend's XenBus configuration nodes while they > belong to backend's configuration. Fix this by reading the > parameters as defined by the

[Xen-devel] [PATCH v2 2/2] VT-d: reconcile iommu_inclusive_mapping and iommu=dom0-strict

2018-06-12 Thread Paul Durrant
The documentation for the iommu_inclusive_mapping Xen command line option states: "Use this to work around firmware issues providing incorrect RMRR entries" Unfortunately this workaround does not function correctly if the dom0-strict iommu option is also specified. The documentation goes on to s

[Xen-devel] [PATCH v2 1/2] VT-d: re-phrase logic in vtd_set_hwdom_mapping() for clarity

2018-06-12 Thread Paul Durrant
It is hard to reconcile the comment at the top of the loop in vtd_set_hwdom_mapping() with the if statement following it. This patch re-phrases the logic, preserving the semantics, but making it easier to read. The patch also modifies the Xen command line documentation to make it clear that iommu_

[Xen-devel] [PATCH v2 0/2] VT-d: make dom0-strict work with buggy firmware

2018-06-12 Thread Paul Durrant
When dom0-strict mode is enabled the iommu_inclusive_mapping workaround for firmware with undeclared RMRRs is rendered useless. This series fixes the problem. Paul Durrant (2): VT-d: re-phrase logic in vtd_set_hwdom_mapping() for clarity VT-d: reconcile iommu_inclusive_mapping and iommu=dom0-s

Re: [Xen-devel] [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen

2018-06-12 Thread Oleksandr Andrushchenko
On 06/12/2018 04:46 PM, Juergen Gross wrote: On 12/06/18 09:48, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko This is the sync up with the canonical definitions of the input, sound and display protocols in Xen. Changes to kbdif: 1. Add missing string constants for {feature|requ

Re: [Xen-devel] [PATCH v5 3/3] Input: xen-kbdfront - allow better run-time configuration

2018-06-12 Thread Juergen Gross
On 12/06/18 09:48, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > It is now only possible to control if multi-touch virtual device > is created or not (via the corresponding XenStore entries), > but keyboard and pointer devices are always created. > In some cases this is not d

[Xen-devel] [PATCH v1] unmodified_drivers: unplug the emulated devices at resume time

2018-06-12 Thread Olaf Hering
Since qemu-2.10 it is required to unplug emulated devices again after a live migration. If this is not done, qemu's block-backend driver will be unable to open the backing disk image because it is still busy by qemu's IDE driver. As a result the domUs block-frontend driver will be unable to access

Re: [Xen-devel] [libvirt] Likely build race, "/usr/bin/ld: cannot find -lvirt"

2018-06-12 Thread Jiri Denemark
On Tue, Jun 12, 2018 at 07:57:40 -0500, Eric Blake wrote: > On 06/12/2018 06:11 AM, Jiri Denemark wrote: > > > I hit the same race twice on aarch64 and ppc64 and I can confirm the > > installation phase fails if libvirt.la is installed later than libraries > > which link to it. However, the depend

[Xen-devel] [xen-unstable-smoke test] 124108: tolerable all pass - PUSHED

2018-06-12 Thread osstest service owner
flight 124108 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/124108/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [libvirt] Likely build race, "/usr/bin/ld: cannot find -lvirt"

2018-06-12 Thread Daniel P . Berrangé
On Tue, Jun 12, 2018 at 04:16:53PM +0200, Jiri Denemark wrote: > On Tue, Jun 12, 2018 at 07:57:40 -0500, Eric Blake wrote: > > On 06/12/2018 06:11 AM, Jiri Denemark wrote: > > > > > I hit the same race twice on aarch64 and ppc64 and I can confirm the > > > installation phase fails if libvirt.la is

Re: [Xen-devel] [PATCH v1] unmodified_drivers: unplug the emulated devices at resume time

2018-06-12 Thread Jan Beulich
>>> On 12.06.18 at 16:10, wrote: > Since qemu-2.10 it is required to unplug emulated devices again after > a live migration. If this is not done, qemu's block-backend driver > will be unable to open the backing disk image because it is still busy > by qemu's IDE driver. As a result the domUs block

Re: [Xen-devel] [PATCH v1] unmodified_drivers: unplug the emulated devices at resume time

2018-06-12 Thread Olaf Hering
Am Tue, 12 Jun 2018 09:01:07 -0600 schrieb "Jan Beulich" : > So there's no plan to fix this on the qemu side? Even if there would be one, existing dom0s may not get an update in time. I sent some prototype of a potential fix for qemu, it needs more work. Olaf pgpzDYSfvvGmr.pgp Description: D

Re: [Xen-devel] [PATCH] xen/altp2m: set access_required properly for all altp2ms

2018-06-12 Thread Razvan Cojocaru
On 06/12/2018 03:35 PM, Razvan Cojocaru wrote: >>> @@ -210,7 +211,7 @@ static int p2m_init_altp2m(struct domain *d) >>> return -ENOMEM; >>> } >>> p2m->p2m_class = p2m_alternate; >>> -p2m->access_required = 1; >>> +p2m->access_required = hostp2m->access

Re: [Xen-devel] 4.11.0 RC1 panic

2018-06-12 Thread Manuel Bouyer
On Tue, Jun 12, 2018 at 01:39:05PM +0200, Manuel Bouyer wrote: > I applied this patch to 4.11rc4 (let's not change too much things at the > same time) and rebooted my test host. Hopefully I'll have some data to report > soon Got the first panic (still from a i386 domU): login: (XEN) d4v0 Hit #DB i

[Xen-devel] [PATCH 0/1] libxl/xl: rename id to unique-id in vdispl xen store

2018-06-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov As new version of the display protocol introduces unique-id variable, it needs to be changed in libxl/xl. This patchset renames it in the xen store and in display device structures. Also it uses XENDISPL_FIELD_... defines instead of inline names. Oleksandr Grytsov (1):

[Xen-devel] [PATCH 1/1] libxl/xl: rename id to unique-id in vdispl xen store

2018-06-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov In the display protocol connector's id is named as unique-id. This patch renames it in the libxl/xl code and uses XENDISPL_FIELD... definitions from the protocol header. Signed-off-by: Oleksandr Grytsov --- docs/man/xl.cfg.pod.5.in| 2 +- tools/libxl/libxl_types.id

Re: [Xen-devel] 4.11.0 RC1 panic

2018-06-12 Thread Andrew Cooper
On 12/06/18 16:38, Manuel Bouyer wrote: > On Tue, Jun 12, 2018 at 01:39:05PM +0200, Manuel Bouyer wrote: >> I applied this patch to 4.11rc4 (let's not change too much things at the >> same time) and rebooted my test host. Hopefully I'll have some data to report >> soon > Got the first panic (still

Re: [Xen-devel] [PATCH v5 07/10] arm: add a tiny kconfig configuration

2018-06-12 Thread Stefano Stabellini
On Tue, 12 Jun 2018, Julien Grall wrote: > Hi Stefano, > > On 12/06/18 01:50, Stefano Stabellini wrote: > > On Tue, 5 Jun 2018, Julien Grall wrote: > > > Hi Stefano, > > > > > > On 04/06/18 18:24, Stefano Stabellini wrote: > > > > Add a tiny kconfig configuration. Enabled NULL and Credit schedule

[Xen-devel] [xen-unstable test] 123379: regressions - FAIL

2018-06-12 Thread Juergen Gross
On 08/06/18 12:12, Juergen Gross wrote: > On 07/06/18 13:30, Juergen Gross wrote: >> On 06/06/18 11:40, Juergen Gross wrote: >>> On 06/06/18 11:35, Jan Beulich wrote: >>> On 05.06.18 at 18:19, wrote: >>> test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 14 >>> guest-saverestore.2 >>

Re: [Xen-devel] 4.11.0 RC1 panic

2018-06-12 Thread Manuel Bouyer
On Tue, Jun 12, 2018 at 04:54:30PM +0100, Andrew Cooper wrote: > On 12/06/18 16:38, Manuel Bouyer wrote: > > On Tue, Jun 12, 2018 at 01:39:05PM +0200, Manuel Bouyer wrote: > >> I applied this patch to 4.11rc4 (let's not change too much things at the > >> same time) and rebooted my test host. Hopefu

Re: [Xen-devel] [PATCH v5 07/10] arm: add a tiny kconfig configuration

2018-06-12 Thread Julien Grall
Hi, On 12/06/18 16:55, Stefano Stabellini wrote: On Tue, 12 Jun 2018, Julien Grall wrote: Hi Stefano, On 12/06/18 01:50, Stefano Stabellini wrote: On Tue, 5 Jun 2018, Julien Grall wrote: Hi Stefano, On 04/06/18 18:24, Stefano Stabellini wrote: Add a tiny kconfig configuration. Enabled NULL

Re: [Xen-devel] [PATCH v3 04/13] xen/arm: Add ARCH_WORKAROUND_2 probing

2018-06-12 Thread Stefano Stabellini
On Tue, 12 Jun 2018, Julien Grall wrote: > As for Spectre variant-2, we rely on SMCCC 1.1 to provide the discovery > mechanism for detecting the SSBD mitigation. > > A new capability is also allocated for that purpose, and a config > option. > > This is part of XSA-263. > > Signed-off-by: Julien

  1   2   >