Re: [Xen-devel] Excited for Xen Project in Outreachy

2018-02-22 Thread KANIKA SAINI
*Issue suggested by Simon* In Unikraft - whenever compiler flags are changed due to an addition of a library or something else according to the build rules, the make command doesn't force recompilation of those files affected by the flag change unless the files are altered too. The only way out is

[Xen-devel] [PATCH] README: require Python 2.6 or newer

2018-02-22 Thread Doug Goldstein
Increase the minimum required Python to 2.6 or newer. Signed-off-by: Doug Goldstein --- CC: Andrew Cooper CC: George Dunlap CC: Ian Jackson CC: Jan Beulich CC: Konrad Rzeszutek Wilk CC: Stefano Stabellini CC: Tim Deegan CC: Wei Liu --- Python 2.6 shipped Oct 1st 2008. It was included as t

Re: [Xen-devel] AD bits in traditional PV mode

2018-02-22 Thread Andres Lagar Cavilla
Thanks for the clarification, Andrew. On Tue, Feb 20, 2018 at 5:20 PM, Andrew Cooper wrote: > On 21/02/2018 00:42, Andres Lagar Cavilla wrote: > > Hello everyone, > > > > I was thinking of the traditional Xen PV mode in which page table > > pages are write protected from guest meddling and PTE >

Re: [Xen-devel] pvh+vcpus startup issue

2018-02-22 Thread xen
On 22/02/18 6:35 PM, Juergen Gross wrote: On 22/02/18 05:37, x...@randomwebstuff.com wrote: Hi.  I have a domU.  Its params file has: vcpus = 8.  It will start with pv, but not type="pvh".  It will not start (on pvh) with vcpus = 7 or 6 or 5.  It does start with vcpus = 4. I diffed the xl -v c

Re: [Xen-devel] [PATCH v2] hvm/svm: Implement CPUID events

2018-02-22 Thread Boris Ostrovsky
On 02/21/2018 05:18 AM, Alexandru Isaila wrote: > At this moment the CPUID events for the AMD architecture are not > forwarded to the monitor layer. > > This patch adds the CPUID event to the common capabilities and then > forwards the event to the monitor layer. > > --- > Changes since V1: >

Re: [Xen-devel] [PATCH] x86/HVM: don't give the wrong impression of WRMSR succeeding

2018-02-22 Thread Boris Ostrovsky
On 02/22/2018 10:44 AM, Jan Beulich wrote: On 22.02.18 at 15:53, wrote: >> On 22/02/18 13:44, Jan Beulich wrote: >>> ... for unknown MSRs: wrmsr_hypervisor_regs()'s comment clearly says >>> that the function returns 0 for unrecognized MSRs, so >>> {svm,vmx}_msr_write_intercept() should not co

Re: [Xen-devel] [PATCH 1/9] drm/xen-front: Introduce Xen para-virtualized frontend driver

2018-02-22 Thread Boris Ostrovsky
On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: > +static struct xenbus_driver xen_driver = { > + .ids = xen_drv_ids, > + .probe = xen_drv_probe, > + .remove = xen_drv_remove, > + .otherend_changed = backend_on_changed, What does "_on_" stand for? -boris __

Re: [Xen-devel] [PATCH 3/9] drm/xen-front: Read driver configuration from Xen store

2018-02-22 Thread Boris Ostrovsky
On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: > + > +static int cfg_connector(struct xen_drm_front_info *front_info, > + struct xen_drm_front_cfg_connector *connector, > + const char *path, int index) > +{ > + char *connector_path; > + > + connector_path = d

Re: [Xen-devel] [PATCH 4/9] drm/xen-front: Implement Xen event channel handling

2018-02-22 Thread Boris Ostrovsky
On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: > + > +static irqreturn_t evtchnl_interrupt_ctrl(int irq, void *dev_id) > +{ > + struct xen_drm_front_evtchnl *evtchnl = dev_id; > + struct xen_drm_front_info *front_info = evtchnl->front_info; > + struct xendispl_resp *resp; > +

[Xen-devel] [PATCH] fuzz/x86_emulate: fix bounds for input size

2018-02-22 Thread Paul Semel
The minimum size for the input size was set to DATA_OFFSET + 1 which was meaning that we were requesting at least one character of the data array to be filled. This is not needed for the fuzzer to get working correctly. The maximum size for the input size was set to INPUT_SIZE, which is actually t

Re: [Xen-devel] [PATCH 5/9] drm/xen-front: Implement handling of shared display buffers

2018-02-22 Thread Boris Ostrovsky
On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: > > static int __init xen_drv_init(void) > { > + /* At the moment we only support case with XEN_PAGE_SIZE == PAGE_SIZE */ > + BUILD_BUG_ON(XEN_PAGE_SIZE != PAGE_SIZE); Why BUILD_BUG_ON? This should simply not load if page sizes ar

[Xen-devel] [linux-linus test] 119819: regressions - trouble: blocked/broken/fail/pass

2018-02-22 Thread osstest service owner
flight 119819 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/119819/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-xsm broken test-amd64-i386-libvirt 7 xen-boot

Re: [Xen-devel] [PATCH v2] VT-d: use two 32-bit writes to update DMAR fault address registers

2018-02-22 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Thursday, February 22, 2018 5:50 PM > > >>> On 22.02.18 at 10:44, wrote: > > On Wed, Oct 11, 2017 at 05:27:05AM -0600, Jan Beulich wrote: > >> >>> On 11.10.17 at 05:03, wrote: > >> > --- a/xen/drivers/passthrough/vtd/iommu.c > >> > +++ b/xen

[Xen-devel] [xen-4.9-testing test] 119839: tolerable FAIL - PUSHED

2018-02-22 Thread osstest service owner
flight 119839 xen-4.9-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/119839/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds16 guest-start/debian.repeat fail REGR. vs. 118683 test-amd64-i386-xl-qemuu

Re: [Xen-devel] [PATCH V5] x86/hvm: fix domain crash when CR3 has the noflush bit set

2018-02-22 Thread Tian, Kevin
> From: Razvan Cojocaru [mailto:rcojoc...@bitdefender.com] > Sent: Friday, February 16, 2018 6:22 PM > > The emulation layers of Xen lack PCID support, and as we only offer > PCID to HAP guests, all writes to CR3 are handled by hardware, > except when introspection is involved. Consequently, tryin

Re: [Xen-devel] [PATCH v3 2/2] vmx/hap: optimize CR4 trapping

2018-02-22 Thread Tian, Kevin
> From: Roger Pau Monne [mailto:roger@citrix.com] > Sent: Tuesday, February 20, 2018 4:57 PM > > There a bunch of bits in CR4 that should be allowed to be set directly > by the guest without requiring Xen intervention, currently this is > already done by passing through guest writes into the C

Re: [Xen-devel] [PATCH v3 1/2] x86/hvm: introduce cr{0, 4}_host_mask to store trapped bits of CR accesses

2018-02-22 Thread Tian, Kevin
> From: Roger Pau Monne [mailto:roger@citrix.com] > Sent: Tuesday, February 20, 2018 4:57 PM > > At the moment this is currently set at VMC{S/B} creation and not changed, > but further patches are going to change the CR4 mask at runtime. > > Signed-off-by: Roger Pau Monné Reviewed-by: Kevin

Re: [Xen-devel] [PATCH v4 10/16] xen/mm: Switch map_pages_to_xen to use MFN typesafe

2018-02-22 Thread Tian, Kevin
> From: Julien Grall [mailto:julien.gr...@arm.com] > Sent: Wednesday, February 21, 2018 10:03 PM > > The current prototype is slightly confusing because it takes a virtual > address and a physical frame (not address!). Switching to MFN will improve > safety and reduce the chance to mistakenly inve

Re: [Xen-devel] [PATCH v4 16/16] xen: Convert page_to_mfn and mfn_to_page to use typesafe MFN

2018-02-22 Thread Tian, Kevin
> From: Julien Grall [mailto:julien.gr...@arm.com] > Sent: Wednesday, February 21, 2018 10:03 PM > > Most of the users of page_to_mfn and mfn_to_page are either overriding > the macros to make them work with mfn_t or use mfn_x/_mfn because the > rest of the function use mfn_t. > > So make page_to

Re: [Xen-devel] [PATCH RFC 00/10] x86 passthrough code cleanup

2018-02-22 Thread Tian, Kevin
> From: Wei Liu > Sent: Thursday, February 22, 2018 5:47 AM > > Hi all > > At some point I would like to make CONFIG_HVM and CONFIG_PV work. > The > passthrough code is one of the road blocks for that work. Can you elaborate the motivation of this change? why does someone want to disable HVM or

Re: [Xen-devel] [PATCH 5/7] public / x86: introduce __HYPERCALL_iommu_op

2018-02-22 Thread Tian, Kevin
> From: Paul Durrant [mailto:paul.durr...@citrix.com] > Sent: Tuesday, February 13, 2018 5:23 PM > > > -Original Message- > > From: Tian, Kevin [mailto:kevin.t...@intel.com] > > Sent: 13 February 2018 06:43 > > To: Paul Durrant ; xen- > de...@lists.xenproject.org > > Cc: Stefano Stabellini

Re: [Xen-devel] [PATCH 6/7] x86: add iommu_op to query reserved ranges

2018-02-22 Thread Tian, Kevin
> From: Paul Durrant [mailto:paul.durr...@citrix.com] > Sent: Tuesday, February 13, 2018 5:25 PM > > > -Original Message- > > From: Tian, Kevin [mailto:kevin.t...@intel.com] > > Sent: 13 February 2018 06:52 > > To: Paul Durrant ; xen- > de...@lists.xenproject.org > > Cc: Stefano Stabellini

Re: [Xen-devel] [PATCH v4 16/28] x86/vvtd: Add queued invalidation (QI) support

2018-02-22 Thread Chao Gao
On Mon, Feb 12, 2018 at 02:36:10PM +, Roger Pau Monné wrote: >On Fri, Nov 17, 2017 at 02:22:23PM +0800, Chao Gao wrote: >> Queued Invalidation Interface is an expanded invalidation interface with >> extended capabilities. Hardware implementations report support for queued >> invalidation interf

Re: [Xen-devel] [PATCH 7/7] x86: add iommu_ops to map and unmap pages, and also to flush the IOTLB

2018-02-22 Thread Tian, Kevin
> From: Paul Durrant [mailto:paul.durr...@citrix.com] > Sent: Tuesday, February 13, 2018 5:56 PM > > > -Original Message- > > From: Tian, Kevin [mailto:kevin.t...@intel.com] > > Sent: 13 February 2018 06:56 > > To: Paul Durrant ; xen- > de...@lists.xenproject.org > > Cc: Stefano Stabellini

Re: [Xen-devel] [PATCH v4 17/28] x86/vvtd: save and restore emulated VT-d

2018-02-22 Thread Chao Gao
On Mon, Feb 12, 2018 at 02:49:12PM +, Roger Pau Monné wrote: >On Fri, Nov 17, 2017 at 02:22:24PM +0800, Chao Gao wrote: >> Provide a save-restore pair to save/restore registers and non-register >> status. >> >> Signed-off-by: Chao Gao >> Signed-off-by: Lan Tianyu >> --- >> v3: >> - use one

Re: [Xen-devel] [PATCH 1/9] drm/xen-front: Introduce Xen para-virtualized frontend driver

2018-02-22 Thread Oleksandr Andrushchenko
On 02/23/2018 12:23 AM, Boris Ostrovsky wrote: On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: +static struct xenbus_driver xen_driver = { + .ids = xen_drv_ids, + .probe = xen_drv_probe, + .remove = xen_drv_remove, + .otherend_changed = backend_on_changed, What do

[Xen-devel] [libvirt test] 119874: tolerable all pass - PUSHED

2018-02-22 Thread osstest service owner
flight 119874 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/119874/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-xsm 14 saverestore-support-checkfail like 119792 test-armhf-armhf-libvirt-raw 13 saveresto

Re: [Xen-devel] [PATCH 3/9] drm/xen-front: Read driver configuration from Xen store

2018-02-22 Thread Oleksandr Andrushchenko
On 02/23/2018 01:20 AM, Boris Ostrovsky wrote: On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: + +static int cfg_connector(struct xen_drm_front_info *front_info, + struct xen_drm_front_cfg_connector *connector, + const char *path, int index) +{ + char *co

Re: [Xen-devel] [PATCH 4/9] drm/xen-front: Implement Xen event channel handling

2018-02-22 Thread Oleksandr Andrushchenko
On 02/23/2018 01:50 AM, Boris Ostrovsky wrote: On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: + +static irqreturn_t evtchnl_interrupt_ctrl(int irq, void *dev_id) +{ + struct xen_drm_front_evtchnl *evtchnl = dev_id; + struct xen_drm_front_info *front_info = evtchnl->front_info

Re: [Xen-devel] [PATCH V5] x86/hvm: fix domain crash when CR3 has the noflush bit set

2018-02-22 Thread Razvan Cojocaru
On 02/23/2018 06:53 AM, Tian, Kevin wrote: >> From: Razvan Cojocaru [mailto:rcojoc...@bitdefender.com] >> Sent: Friday, February 16, 2018 6:22 PM >> >> The emulation layers of Xen lack PCID support, and as we only offer >> PCID to HAP guests, all writes to CR3 are handled by hardware, >> except whe

Re: [Xen-devel] [PATCH V5] x86/hvm: fix domain crash when CR3 has the noflush bit set

2018-02-22 Thread Razvan Cojocaru
On 02/23/2018 09:29 AM, Razvan Cojocaru wrote: > Lacking PCID support in the emulation layer creates two different way of > handling the NOFLUSH being set: one is in hardware, and this happens for > everything except the introspection case, and one in the emulation layer > (this happens when an int

Re: [Xen-devel] [PATCH 5/9] drm/xen-front: Implement handling of shared display buffers

2018-02-22 Thread Oleksandr Andrushchenko
On 02/23/2018 02:25 AM, Boris Ostrovsky wrote: On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: static int __init xen_drv_init(void) { + /* At the moment we only support case with XEN_PAGE_SIZE == PAGE_SIZE */ + BUILD_BUG_ON(XEN_PAGE_SIZE != PAGE_SIZE); Why BUILD_BUG_O

Re: [Xen-devel] [PATCH] x86/HVM: don't give the wrong impression of WRMSR succeeding

2018-02-22 Thread Jan Beulich
>>> On 22.02.18 at 23:16, wrote: > On 02/22/2018 10:44 AM, Jan Beulich wrote: > On 22.02.18 at 15:53, wrote: >>> On 22/02/18 13:44, Jan Beulich wrote: ... for unknown MSRs: wrmsr_hypervisor_regs()'s comment clearly says that the function returns 0 for unrecognized MSRs, so {svm

<    1   2