Re: [PATCH v7 03/13] tools: fix help info for "xenpm set-cpufreq-cppc"

2025-08-25 Thread Jan Beulich
On 22.08.2025 12:52, Penny Zheng wrote: > Change "balance" to "ondemand" in help info for "xenpm set-cpufreq-cppc" > > Fixes: 81ce87fc5e36 (xen/cpufreq: rename cppc preset name to > "XEN_SYSCTL_CPPC_SET_PRESET_ONDEMAND") > Signed-off-by: Penny Zheng Acked-by: Jan Beulich

[PATCH v7 03/13] tools: fix help info for "xenpm set-cpufreq-cppc"

2025-08-22 Thread Penny Zheng
Change "balance" to "ondemand" in help info for "xenpm set-cpufreq-cppc" Fixes: 81ce87fc5e36 (xen/cpufreq: rename cppc preset name to "XEN_SYSCTL_CPPC_SET_PRESET_ONDEMAND") Signed-off-by: Penny Zheng --- v6 -> v7: - new commit --- tools/misc/xenpm.

Re: [PATCH] xen/Kconfig: Improve help test for speculative options

2025-05-12 Thread Demi Marie Obenour
On 5/12/25 10:58 AM, Andrew Cooper wrote: > On 12/05/2025 11:58 am, Jan Beulich wrote: >> On 08.05.2025 18:03, Andrew Cooper wrote: >>> The text for CONFIG_INDIRECT_THUNK isn't really correct, and was already >>> stale >>> by the time speculative vulnerabilities hit the headlines in 2018. It is >

Re: [PATCH] xen/Kconfig: Improve help test for speculative options

2025-05-12 Thread Jan Beulich
On 12.05.2025 16:58, Andrew Cooper wrote: > On 12/05/2025 11:58 am, Jan Beulich wrote: >> On 08.05.2025 18:03, Andrew Cooper wrote: >>> The text for CONFIG_INDIRECT_THUNK isn't really correct, and was already >>> stale >>> by the time speculative vulnerabilities hit the headlines in 2018. It is >

Re: [PATCH] xen/Kconfig: Improve help test for speculative options

2025-05-12 Thread Andrew Cooper
On 12/05/2025 11:58 am, Jan Beulich wrote: > On 08.05.2025 18:03, Andrew Cooper wrote: >> The text for CONFIG_INDIRECT_THUNK isn't really correct, and was already >> stale >> by the time speculative vulnerabilities hit the headlines in 2018. It is >> specifically an out-of-line-ing mechansim, and

Re: [PATCH] xen/Kconfig: Improve help test for speculative options

2025-05-12 Thread Jan Beulich
On 08.05.2025 18:03, Andrew Cooper wrote: > The text for CONFIG_INDIRECT_THUNK isn't really correct, and was already stale > by the time speculative vulnerabilities hit the headlines in 2018. It is > specifically an out-of-line-ing mechansim, and repoline is one of several > safety sequences used.

Re: [PATCH] xen/Kconfig: Improve help test for speculative options

2025-05-09 Thread Andrew Cooper
> @@ -162,29 +162,21 @@ config STATIC_MEMORY >> menu "Speculative hardening" >> >> config INDIRECT_THUNK >> -bool "Speculative Branch Target Injection Protection" >> +bool "Out-of-line Indirect Call/Jumps" >> depends

Re: [PATCH] xen/Kconfig: Improve help test for speculative options

2025-05-09 Thread Roger Pau Monné
fig > +++ b/xen/common/Kconfig > @@ -162,29 +162,21 @@ config STATIC_MEMORY > menu "Speculative hardening" > > config INDIRECT_THUNK > - bool "Speculative Branch Target Injection Protection" > + bool "Out-of-line Indirect Call/Jumps" &g

[PATCH] xen/Kconfig: Improve help test for speculative options

2025-05-08 Thread Andrew Cooper
quot;Speculative Branch Target Injection Protection" + bool "Out-of-line Indirect Call/Jumps" depends on CC_HAS_INDIRECT_THUNK default y help - Contemporary processors may use speculative execution as a - performance optimisation, but this can pote

Re: Help With Identifying CPUID faulting logic in Xen code

2025-01-03 Thread Fonyuy-Asheri Caleb
Thank you Caleb - Original Message - > From: "Andrew Cooper" > To: "Fonyuy-Asheri Caleb" , "xen-devel" > > Cc: "Jan Beulich" > Sent: Friday, January 3, 2025 3:35:43 PM > Subject: Re: Help With Identifying CPUID faulting logic

Re: Help With Identifying CPUID faulting logic in Xen code

2025-01-03 Thread Andrew Cooper
On 03/01/2025 2:25 pm, Fonyuy-Asheri Caleb wrote: > Hello, > > I am interested in finding understanding how xen handles CPUID > faulting and  > VM exits in general. Please can someone indicate to me the concerned > files?  > > I want to know how xen detects the execution of the CPUID instruction an

Help With Identifying CPUID faulting logic in Xen code

2025-01-03 Thread Fonyuy-Asheri Caleb
Hello, I am interested in finding understanding how xen handles CPUID faulting and VM exits in general. Please can someone indicate to me the concerned files? I want to know how xen detects the execution of the CPUID instruction and ensures a guest only gets the features defined in cpuid-auto

Need help to support Xen on Zephyr

2024-09-05 Thread Naresh Ravulapalli
, we query the size of the QSPI flash device by communicating with it, during every boot this query is printing correct size; so the QSPI communication seems to work but apparently anything to do with data transfers is failing. Can someone help with the above issue, am I missing something obvious? Thanks Naresh

Re: Xen Project statistics help

2024-08-29 Thread Kelly Choi
Thanks both. I'll look to see what's possible, although if anyone could help automate this monthly that would be greatly helpful! Many thanks, Kelly Choi Community Manager Xen Project On Mon, Aug 19, 2024 at 9:38 AM Jan Beulich wrote: > On 16.08.2024 20:25, Stefano Sta

Re: Xen Project statistics help

2024-08-19 Thread Jan Beulich
On 16.08.2024 20:25, Stefano Stabellini wrote: > xen.biterg.io was created by a company called Bitergia. Bitergia was > later contracted by the Linux Foundation to create a generic dashboard > for all their Open Source projects. Getting access to the Linux > Foundation dashboard is the best way to

Re: Xen Project statistics help

2024-08-16 Thread Stefano Stabellini
On Fri, 16 Aug 2024, Stefano Stabellini wrote: > Hi Kelly, > > xen.biterg.io was created by a company called Bitergia. Bitergia was > later contracted by the Linux Foundation to create a generic dashboard > for all their Open Source projects. Getting access to the Linux > Foundation dashboard is t

Re: Xen Project statistics help

2024-08-16 Thread Stefano Stabellini
t;|@|>' '{print $3}' | sort | uniq -c | sort -rn You need to run these commands on xen.git on a Linux machine. Cheers, Stefano On Fri, 16 Aug 2024, Kelly Choi wrote: > Hi all, > I'm looking for a way to gather some statistics around our project, that > would help monito

Xen Project statistics help

2024-08-16 Thread Kelly Choi
Hi all, I'm looking for a way to gather some statistics around our project, that would help monitor the health of the community and show our progress so far. AFAIK, there used to be a dashboard on https://xen.biterg.io/ ( https://wiki.xenproject.org/wiki/Code_Review_Dashboard) which no l

Re: [PATCH] Fixed incorrect output in xl's "help" command.

2024-08-13 Thread Anthony PERARD
On Mon, Aug 05, 2024 at 04:14:34PM +0200, Juergen Gross wrote: > On 05.08.24 16:11, John E. Krokes wrote: > > In "xl help", the output includes this line: > > > > vsnd-list List virtual display devices for a domain > > > > This should obviou

Call for help - Xen user documentation

2024-08-08 Thread Kelly Choi
Hi all, As you'll know we've been working on an initiative to update documentation so that others in the community find it easier to learn about the Xen Project. @Alejandro Vallejo has kindly started our Sphinx user documentation but we need your help adding to this! *All memb

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-08-06 Thread Fonyuy-Asheri Caleb
> > None of these require extra state (i.e. registers), hence ... > >> Per my current understanding, I would expect more xstates on the VM than >> supported on the target >> server and hence a failure with xstate verification when restoring CPU state. > > ... no extra "xstates" (as you name it).

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-08-06 Thread Jan Beulich
On 06.08.2024 11:30, Fonyuy-Asheri Caleb wrote: > Seems there's more to this than I think. Here's the entire information about > my setup. > > Source Server: >Processor: Intel(R) Xeon(R) Platinum 8358 CPU @ 2.60GHz >Xsave dependences(based on xen gen-cpuid.py): > '

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-08-06 Thread Fonyuy-Asheri Caleb
> On 06.08.2024 09:34, Fonyuy-Asheri Caleb wrote: >>> If what you say in the earlier paragraph was the case with upstream Xen and >>> without you restricting what the guest being migrated was able to see on the >>> source host, then I think that would indicate a bug somewhere. Yet you don't >>>

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-08-06 Thread Jan Beulich
On 06.08.2024 09:34, Fonyuy-Asheri Caleb wrote: >> If what you say in the earlier paragraph was the case with upstream Xen and >> without you restricting what the guest being migrated was able to see on the >> source host, then I think that would indicate a bug somewhere. Yet you don't >> provide e

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-08-06 Thread Fonyuy-Asheri Caleb
> If what you say in the earlier paragraph was the case with upstream Xen and > without you restricting what the guest being migrated was able to see on the > source host, then I think that would indicate a bug somewhere. Yet you don't > provide enough details to be certain. > > Jan Sorry for not

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-08-06 Thread Jan Beulich
On 06.08.2024 09:04, Fonyuy-Asheri Caleb wrote: >> On 15/07/2024 9:16 am, Jan Beulich wrote: >>> On 15.07.2024 09:38, Fonyuy-Asheri Caleb wrote: > Perhaps the more important question, are you booting the skylake with > cpuid=no-avx on the command line by any chance? No. I didn't boot a

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-08-06 Thread Fonyuy-Asheri Caleb
Hello Andrew, Hello Jan, Please permit me to come back to this once again. > On 15/07/2024 9:16 am, Jan Beulich wrote: >> On 15.07.2024 09:38, Fonyuy-Asheri Caleb wrote: Perhaps the more important question, are you booting the skylake with cpuid=no-avx on the command line by any chanc

Re: [PATCH] Fixed incorrect output in xl's "help" command.

2024-08-05 Thread Juergen Gross
On 05.08.24 16:11, John E. Krokes wrote: In "xl help", the output includes this line: vsnd-list List virtual display devices for a domain This should obviously say "sound devices" instead of "display devices". Signed-off-by: John E. Krokes Reviewe

[PATCH] Fixed incorrect output in xl's "help" command.

2024-08-05 Thread John E. Krokes
In "xl help", the output includes this line: vsnd-list List virtual display devices for a domain This should obviously say "sound devices" instead of "display devices". Signed-off-by: John E. Krokes --- tools/xl/xl_cmdtable.c | 2 +- 1 file chang

Re: [BUG] incorrect "help" output

2024-08-05 Thread John E. Krokes
On Mon, 5 Aug 2024, Jan Beulich wrote: On 04.08.2024 15:18, John E. Krokes wrote: Here's a simple and obvious mistake: ~> xl help | grep vsnd vsnd-attach Create a new virtual sound device vsnd-list List virtual display devices for a domain vsnd-detach

Re: [BUG] incorrect "help" output

2024-08-04 Thread Jan Beulich
On 04.08.2024 15:18, John E. Krokes wrote: > Here's a simple and obvious mistake: > > > ~> xl help | grep vsnd > vsnd-attach Create a new virtual sound device > vsnd-list List virtual display devices for a domain > vsnd-detach Des

[BUG] incorrect "help" output

2024-08-04 Thread John E. Krokes
Here's a simple and obvious mistake: ~> xl help | grep vsnd vsnd-attach Create a new virtual sound device vsnd-list List virtual display devices for a domain vsnd-detach Destroy a domain's virtual sound device ~> I'm pretty sure vsnd-l

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-07-15 Thread Andrew Cooper
On 15/07/2024 9:16 am, Jan Beulich wrote: > On 15.07.2024 09:38, Fonyuy-Asheri Caleb wrote: >>> Perhaps the more important question, are you booting the skylake with >>> cpuid=no-avx on the command line by any chance? >> No. I didn't boot any of the machines with any cpuid modification >> whatsoev

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-07-15 Thread Fonyuy-Asheri Caleb
> On 15.07.2024 10:48, Fonyuy-Asheri Caleb wrote: > On 15.07.2024 09:38, Fonyuy-Asheri Caleb wrote: >>> Perhaps the more important question, are you booting the skylake with >>> cpuid=no-avx on the command line by any chance? >> >> No. I didn't boot any of the machines with an

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-07-15 Thread Jan Beulich
On 15.07.2024 10:48, Fonyuy-Asheri Caleb wrote: On 15.07.2024 09:38, Fonyuy-Asheri Caleb wrote: >> Perhaps the more important question, are you booting the skylake with >> cpuid=no-avx on the command line by any chance? > > No. I didn't boot any of the machines with any cpuid m

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-07-15 Thread Fonyuy-Asheri Caleb
>>> On 15.07.2024 09:38, Fonyuy-Asheri Caleb wrote: > Perhaps the more important question, are you booting the skylake with > cpuid=no-avx on the command line by any chance? No. I didn't boot any of the machines with any cpuid modification whatsoever. >>> >>> Yet is there pe

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-07-15 Thread Jan Beulich
On 15.07.2024 10:22, Fonyuy-Asheri Caleb wrote: > - Original Message - >> From: "Jan Beulich" >> To: "Fonyuy-Asheri Caleb" >> Cc: "xen-devel" , "Andrew Cooper" >> >> Sent: Monday, July 15, 2024 10:16:07 AM &g

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-07-15 Thread Fonyuy-Asheri Caleb
- Original Message - > From: "Jan Beulich" > To: "Fonyuy-Asheri Caleb" > Cc: "xen-devel" , "Andrew Cooper" > > Sent: Monday, July 15, 2024 10:16:07 AM > Subject: Re: Help with Understanding vcpu xstate restore error during v

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-07-15 Thread Jan Beulich
On 15.07.2024 09:38, Fonyuy-Asheri Caleb wrote: >> Perhaps the more important question, are you booting the skylake with >> cpuid=no-avx on the command line by any chance? > > No. I didn't boot any of the machines with any cpuid modification whatsoever. Yet is there perhaps "Mitigating GDS by di

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-07-15 Thread Fonyuy-Asheri Caleb
>> PV Default policy: 30 leaves, 2 MSRs >> ... >> 000d: -> 0003::0240: >> 000d:0001 -> 0007::: > > ... PV guests get nothing, while you're trying to migrate in a guest > which... > >> =

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-07-13 Thread Andrew Cooper
Ok, so trimming down to the relevant pieces, we have: On 11/07/2024 12:09 pm, Fonyuy-Asheri Caleb wrote: > = > Source server xen-cpuid -p > ==

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-07-12 Thread Jan Beulich
On 12.07.2024 11:08, Fonyuy-Asheri Caleb wrote: >>> I was able to locate the failure point to the file >>> xen/arch/x86/domctl.c  with the following check. >>> >>> if( evc->size>> evc->size>PV_XSAVE_SIZE(xfeature_mask) ) >>> gotovcpuextstate_out; >> >> It is certainly more complicated than that. >>

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-07-12 Thread Fonyuy-Asheri Caleb
Hi Andrew, >> I was able to locate the failure point to the file >> xen/arch/x86/domctl.c  with the following check. >> >> if( evc->size> evc->size>PV_XSAVE_SIZE(xfeature_mask) ) >> gotovcpuextstate_out; > > It is certainly more complicated than that. > > What that's saying is that Xen doesn't

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-07-11 Thread Fonyuy-Asheri Caleb
- Original Message - > From: "Andrew Cooper" > To: "Fonyuy-Asheri Caleb" > Cc: "xen-devel" , "Jan Beulich" > , "Roger Pau Monné" > > Sent: Thursday, July 11, 2024 3:04:05 PM > Subject: Re: Help with Understanding

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-07-11 Thread Andrew Cooper
On 11/07/2024 1:18 pm, Fonyuy-Asheri Caleb wrote: >>> Please do you mind giving me more insight on the logic currently implemented >>> and maybe what is wrong with it? It will be important for me since what I'm >>> doing is research work. >> See 9e6dbbe8bf40^..267122a24c49 > What reference is this

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-07-11 Thread Fonyuy-Asheri Caleb
>> Please do you mind giving me more insight on the logic currently implemented >> and maybe what is wrong with it? It will be important for me since what I'm >> doing is research work. > > See 9e6dbbe8bf40^..267122a24c49 What reference is this please? > >> How do the values evc->size and xf

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-07-11 Thread Andrew Cooper
On 11/07/2024 12:09 pm, Fonyuy-Asheri Caleb wrote: > - Original Message - >> From: "Andrew Cooper" >> To: "Fonyuy-Asheri Caleb" , "xen-devel" >> >> Sent: Thursday, July 11, 2024 12:45:18 PM >> Subject: Re: Help with Unders

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-07-11 Thread Fonyuy-Asheri Caleb
- Original Message - > From: "Andrew Cooper" > To: "Fonyuy-Asheri Caleb" , "xen-devel" > > Sent: Thursday, July 11, 2024 12:45:18 PM > Subject: Re: Help with Understanding vcpu xstate restore error during vm > migration > On 11/07

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-07-11 Thread Andrew Cooper
On 11/07/2024 11:38 am, Fonyuy-Asheri Caleb wrote: > Hello,  > > I am trying to understand the causes of the vcpu xstate restore error > during live migration. > I get the following error during live migration:  > > xc: error: Failed to set vcpu0's xsave info (22 = Invalid argument): > Internal e

Help with Understanding vcpu xstate restore error during vm migration

2024-07-11 Thread Fonyuy-Asheri Caleb
Hello, I am trying to understand the causes of the vcpu xstate restore error during live migration. I get the following error during live migration: xc: error: Failed to set vcpu0's xsave info (22 = Invalid argument): Internal error I was able to locate the failure point to the file xen/ar

[PATCH v6 1/7] tools/xl: Correct the help information and exit code of the dt-overlay command

2024-05-24 Thread Stefano Stabellini
ain_dt_overlay, 0, 1, "Add/Remove a device tree overlay", - "add/remove <.dtbo>" + "add/remove <.dtbo>", "-h print this help\n" }, #endif diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c index 98f6bd2e7

[PATCH v5 1/7] tools/xl: Correct the help information and exit code of the dt-overlay command

2024-05-23 Thread Stefano Stabellini
ain_dt_overlay, 0, 1, "Add/Remove a device tree overlay", - "add/remove <.dtbo>" + "add/remove <.dtbo>", "-h print this help\n" }, #endif diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c index 98f6bd2e7

Re: [PATCH v4 1/9] tools/xl: Correct the help information and exit code of the dt-overlay command

2024-05-23 Thread Stefano Stabellini
mdtable.c b/tools/xl/xl_cmdtable.c > index 62bdb2aeaa..1f3c6b5897 100644 > --- a/tools/xl/xl_cmdtable.c > +++ b/tools/xl/xl_cmdtable.c > @@ -635,7 +635,7 @@ const struct cmd_spec cmd_table[] = { > { "dt-overlay", >&main_dt_overlay, 0, 1, >"Add/Remove

[PATCH v4 1/9] tools/xl: Correct the help information and exit code of the dt-overlay command

2024-05-23 Thread Henry Wang
uot;, &main_dt_overlay, 0, 1, "Add/Remove a device tree overlay", - "add/remove <.dtbo>" + "add/remove <.dtbo>", "-h print this help\n" }, #endif diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontr

[PATCH v3 2/8] tools/xl: Correct the help information and exit code of the dt-overlay command

2024-05-20 Thread Henry Wang
amp;main_dt_overlay, 0, 1, "Add/Remove a device tree overlay", - "add/remove <.dtbo>" + "add/remove <.dtbo>", "-h print this help\n" }, #endif diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c index 98f6

Re: [PATCH v2 2/8] tools/xl: Correct the help information and exit code of the dt-overlay command

2024-05-20 Thread Jason Andryuk
On 2024-05-16 06:03, Henry Wang wrote: Fix the name mismatch in the xl dt-overlay command, the command name should be "dt-overlay" instead of "dt_overlay". Add the missing "," in the cmdtable. Fix the exit code of the dt-overlay command, use EXIT_FAILURE instead of ERROR_FAIL. Fixes: 61765a07e3

[PATCH v2 2/8] tools/xl: Correct the help information and exit code of the dt-overlay command

2024-05-16 Thread Henry Wang
lay", - "add/remove <.dtbo>" + "add/remove <.dtbo>", "-h print this help\n" }, #endif diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c index 98f6bd2e76..02575d5d36 100644 --- a/tools/xl/xl_vmcontrol.c +++

[PATCH v2 2/2] tools/xl: Correct the help information and exit code of the dt-overlay command

2024-05-07 Thread Henry Wang
--- a/tools/xl/xl_vmcontrol.c +++ b/tools/xl/xl_vmcontrol.c @@ -1278,7 +1278,7 @@ int main_dt_overlay(int argc, char **argv) const int overlay_remove_op = 2; if (argc < 2) { -help("dt_overlay"); +help("dt-overlay"); return EXIT_FAILURE;

Re: [PATCH] xen/Kconfig: Drop the final remnants of ---help---

2024-05-03 Thread Oleksii
On Thu, 2024-05-02 at 19:10 +0100, Andrew Cooper wrote: > We deprecated the use of ---help--- a while ago, but a lot of new > content > copy&pastes bad examples.  Convert the remaining instances, and > update > Kconfig's parser to no longer recongise it. > > This

Re: [PATCH] xen/Kconfig: Drop the final remnants of ---help---

2024-05-02 Thread Stefano Stabellini
On Thu, 2 May 2024, Andrew Cooper wrote: > We deprecated the use of ---help--- a while ago, but a lot of new content > copy&pastes bad examples. Convert the remaining instances, and update > Kconfig's parser to no longer recongise it. > > This now causes builds to fail wi

[PATCH] xen/Kconfig: Drop the final remnants of ---help---

2024-05-02 Thread Andrew Cooper
We deprecated the use of ---help--- a while ago, but a lot of new content copy&pastes bad examples. Convert the remaining instances, and update Kconfig's parser to no longer recongise it. This now causes builds to fail with: Kconfig.debug:8: syntax error Kconfig.debug:7: unknown

Re: IMPORTANT - : Need help on USB port virtualization with Xen hypervisor

2024-03-15 Thread Jürgen Groß
On 16.03.24 00:32, Stefano Stabellini wrote: Hi Dominique, You posted this configuration: device_model_args = [ "   "-device","nec-usb-xhci,id=xhci",   "-device","usb-host,bus=xhci.0,hostbus=1,hostport=13",   "-device","usb-host,bus

RE: IMPORTANT - : Need help on USB port virtualization with Xen hypervisor

2024-03-15 Thread Stefano Stabellini
Cheers, Stefano On Thu, 14 Mar 2024, LARRIEU Dominique wrote: > Hi Julien, > >   > > You will find here above the answers to your questions. > >   > > Thank you very much for your help. > >   > > Best regards, > > Dominique > >   > >   &

RE: IMPORTANT - : Need help on USB port virtualization with Xen hypervisor

2024-03-14 Thread LARRIEU Dominique
Hi Julien, You will find here above the answers to your questions. Thank you very much for your help. Best regards, Dominique -Message d'origine- De : Julien Grall mailto:jul...@xen.org>> Envoyé : jeudi 29 février 2024 12:52 À : LARRIEU Dominique mailto:dom

Re: IMPORTANT - : Need help on USB port virtualization with Xen hypervisor

2024-02-29 Thread Julien Grall
s] : we are using the USB chipset of the mother board (see below the references) Thanks for the clarification. IIUC, you said you are having problem in the guest itself. Have you tried to access the same USB device from dom0? Or better without any Xen involved (i.e. booting Debian on baremetal).

RE: IMPORTANT - : Need help on USB port virtualization with Xen hypervisor

2024-02-29 Thread LARRIEU Dominique
ger@citrix.com>>; Andrew Cooper mailto:andrew.coop...@citrix.com>>; George Dunlap mailto:george.dun...@citrix.com>>; Jan Beulich mailto:jbeul...@suse.com>>; Juergen Gross mailto:jgr...@suse.com>> Objet : Re: IMPORTANT - : Need help on USB port virtualization with

RE: IMPORTANT - : Need help on USB port virtualization with Xen hypervisor

2024-02-26 Thread GOURLOT Francois
France De : Rob Townley De Envoyé : dimanche 25 février 2024 13:20 À : Julien Grall Cc : Andrew Cooper ; GOURLOT Francois ; George Dunlap ; Jan Beulich ; Juergen Gross ; Kelly Choi ; Roger Pau Monné ; xen-devel@lists.xenproject.org Objet : Re: IMPORTANT - : Need help on USB port

Re: IMPORTANT - : Need help on USB port virtualization with Xen hypervisor

2024-02-25 Thread Rob Townley
sniffing USB traffic, but my name is not Heisenberg and not sure if that traffic monitoring does not also slow down other devices. On Sat, Feb 24, 2024 at 8:39 AM Julien Grall wrote: > Hi Dominique and Francois, > > Thank you for the report. I am CCing some person who I think could help. &

Re: IMPORTANT - : Need help on USB port virtualization with Xen hypervisor

2024-02-24 Thread Julien Grall
Hi Dominique and Francois, Thank you for the report. I am CCing some person who I think could help. I also have some questions (see below). On 23/02/2024 16:00, GOURLOT Francois wrote: Dear All, We send you a message few days ago. We have major performance with XEN USB Drivers. We use your

IMPORTANT - : Need help on USB port virtualization with Xen hypervisor

2024-02-23 Thread GOURLOT Francois
; Kelly Choi Objet : Need help on USB port virtualization with Xen hypervisor Critère de diffusion : Confidentiel Dear all, We are detecting several issues with USB port virtualization with the Xen hypervisor. - We cannot do PCI passthrough of the PCI usb bus on a Windows 10 1607 64-bit virtual

Need help on USB port virtualization with Xen hypervisor

2024-02-22 Thread LARRIEU Dominique
virtual machine, we notice that the speed of the USB port is not high speed but full speed on a USB 3.0 port - We notice instabilities when using the nec-usb-xhci driver, USB 2.0 keys are not recognized by the Windows virtual machine (incorrect descriptor) We need your help to find a solution

Re: [XEN PATCH v2] domain: add ASSERT to help static analysis tools

2023-11-24 Thread Nicola Vetrini
On 2023-11-17 10:21, Nicola Vetrini wrote: Static analysis tools may detect a possible null pointer dereference of 'config'. This ASSERT helps them in detecting that such a condition is not possible given that only real domains can enter this branch, which are guaranteeed to have a non-NULL confi

[XEN PATCH v2] domain: add ASSERT to help static analysis tools

2023-11-17 Thread Nicola Vetrini
Static analysis tools may detect a possible null pointer dereference of 'config'. This ASSERT helps them in detecting that such a condition is not possible given that only real domains can enter this branch, which are guaranteeed to have a non-NULL config at this point, but this information is not

Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-14 Thread Nicola Vetrini
On 2023-11-11 02:13, Stefano Stabellini wrote: On Fri, 10 Nov 2023, Nicola Vetrini wrote: Hi everyone, I trimmed the thread a bit, to make this more readable. > > > > > IMHO, the only viable option would be to have a configuration to > > > > > keep > > > > > ASSERT in production build for scan

Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-10 Thread Stefano Stabellini
On Fri, 10 Nov 2023, Nicola Vetrini wrote: > Hi everyone, > > I trimmed the thread a bit, to make this more readable. > > > > > > > IMHO, the only viable option would be to have a configuration to > > > > > > keep > > > > > > ASSERT in production build for scanning tools. > > > > > > > > > > But

Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-10 Thread Andrew Cooper
gt;> >> I have an idea that might resolve this differently and in an easier way. >> >> Would you be happy waiting for a couple of days for me to experiment?  >> Absolutely no guarantees of it turning into a workable solution. >> > > Sure, no problem. > I

Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-10 Thread Nicola Vetrini
Hi everyone, I trimmed the thread a bit, to make this more readable. IMHO, the only viable option would be to have a configuration to keep ASSERT in production build for scanning tools. But wouldn't that then likely mean scanning to be done on builds not also used in production? Would doing

Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-10 Thread Julien Grall
Hi Stefano, On 10/11/2023 00:29, Stefano Stabellini wrote: On Thu, 9 Nov 2023, Julien Grall wrote: On 09/11/2023 07:42, Jan Beulich wrote: On 08.11.2023 14:33, Julien Grall wrote: Hi Jan, On 08/11/2023 11:19, Jan Beulich wrote: On 08.11.2023 12:03, Nicola Vetrini wrote: On 2023-11-08 09:24

Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-09 Thread Stefano Stabellini
On Thu, 9 Nov 2023, Julien Grall wrote: > On 09/11/2023 07:42, Jan Beulich wrote: > > On 08.11.2023 14:33, Julien Grall wrote: > > > Hi Jan, > > > > > > On 08/11/2023 11:19, Jan Beulich wrote: > > > > On 08.11.2023 12:03, Nicola Vetrini wrote: > > > > > On 2023-11-08 09:24, Jan Beulich wrote: > >

Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-09 Thread Julien Grall
Hi Jan, On 09/11/2023 07:42, Jan Beulich wrote: On 08.11.2023 14:33, Julien Grall wrote: Hi Jan, On 08/11/2023 11:19, Jan Beulich wrote: On 08.11.2023 12:03, Nicola Vetrini wrote: On 2023-11-08 09:24, Jan Beulich wrote: On 03.11.2023 18:58, Nicola Vetrini wrote: Static analysis tools may d

Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-08 Thread Jan Beulich
On 08.11.2023 14:28, Nicola Vetrini wrote: > On 2023-11-08 12:19, Jan Beulich wrote: >> On 08.11.2023 12:03, Nicola Vetrini wrote: >>> On 2023-11-08 09:24, Jan Beulich wrote: On 03.11.2023 18:58, Nicola Vetrini wrote: > Static analysis tools may detect a possible null > pointer derefer

Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-08 Thread Jan Beulich
On 08.11.2023 14:33, Julien Grall wrote: > Hi Jan, > > On 08/11/2023 11:19, Jan Beulich wrote: >> On 08.11.2023 12:03, Nicola Vetrini wrote: >>> On 2023-11-08 09:24, Jan Beulich wrote: On 03.11.2023 18:58, Nicola Vetrini wrote: > Static analysis tools may detect a possible null > poin

Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-08 Thread Nicola Vetrini
On 2023-11-08 14:37, Andrew Cooper wrote: On 03/11/2023 5:58 pm, Nicola Vetrini wrote: Static analysis tools may detect a possible null pointer dereference at line 760 (the memcpy call) of xen/common/domain.c. This ASSERT helps them in detecting that such a condition is not possible and also pro

Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-08 Thread Andrew Cooper
On 03/11/2023 5:58 pm, Nicola Vetrini wrote: > Static analysis tools may detect a possible null > pointer dereference at line 760 (the memcpy call) > of xen/common/domain.c. This ASSERT helps them in > detecting that such a condition is not possible > and also provides a basic sanity check. > > Sig

Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-08 Thread Julien Grall
Hi Jan, On 08/11/2023 11:19, Jan Beulich wrote: On 08.11.2023 12:03, Nicola Vetrini wrote: On 2023-11-08 09:24, Jan Beulich wrote: On 03.11.2023 18:58, Nicola Vetrini wrote: Static analysis tools may detect a possible null pointer dereference at line 760 (the memcpy call) of xen/common/domain

Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-08 Thread Nicola Vetrini
On 2023-11-08 12:19, Jan Beulich wrote: On 08.11.2023 12:03, Nicola Vetrini wrote: On 2023-11-08 09:24, Jan Beulich wrote: On 03.11.2023 18:58, Nicola Vetrini wrote: Static analysis tools may detect a possible null pointer dereference at line 760 (the memcpy call) of xen/common/domain.c. This

Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-08 Thread Jan Beulich
On 08.11.2023 12:03, Nicola Vetrini wrote: > On 2023-11-08 09:24, Jan Beulich wrote: >> On 03.11.2023 18:58, Nicola Vetrini wrote: >>> Static analysis tools may detect a possible null >>> pointer dereference at line 760 (the memcpy call) >>> of xen/common/domain.c. This ASSERT helps them in >>> det

Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-08 Thread Nicola Vetrini
On 2023-11-08 09:24, Jan Beulich wrote: On 03.11.2023 18:58, Nicola Vetrini wrote: Static analysis tools may detect a possible null pointer dereference at line 760 (the memcpy call) of xen/common/domain.c. This ASSERT helps them in detecting that such a condition is not possible and also provide

Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-08 Thread Jan Beulich
On 03.11.2023 18:58, Nicola Vetrini wrote: > Static analysis tools may detect a possible null > pointer dereference at line 760 (the memcpy call) > of xen/common/domain.c. This ASSERT helps them in > detecting that such a condition is not possible > and also provides a basic sanity check. I disagr

Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-06 Thread Stefano Stabellini
On Fri, 3 Nov 2023, Nicola Vetrini wrote: > On 2023-11-03 18:58, Nicola Vetrini wrote: > > Static analysis tools may detect a possible null > > pointer dereference at line 760 (the memcpy call) > > of xen/common/domain.c. This ASSERT helps them in > > detecting that such a condition is not possible

Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-03 Thread Nicola Vetrini
On 2023-11-03 18:58, Nicola Vetrini wrote: Static analysis tools may detect a possible null pointer dereference at line 760 (the memcpy call) of xen/common/domain.c. This ASSERT helps them in detecting that such a condition is not possible and also provides a basic sanity check. Suggested-by: J

[XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-03 Thread Nicola Vetrini
Static analysis tools may detect a possible null pointer dereference at line 760 (the memcpy call) of xen/common/domain.c. This ASSERT helps them in detecting that such a condition is not possible and also provides a basic sanity check. Signed-off-by: Nicola Vetrini --- The check may be later imp

Re: [PATCH v1] xentrace: adjust exit code for --help option

2023-07-28 Thread George Dunlap
On Fri, May 26, 2023 at 1:38 PM Olaf Hering wrote: > Invoking the --help option of any tool should not return with an error, > if that tool does have a documented and implemented help option. > > Adjust the usage() function to exit with either error or success. > Handle the existi

RE: [PATCH] xen/dt: Rework the prototype of dt_property_read_string() to help Eclair

2023-07-24 Thread Henry Wang
Hi Julien, > -Original Message- > Subject: [PATCH] xen/dt: Rework the prototype of dt_property_read_string() > to help Eclair > > From: Julien Grall > > Eclair vXXX is unable to prove the parameter out_string will only be > used the return of dt_property_read_s

Re: [PATCH] xen/dt: Rework the prototype of dt_property_read_string() to help Eclair

2023-07-24 Thread Stefano Stabellini
On Mon, 24 Jul 2023, Julien Grall wrote: > From: Julien Grall > > Eclair vXXX is unable to prove the parameter out_string will only be > used the return of dt_property_read_string() is 0. So it will consider > that MISRA C:2012 Rule 9.1 was violated. > > Rework the prototype so the string is ret

Re: [PATCH] xen/dt: Rework the prototype of dt_property_read_string() to help Eclair

2023-07-24 Thread Julien Grall
Hi Nicola, On 24/07/2023 13:58, Nicola Vetrini wrote: On 24/07/23 12:24, Julien Grall wrote: From: Julien Grall Eclair vXXX is unable to prove the parameter out_string will only be used the return of dt_property_read_string() is 0. So it will consider that MISRA C:2012 Rule 9.1 was violated

Re: [PATCH] xen/dt: Rework the prototype of dt_property_read_string() to help Eclair

2023-07-24 Thread Nicola Vetrini
On 24/07/23 12:24, Julien Grall wrote: From: Julien Grall Eclair vXXX is unable to prove the parameter out_string will only be used the return of dt_property_read_string() is 0. So it will consider that MISRA C:2012 Rule 9.1 was violated. This is not correct: ECLAIR cannot prove that the r

[PATCH] xen/dt: Rework the prototype of dt_property_read_string() to help Eclair

2023-07-24 Thread Julien Grall
From: Julien Grall Eclair vXXX is unable to prove the parameter out_string will only be used the return of dt_property_read_string() is 0. So it will consider that MISRA C:2012 Rule 9.1 was violated. Rework the prototype so the string is returned and use ERR_PTR() to embed the error code. Signe

Re: Asking for help to debug xen efi on Kunpeng machine

2023-06-30 Thread Jiatong Shen
Hi Julien, Thank you for your answer. Do you have any advice on how to debug the issue? I have very little experience with xen so I think I still need debugging even if I can get MBI-gen's tech doc... Best regards, Jiatong Shen On Fri, Jun 30, 2023 at 5:42 AM Julien Grall wrote: > On 24/06/

Re: Asking for help to debug xen efi on Kunpeng machine

2023-06-29 Thread Julien Grall
On 24/06/2023 15:54, Jiatong Shen wrote: Hello Julien, Hi, Thank you very much for your reply. Can you teach me how to find the relationship between MBI-gen and devices? I am not sure how to find out the mbi-gen backed devices.. I am afraid I don't have any experience with the MBI-gen.

  1   2   3   >