Re: blocking vs. non-blocking mmu notifiers

2022-03-24 Thread Michal Hocko
On Wed 23-03-22 14:04:04, Jason Gunthorpe wrote: > On Wed, Mar 23, 2022 at 05:49:43PM +0100, Michal Hocko wrote: > > > The bug here is that prior to commit a81461b0546c ("xen/gntdev: update > > > to new mmu_notifier semantic") wired the mn_invl_range_start() which > > > takes a mutex to invalidate_

Re: blocking vs. non-blocking mmu notifiers

2022-03-23 Thread Jason Gunthorpe
On Wed, Mar 23, 2022 at 05:49:43PM +0100, Michal Hocko wrote: > > The bug here is that prior to commit a81461b0546c ("xen/gntdev: update > > to new mmu_notifier semantic") wired the mn_invl_range_start() which > > takes a mutex to invalidate_page, which is defined to run in an atomic > > context. >

Re: blocking vs. non-blocking mmu notifiers

2022-03-23 Thread Michal Hocko
On Wed 23-03-22 13:31:46, Jason Gunthorpe wrote: > On Wed, Mar 23, 2022 at 10:45:30AM +0100, Michal Hocko wrote: > > [Let me add more people to the CC list - I am not really sure who is the > > most familiar with all the tricks that mmu notifiers might do] > > > > On Wed 23-03-22 09:43:59, Juerge

Re: blocking vs. non-blocking mmu notifiers

2022-03-23 Thread Jason Gunthorpe
On Wed, Mar 23, 2022 at 10:45:30AM +0100, Michal Hocko wrote: > [Let me add more people to the CC list - I am not really sure who is the > most familiar with all the tricks that mmu notifiers might do] > > On Wed 23-03-22 09:43:59, Juergen Gross wrote: > > Hi, > > > > during analysis of a custom

Re: blocking vs. non-blocking mmu notifiers

2022-03-23 Thread Michal Hocko
[Let me add more people to the CC list - I am not really sure who is the most familiar with all the tricks that mmu notifiers might do] On Wed 23-03-22 09:43:59, Juergen Gross wrote: > Hi, > > during analysis of a customer's problem on a 4.12 based kernel > (deadlock due to a blocking mmu notifi

blocking vs. non-blocking mmu notifiers

2022-03-23 Thread Juergen Gross
Hi, during analysis of a customer's problem on a 4.12 based kernel (deadlock due to a blocking mmu notifier in a Xen driver) I came across upstream patches 93065ac753e4 ("mm, oom: distinguish blockable mode for mmu notifiers") et al. The backtrace of the blocked tasks was typically something lik