Re: Yet another S3 issue in Xen 4.14

2020-10-03 Thread Marek Marczykowski-Górecki
On Fri, Oct 02, 2020 at 09:19:55PM +0200, Marek Marczykowski-Górecki wrote: > Disabling efi_get_time() or setting CR4 earlier solves _this_ issue, but > applied on top of stable-4.14 still doesn't work. Looks like there is > yet another S3 breakage in between. I'm bisecting it further... This time

Re: Yet another S3 issue in Xen 4.14

2020-10-02 Thread Marek Marczykowski-Górecki
On Fri, Oct 02, 2020 at 04:42:50PM +0100, Andrew Cooper wrote: > On 02/10/2020 16:39, Jan Beulich wrote: > > On 02.10.2020 17:08, Marek Marczykowski-Górecki wrote: > >> I've done another bisect on the commit broken up in separate changes > >> (https://xenbits.xen.org/gitweb/?p=people/andrewcoop/xen

Re: Yet another S3 issue in Xen 4.14

2020-10-02 Thread Andrew Cooper
On 02/10/2020 16:39, Jan Beulich wrote: > On 02.10.2020 17:08, Marek Marczykowski-Górecki wrote: >> I've done another bisect on the commit broken up in separate changes >> (https://xenbits.xen.org/gitweb/?p=people/andrewcoop/xen.git;a=shortlog;h=refs/heads/dbg-s3) >> and the bad part seems to be th

Re: Yet another S3 issue in Xen 4.14

2020-10-02 Thread Jan Beulich
On 02.10.2020 17:08, Marek Marczykowski-Górecki wrote: > I've done another bisect on the commit broken up in separate changes > (https://xenbits.xen.org/gitweb/?p=people/andrewcoop/xen.git;a=shortlog;h=refs/heads/dbg-s3) > and the bad part seems to be this: > > From dbdb32f8c265295d6af7cd4cd0aa12b

Re: Yet another S3 issue in Xen 4.14

2020-10-02 Thread Marek Marczykowski-Górecki
On Thu, Oct 01, 2020 at 01:43:52PM +0100, Andrew Cooper wrote: > On 01/10/2020 13:31, Marek Marczykowski-Górecki wrote: > > On Thu, Oct 01, 2020 at 01:59:32PM +0200, Jan Beulich wrote: > >> On 01.10.2020 03:12, Marek Marczykowski-Górecki wrote: > >>> After patching the previous issue ("x86/S3: Fix

Re: Yet another S3 issue in Xen 4.14

2020-10-01 Thread Andrew Cooper
On 01/10/2020 13:31, Marek Marczykowski-Górecki wrote: > On Thu, Oct 01, 2020 at 01:59:32PM +0200, Jan Beulich wrote: >> On 01.10.2020 03:12, Marek Marczykowski-Górecki wrote: >>> After patching the previous issue ("x86/S3: Fix Shadow Stack resume >>> path") I still encounter issues resume from S3.

Re: Yet another S3 issue in Xen 4.14

2020-10-01 Thread Marek Marczykowski-Górecki
On Thu, Oct 01, 2020 at 01:59:32PM +0200, Jan Beulich wrote: > On 01.10.2020 03:12, Marek Marczykowski-Górecki wrote: > > After patching the previous issue ("x86/S3: Fix Shadow Stack resume > > path") I still encounter issues resume from S3. > > Since I had it working on Xen 4.13 on this particular

Re: Yet another S3 issue in Xen 4.14

2020-10-01 Thread Jan Beulich
On 01.10.2020 14:00, Marek Marczykowski-Górecki wrote: > On Thu, Oct 01, 2020 at 03:12:47AM +0200, Marek Marczykowski-Górecki wrote: >> After patching the previous issue ("x86/S3: Fix Shadow Stack resume >> path") I still encounter issues resume from S3. >> Since I had it working on Xen 4.13 on thi

Re: Yet another S3 issue in Xen 4.14

2020-10-01 Thread Marek Marczykowski-Górecki
On Thu, Oct 01, 2020 at 03:12:47AM +0200, Marek Marczykowski-Górecki wrote: > Hi, > > After patching the previous issue ("x86/S3: Fix Shadow Stack resume > path") I still encounter issues resume from S3. > Since I had it working on Xen 4.13 on this particular hardware (Thinkpad > P52), I bisected

Re: Yet another S3 issue in Xen 4.14

2020-10-01 Thread Jan Beulich
On 01.10.2020 03:12, Marek Marczykowski-Górecki wrote: > After patching the previous issue ("x86/S3: Fix Shadow Stack resume > path") I still encounter issues resume from S3. > Since I had it working on Xen 4.13 on this particular hardware (Thinkpad > P52), I bisected it and got this: > > commit 4

Yet another S3 issue in Xen 4.14

2020-09-30 Thread Marek Marczykowski-Górecki
Hi, After patching the previous issue ("x86/S3: Fix Shadow Stack resume path") I still encounter issues resume from S3. Since I had it working on Xen 4.13 on this particular hardware (Thinkpad P52), I bisected it and got this: commit 4304ff420e51b973ec9eb9dafd64a917dd9c0fb1 Author: Andrew Cooper