Re: XENMAPSPACE_grant_table vs. GNTTABOP_setup_table

2020-06-10 Thread Martin Lucina
On Wednesday, 10.06.2020 at 15:21, Andrew Cooper wrote: > > I don't need v2 at all, I was just going by the comments in grant_table.h, > > which read: "Version 1 of the grant table entry structure is maintained > > purely for backwards compatibility. New guests should use version 2." > > Ha... >

Re: XENMAPSPACE_grant_table vs. GNTTABOP_setup_table

2020-06-10 Thread Andrew Cooper
On 10/06/2020 14:56, Martin Lucina wrote: > On Wednesday, 10.06.2020 at 14:40, Andrew Cooper wrote: >>> So, going with the grant v2 ABI, is there a modern equivalent of >>> GNTTABOP_get_status_frames? Reading memory.h I'm guessing that it might be >>> XENMEM_add_to_physmap with space=XENMAPSPACE_gr

Re: XENMAPSPACE_grant_table vs. GNTTABOP_setup_table

2020-06-10 Thread Martin Lucina
On Wednesday, 10.06.2020 at 14:40, Andrew Cooper wrote: > > So, going with the grant v2 ABI, is there a modern equivalent of > > GNTTABOP_get_status_frames? Reading memory.h I'm guessing that it might be > > XENMEM_add_to_physmap with space=XENMAPSPACE_grant_table and > > idx=(XENMAPIDX_grant_table

Re: XENMAPSPACE_grant_table vs. GNTTABOP_setup_table

2020-06-10 Thread Andrew Cooper
On 10/06/2020 14:22, Martin Lucina wrote: > On Tuesday, 09.06.2020 at 11:22, Andrew Cooper wrote: >> There is a little bit of history here... >> >> GNTTABOP_setup_table was the original PV way of doing things (specify >> size as an input, get a list of frames as an output to map), and >> XENMAPSPAC

Re: XENMAPSPACE_grant_table vs. GNTTABOP_setup_table

2020-06-10 Thread Martin Lucina
On Tuesday, 09.06.2020 at 11:22, Andrew Cooper wrote: > There is a little bit of history here... > > GNTTABOP_setup_table was the original PV way of doing things (specify > size as an input, get a list of frames as an output to map), and > XENMAPSPACE_grant_table was the original HVM way of doing

Re: XENMAPSPACE_grant_table vs. GNTTABOP_setup_table

2020-06-09 Thread Julien Grall
The basics are now functional and I have started to re-implement the grant table code. After studying both the Mini-OS and Linux implementations some, I don't understand the difference between using XENMAPSPACE_grant_table vs. GNTTABOP_setup_table to set up the initial grant table mapping

Re: XENMAPSPACE_grant_table vs. GNTTABOP_setup_table

2020-06-09 Thread Anil Madhavapeddy
gt;> re-implement the grant table code. >> >> After studying both the Mini-OS and Linux implementations some, I don't >> understand the difference between using XENMAPSPACE_grant_table vs. >> GNTTABOP_setup_table to set up the initial grant table mapping

Re: XENMAPSPACE_grant_table vs. GNTTABOP_setup_table

2020-06-09 Thread Andrew Cooper
both the Mini-OS and Linux implementations some, I don't > understand the difference between using XENMAPSPACE_grant_table vs. > GNTTABOP_setup_table to set up the initial grant table mapping for the > guest. > > Are these calls just newer and older ways of accomplishing the same thing? &

XENMAPSPACE_grant_table vs. GNTTABOP_setup_table

2020-06-09 Thread Martin Lucina
ce between using XENMAPSPACE_grant_table vs. GNTTABOP_setup_table to set up the initial grant table mapping for the guest. Are these calls just newer and older ways of accomplishing the same thing? The Linux driver seems to use both in various conditions, whereas Mini-OS uses the former on ARM and