Re: Refactoring of a possibly unsafe pattern for variable initialization via function calls

2023-06-19 Thread Luca Fancellu
> On 19 Jun 2023, at 09:50, Julien Grall wrote: > > > > On 19/06/2023 09:31, Luca Fancellu wrote: >>> On 19 Jun 2023, at 09:23, Julien Grall wrote: >>> >>> >>> >>> On 19/06/2023 09:18, Jan Beulich wrote: On 16.06.2023 22:56, Stefano Stabellini wrote: > On Fri, 16 Jun 2023, Nicola

Re: Refactoring of a possibly unsafe pattern for variable initialization via function calls

2023-06-19 Thread Julien Grall
On 19/06/2023 09:31, Luca Fancellu wrote: On 19 Jun 2023, at 09:23, Julien Grall wrote: On 19/06/2023 09:18, Jan Beulich wrote: On 16.06.2023 22:56, Stefano Stabellini wrote: On Fri, 16 Jun 2023, Nicola Vetrini wrote: On 16/06/23 09:19, Jan Beulich wrote: On 15.06.2023 18:39, nicola

Re: Refactoring of a possibly unsafe pattern for variable initialization via function calls

2023-06-19 Thread Luca Fancellu
> On 19 Jun 2023, at 09:23, Julien Grall wrote: > > > > On 19/06/2023 09:18, Jan Beulich wrote: >> On 16.06.2023 22:56, Stefano Stabellini wrote: >>> On Fri, 16 Jun 2023, Nicola Vetrini wrote: On 16/06/23 09:19, Jan Beulich wrote: > On 15.06.2023 18:39, nicola wrote: >> while inv

Re: Refactoring of a possibly unsafe pattern for variable initialization via function calls

2023-06-19 Thread Julien Grall
On 19/06/2023 09:18, Jan Beulich wrote: On 16.06.2023 22:56, Stefano Stabellini wrote: On Fri, 16 Jun 2023, Nicola Vetrini wrote: On 16/06/23 09:19, Jan Beulich wrote: On 15.06.2023 18:39, nicola wrote: while investigating possible patches regarding Mandatory Rule 9.1, I found the followin

Re: Refactoring of a possibly unsafe pattern for variable initialization via function calls

2023-06-19 Thread Jan Beulich
On 16.06.2023 22:56, Stefano Stabellini wrote: > On Fri, 16 Jun 2023, Nicola Vetrini wrote: >> On 16/06/23 09:19, Jan Beulich wrote: >>> On 15.06.2023 18:39, nicola wrote: while investigating possible patches regarding Mandatory Rule 9.1, I found the following pattern, that is likely to r

Re: Refactoring of a possibly unsafe pattern for variable initialization via function calls

2023-06-16 Thread Stefano Stabellini
On Fri, 16 Jun 2023, Nicola Vetrini wrote: > On 16/06/23 09:19, Jan Beulich wrote: > > On 15.06.2023 18:39, nicola wrote: > > > while investigating possible patches regarding Mandatory Rule 9.1, I > > > found the following pattern, that is likely to results in a lot possible > > > positives from ma

Re: Refactoring of a possibly unsafe pattern for variable initialization via function calls

2023-06-16 Thread Nicola Vetrini
On 16/06/23 09:19, Jan Beulich wrote: On 15.06.2023 18:39, nicola wrote: while investigating possible patches regarding Mandatory Rule 9.1, I found the following pattern, that is likely to results in a lot possible positives from many (all) static analysis tools for this rule. This is the cu

Re: Refactoring of a possibly unsafe pattern for variable initialization via function calls

2023-06-16 Thread Jan Beulich
On 15.06.2023 18:39, nicola wrote: > while investigating possible patches regarding Mandatory Rule 9.1, I > found the following pattern, that is likely to results in a lot possible > positives from many (all) static analysis tools for this rule. > > This is the current status (taken from `xen/comm

Refactoring of a possibly unsafe pattern for variable initialization via function calls

2023-06-15 Thread nicola
Hi all, while investigating possible patches regarding Mandatory Rule 9.1, I found the following pattern, that is likely to results in a lot possible positives from many (all) static analysis tools for this rule. This is the current status (taken from `xen/common/device_tree.c:135') const stru