Re: Re: Re: Re: Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-29 Thread Joel Granados
On Tue, Jan 28, 2025 at 10:43:10AM -0500, Paul Moore wrote: > On Tue, Jan 28, 2025 at 6:22 AM Joel Granados > wrote: > > On Mon, Jan 27, 2025 at 03:42:39PM +, Matthew Wilcox wrote: > > > On Mon, Jan 27, 2025 at 04:55:58PM +0200, Jani Nikula wrote: > > > > You could have static const within fu

Re: Re: Re: Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-28 Thread Paul Moore
On Tue, Jan 28, 2025 at 6:22 AM Joel Granados wrote: > On Mon, Jan 27, 2025 at 03:42:39PM +, Matthew Wilcox wrote: > > On Mon, Jan 27, 2025 at 04:55:58PM +0200, Jani Nikula wrote: > > > You could have static const within functions too. You get the rodata > > > protection and function local sco

Re: Re: Re: Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-28 Thread Joel Granados
On Mon, Jan 27, 2025 at 03:42:39PM +, Matthew Wilcox wrote: > On Mon, Jan 27, 2025 at 04:55:58PM +0200, Jani Nikula wrote: > > You could have static const within functions too. You get the rodata > > protection and function local scope, best of both worlds? > > timer_active is on the stack, so

Re: Re: Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-27 Thread Matthew Wilcox
On Mon, Jan 27, 2025 at 04:55:58PM +0200, Jani Nikula wrote: > You could have static const within functions too. You get the rodata > protection and function local scope, best of both worlds? timer_active is on the stack, so it can't be static const. Does this really need to be cc'd to such a wid

Re: Re: Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-27 Thread Jani Nikula
On Mon, 27 Jan 2025, Joel Granados wrote: > On Wed, Jan 22, 2025 at 01:41:35PM +0100, Ard Biesheuvel wrote: >> On Wed, 22 Jan 2025 at 13:25, Joel Granados wrote: >> > >> > On Tue, Jan 21, 2025 at 02:40:16PM +0100, Alexander Gordeev wrote: >> > > On Fri, Jan 10, 2025 at 03:16:08PM +0100, Joel Gran

Re: Re: Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-27 Thread Joel Granados
On Wed, Jan 22, 2025 at 01:41:35PM +0100, Ard Biesheuvel wrote: > On Wed, 22 Jan 2025 at 13:25, Joel Granados wrote: > > > > On Tue, Jan 21, 2025 at 02:40:16PM +0100, Alexander Gordeev wrote: > > > On Fri, Jan 10, 2025 at 03:16:08PM +0100, Joel Granados wrote: > > > > > > Hi Joel, > > > > > > > Ad