Re: [Xen-devel] [PATCH v6 5/6] xen/x86: add PHYSDEVOP_interrupt_control

2019-09-23 Thread Roger Pau Monné
On Fri, Sep 20, 2019 at 06:02:50PM +0200, Marek Marczykowski-Górecki wrote: > On Fri, Sep 20, 2019 at 12:10:09PM +0200, Jan Beulich wrote: > > On 14.09.2019 17:37, Marek Marczykowski-Górecki wrote: > > > Allow device model running in stubdomain to enable/disable INTx/MSI(-X), > > > bypassing pciba

Re: [Xen-devel] [PATCH v6 5/6] xen/x86: add PHYSDEVOP_interrupt_control

2019-09-23 Thread Marek Marczykowski-Górecki
On Mon, Sep 23, 2019 at 03:02:49PM +0200, Jan Beulich wrote: > On 23.09.2019 14:25, Marek Marczykowski-Górecki wrote: > > What about this: HVM guest can already do all of this when qemu is > > running in dom0. So, allowing those actions when qemu is running in > > stubdomain should not introduce _

Re: [Xen-devel] [PATCH v6 5/6] xen/x86: add PHYSDEVOP_interrupt_control

2019-09-23 Thread Jan Beulich
On 23.09.2019 14:25, Marek Marczykowski-Górecki wrote: > What about this: HVM guest can already do all of this when qemu is > running in dom0. So, allowing those actions when qemu is running in > stubdomain should not introduce _additional_ risks. Well, in a way - yes. But I don't think it's righ

Re: [Xen-devel] [PATCH v6 5/6] xen/x86: add PHYSDEVOP_interrupt_control

2019-09-23 Thread Marek Marczykowski-Górecki
On Mon, Sep 23, 2019 at 02:05:58PM +0200, Jan Beulich wrote: > On 23.09.2019 12:47, Marek Marczykowski-Górecki wrote: > > On Mon, Sep 23, 2019 at 09:58:27AM +0200, Jan Beulich wrote: > >> On 20.09.2019 18:02, Marek Marczykowski-Górecki wrote: > >>> Anyway, if you all agree that pciback should be

Re: [Xen-devel] [PATCH v6 5/6] xen/x86: add PHYSDEVOP_interrupt_control

2019-09-23 Thread Jan Beulich
On 23.09.2019 12:47, Marek Marczykowski-Górecki wrote: > On Mon, Sep 23, 2019 at 09:58:27AM +0200, Jan Beulich wrote: >> On 20.09.2019 18:02, Marek Marczykowski-Górecki wrote: >>> Anyway, if you all agree that pciback should be the way to go, I can go >>> that route too. In practice, it would be

Re: [Xen-devel] [PATCH v6 5/6] xen/x86: add PHYSDEVOP_interrupt_control

2019-09-23 Thread Marek Marczykowski-Górecki
On Mon, Sep 23, 2019 at 09:58:27AM +0200, Jan Beulich wrote: > On 20.09.2019 18:02, Marek Marczykowski-Górecki wrote: > > On Fri, Sep 20, 2019 at 12:10:09PM +0200, Jan Beulich wrote: > >> On 14.09.2019 17:37, Marek Marczykowski-Górecki wrote: > >>> Allow device model running in stubdomain to enab

Re: [Xen-devel] [PATCH v6 5/6] xen/x86: add PHYSDEVOP_interrupt_control

2019-09-23 Thread Jan Beulich
On 20.09.2019 18:02, Marek Marczykowski-Górecki wrote: > On Fri, Sep 20, 2019 at 12:10:09PM +0200, Jan Beulich wrote: >> On 14.09.2019 17:37, Marek Marczykowski-Górecki wrote: >>> Allow device model running in stubdomain to enable/disable INTx/MSI(-X), >>> bypassing pciback. While pciback is stil

Re: [Xen-devel] [PATCH v6 5/6] xen/x86: add PHYSDEVOP_interrupt_control

2019-09-20 Thread Marek Marczykowski-Górecki
On Fri, Sep 20, 2019 at 12:10:09PM +0200, Jan Beulich wrote: > On 14.09.2019 17:37, Marek Marczykowski-Górecki wrote: > > Allow device model running in stubdomain to enable/disable INTx/MSI(-X), > > bypassing pciback. While pciback is still used to access config space > > from within stubdomain, i

Re: [Xen-devel] [PATCH v6 5/6] xen/x86: add PHYSDEVOP_interrupt_control

2019-09-20 Thread Jan Beulich
On 14.09.2019 17:37, Marek Marczykowski-Górecki wrote: > Allow device model running in stubdomain to enable/disable INTx/MSI(-X), > bypassing pciback. While pciback is still used to access config space > from within stubdomain, it refuse to write to > PCI_MSI_FLAGS_ENABLE/PCI_MSIX_FLAGS_ENABLE/PCI