Re: [Xen-devel] [PATCH v5 5/6] xen/x86: add PHYSDEVOP_msi_control

2019-08-06 Thread Roger Pau Monné
On Tue, Aug 06, 2019 at 02:43:49PM +0200, Marek Marczykowski-Górecki wrote: > On Tue, Aug 06, 2019 at 02:05:48PM +0200, Jan Beulich wrote: > > On 06.08.2019 12:53, Marek Marczykowski-Górecki wrote: > > > On Tue, Aug 06, 2019 at 12:33:39PM +0200, Jan Beulich wrote: > > > > On 06.08.2019 11:46, Mare

Re: [Xen-devel] [PATCH v5 5/6] xen/x86: add PHYSDEVOP_msi_control

2019-08-06 Thread Jan Beulich
On 06.08.2019 14:43, Marek Marczykowski-Górecki wrote: On Tue, Aug 06, 2019 at 02:05:48PM +0200, Jan Beulich wrote: On 06.08.2019 12:53, Marek Marczykowski-Górecki wrote: On Tue, Aug 06, 2019 at 12:33:39PM +0200, Jan Beulich wrote: On 06.08.2019 11:46, Marek Marczykowski-Górecki wrote: On

Re: [Xen-devel] [PATCH v5 5/6] xen/x86: add PHYSDEVOP_msi_control

2019-08-06 Thread Marek Marczykowski-Górecki
On Tue, Aug 06, 2019 at 02:05:48PM +0200, Jan Beulich wrote: > On 06.08.2019 12:53, Marek Marczykowski-Górecki wrote: > > On Tue, Aug 06, 2019 at 12:33:39PM +0200, Jan Beulich wrote: > > > On 06.08.2019 11:46, Marek Marczykowski-Górecki wrote: > > > > On Tue, Aug 06, 2019 at 07:56:39AM +, Jan

Re: [Xen-devel] [PATCH v5 5/6] xen/x86: add PHYSDEVOP_msi_control

2019-08-06 Thread Jan Beulich
On 06.08.2019 12:53, Marek Marczykowski-Górecki wrote: On Tue, Aug 06, 2019 at 12:33:39PM +0200, Jan Beulich wrote: On 06.08.2019 11:46, Marek Marczykowski-Górecki wrote: On Tue, Aug 06, 2019 at 07:56:39AM +, Jan Beulich wrote: On 05.08.2019 15:44, Marek Marczykowski-Górecki wrote: I'm

Re: [Xen-devel] [PATCH v5 5/6] xen/x86: add PHYSDEVOP_msi_control

2019-08-06 Thread Marek Marczykowski-Górecki
On Tue, Aug 06, 2019 at 12:33:39PM +0200, Jan Beulich wrote: > On 06.08.2019 11:46, Marek Marczykowski-Górecki wrote: > > On Tue, Aug 06, 2019 at 07:56:39AM +, Jan Beulich wrote: > > > On 05.08.2019 15:44, Marek Marczykowski-Górecki wrote: > > > > On Fri, Jul 19, 2019 at 09:43:26AM +, Jan

Re: [Xen-devel] [PATCH v5 5/6] xen/x86: add PHYSDEVOP_msi_control

2019-08-06 Thread Jan Beulich
On 06.08.2019 11:46, Marek Marczykowski-Górecki wrote: On Tue, Aug 06, 2019 at 07:56:39AM +, Jan Beulich wrote: On 05.08.2019 15:44, Marek Marczykowski-Górecki wrote: On Fri, Jul 19, 2019 at 09:43:26AM +, Jan Beulich wrote: On 19.07.2019 11:02, Roger Pau Monné wrote: On Fri, Jul 19

Re: [Xen-devel] [PATCH v5 5/6] xen/x86: add PHYSDEVOP_msi_control

2019-08-06 Thread Marek Marczykowski-Górecki
On Tue, Aug 06, 2019 at 07:56:39AM +, Jan Beulich wrote: > On 05.08.2019 15:44, Marek Marczykowski-Górecki wrote: > > On Fri, Jul 19, 2019 at 09:43:26AM +, Jan Beulich wrote: > >> On 19.07.2019 11:02, Roger Pau Monné wrote: > >>> On Fri, Jul 19, 2019 at 08:04:45AM +, Jan Beulich wrote

Re: [Xen-devel] [PATCH v5 5/6] xen/x86: add PHYSDEVOP_msi_control

2019-08-06 Thread Jan Beulich
On 05.08.2019 15:44, Marek Marczykowski-Górecki wrote: > On Fri, Jul 19, 2019 at 09:43:26AM +, Jan Beulich wrote: >> On 19.07.2019 11:02, Roger Pau Monné wrote: >>> On Fri, Jul 19, 2019 at 08:04:45AM +, Jan Beulich wrote: On 18.07.2019 18:52, Roger Pau Monné wrote: > On Thu, Jul

Re: [Xen-devel] [PATCH v5 5/6] xen/x86: add PHYSDEVOP_msi_control

2019-08-05 Thread Marek Marczykowski-Górecki
On Fri, Jul 19, 2019 at 09:43:26AM +, Jan Beulich wrote: > On 19.07.2019 11:02, Roger Pau Monné wrote: > > On Fri, Jul 19, 2019 at 08:04:45AM +, Jan Beulich wrote: > >> On 18.07.2019 18:52, Roger Pau Monné wrote: > >>> On Thu, Jul 18, 2019 at 03:17:27PM +, Jan Beulich wrote: > On

Re: [Xen-devel] [PATCH v5 5/6] xen/x86: add PHYSDEVOP_msi_control

2019-07-19 Thread Jan Beulich
On 17.07.2019 03:00, Marek Marczykowski-Górecki wrote: > --- a/xen/arch/x86/physdev.c > +++ b/xen/arch/x86/physdev.c > @@ -662,6 +662,31 @@ ret_t do_physdev_op(int cmd, > XEN_GUEST_HANDLE_PARAM(void) arg) > break; > } > > +case PHYSDEVOP_msi_control: { > +struct phy

Re: [Xen-devel] [PATCH v5 5/6] xen/x86: add PHYSDEVOP_msi_control

2019-07-19 Thread Jan Beulich
On 19.07.2019 11:02, Roger Pau Monné wrote: > On Fri, Jul 19, 2019 at 08:04:45AM +, Jan Beulich wrote: >> On 18.07.2019 18:52, Roger Pau Monné wrote: >>> On Thu, Jul 18, 2019 at 03:17:27PM +, Jan Beulich wrote: On 18.07.2019 15:46, Roger Pau Monné wrote: > In fact I don't think

Re: [Xen-devel] [PATCH v5 5/6] xen/x86: add PHYSDEVOP_msi_control

2019-07-19 Thread Roger Pau Monné
On Fri, Jul 19, 2019 at 08:04:45AM +, Jan Beulich wrote: > On 18.07.2019 18:52, Roger Pau Monné wrote: > > On Thu, Jul 18, 2019 at 03:17:27PM +, Jan Beulich wrote: > >> On 18.07.2019 15:46, Roger Pau Monné wrote: > >>> In fact I don't think INTx should be enabled when MSI(-X) is disabled,

Re: [Xen-devel] [PATCH v5 5/6] xen/x86: add PHYSDEVOP_msi_control

2019-07-19 Thread Jan Beulich
On 18.07.2019 18:52, Roger Pau Monné wrote: > On Thu, Jul 18, 2019 at 03:17:27PM +, Jan Beulich wrote: >> On 18.07.2019 15:46, Roger Pau Monné wrote: >>> In fact I don't think INTx should be enabled when MSI(-X) is disabled, >>> QEMU already traps writes to the command register, and it will m

Re: [Xen-devel] [PATCH v5 5/6] xen/x86: add PHYSDEVOP_msi_control

2019-07-18 Thread Roger Pau Monné
On Thu, Jul 18, 2019 at 03:17:27PM +, Jan Beulich wrote: > On 18.07.2019 15:46, Roger Pau Monné wrote: > > In fact I don't think INTx should be enabled when MSI(-X) is disabled, > > QEMU already traps writes to the command register, and it will manage > > INTx enabling/disabling by itself. I t

Re: [Xen-devel] [PATCH v5 5/6] xen/x86: add PHYSDEVOP_msi_control

2019-07-18 Thread Jan Beulich
On 18.07.2019 15:46, Roger Pau Monné wrote: > In fact I don't think INTx should be enabled when MSI(-X) is disabled, > QEMU already traps writes to the command register, and it will manage > INTx enabling/disabling by itself. I think the only check required is > that MSI(-X) cannot be enabled if I

Re: [Xen-devel] [PATCH v5 5/6] xen/x86: add PHYSDEVOP_msi_control

2019-07-18 Thread Roger Pau Monné
On Thu, Jul 18, 2019 at 01:54:26AM +0200, Marek Marczykowski-Górecki wrote: > On Wed, Jul 17, 2019 at 12:18:43PM +0200, Roger Pau Monné wrote: > > On Wed, Jul 17, 2019 at 03:00:43AM +0200, Marek Marczykowski-Górecki wrote: > > > Allow device model running in stubdomain to enable/disable MSI(-X), >

Re: [Xen-devel] [PATCH v5 5/6] xen/x86: add PHYSDEVOP_msi_control

2019-07-17 Thread Marek Marczykowski-Górecki
On Wed, Jul 17, 2019 at 12:18:43PM +0200, Roger Pau Monné wrote: > On Wed, Jul 17, 2019 at 03:00:43AM +0200, Marek Marczykowski-Górecki wrote: > > Allow device model running in stubdomain to enable/disable MSI(-X), > > bypassing pciback. While pciback is still used to access config space > > from w

Re: [Xen-devel] [PATCH v5 5/6] xen/x86: add PHYSDEVOP_msi_control

2019-07-17 Thread Roger Pau Monné
On Wed, Jul 17, 2019 at 03:00:43AM +0200, Marek Marczykowski-Górecki wrote: > Allow device model running in stubdomain to enable/disable MSI(-X), > bypassing pciback. While pciback is still used to access config space > from within stubdomain, it refuse to write to > PCI_MSI_FLAGS_ENABLE/PCI_MSIX_F