Re: [Xen-devel] [PATCH v4 6/6] x86/microcode: Synchronize late microcode loading

2019-01-15 Thread Roger Pau Monné
On Tue, Jan 15, 2019 at 03:24:31PM +, Andrew Cooper wrote: > On 30/11/2018 09:01, Chao Gao wrote: > > On Thu, Nov 29, 2018 at 10:56:53AM +0100, Roger Pau Monné wrote: > >> On Thu, Nov 29, 2018 at 12:43:25PM +0800, Chao Gao wrote: > >>> On Wed, Nov 28, 2018 at 04:22:09PM +0100, Roger Pau Monné w

Re: [Xen-devel] [PATCH v4 6/6] x86/microcode: Synchronize late microcode loading

2019-01-15 Thread Andrew Cooper
On 30/11/2018 09:01, Chao Gao wrote: > On Thu, Nov 29, 2018 at 10:56:53AM +0100, Roger Pau Monné wrote: >> On Thu, Nov 29, 2018 at 12:43:25PM +0800, Chao Gao wrote: >>> On Wed, Nov 28, 2018 at 04:22:09PM +0100, Roger Pau Monné wrote: On Wed, Nov 28, 2018 at 01:34:16PM +0800, Chao Gao wrote: >>

Re: [Xen-devel] [PATCH v4 6/6] x86/microcode: Synchronize late microcode loading

2018-12-12 Thread Boris Ostrovsky
On 12/12/18 2:26 AM, Jan Beulich wrote: On 11.12.18 at 19:16, wrote: >> BTW: Apart from the fact its ugly and take a lng time to complete, do you >> have any practical isssues you want to highlight? maybe that can >> help upstream as well. > The situation for a kernel and a hypervisor mi

Re: [Xen-devel] [PATCH v4 6/6] x86/microcode: Synchronize late microcode loading

2018-12-11 Thread Jan Beulich
>>> On 11.12.18 at 19:16, wrote: > BTW: Apart from the fact its ugly and take a lng time to complete, do you > have any practical isssues you want to highlight? maybe that can > help upstream as well. The situation for a kernel and a hypervisor might be different here (but in the Linux case

Re: [Xen-devel] [PATCH v4 6/6] x86/microcode: Synchronize late microcode loading

2018-12-11 Thread Chao Gao
On Tue, Dec 11, 2018 at 10:01:11AM -0700, Jan Beulich wrote: On 28.11.18 at 06:34, wrote: >> This patch ports microcode improvement patches from linux kernel. >> >> Before you read any further: the early loading method is still the >> preferred one and you should always do that. The followin

Re: [Xen-devel] [PATCH v4 6/6] x86/microcode: Synchronize late microcode loading

2018-12-11 Thread Raj, Ashok
On Tue, Dec 11, 2018 at 10:01:11AM -0700, Jan Beulich wrote: > >>> On 28.11.18 at 06:34, wrote: > > This patch ports microcode improvement patches from linux kernel. > > > > Before you read any further: the early loading method is still the > > preferred one and you should always do that. The fol

Re: [Xen-devel] [PATCH v4 6/6] x86/microcode: Synchronize late microcode loading

2018-12-11 Thread Jan Beulich
>>> On 28.11.18 at 06:34, wrote: > This patch ports microcode improvement patches from linux kernel. > > Before you read any further: the early loading method is still the > preferred one and you should always do that. The following patch is > improving the late loading mechanism for long running

Re: [Xen-devel] [PATCH v4 6/6] x86/microcode: Synchronize late microcode loading

2018-11-30 Thread Boris Ostrovsky
On 11/30/18 4:46 AM, Jan Beulich wrote: On 29.11.18 at 23:43, wrote: >> One other comment about this patch (which IIRC was raised by Andrew on >> an earlier version) is that it may be worth to stop timer calibration. I >> am pretty sure we've seen deadlocks, which is why we ended up disabling

Re: [Xen-devel] [PATCH v4 6/6] x86/microcode: Synchronize late microcode loading

2018-11-30 Thread Jan Beulich
>>> On 29.11.18 at 23:43, wrote: > One other comment about this patch (which IIRC was raised by Andrew on > an earlier version) is that it may be worth to stop timer calibration. I > am pretty sure we've seen deadlocks, which is why we ended up disabling > it during microcode updates. I recall th

Re: [Xen-devel] [PATCH v4 6/6] x86/microcode: Synchronize late microcode loading

2018-11-30 Thread Chao Gao
On Thu, Nov 29, 2018 at 10:56:53AM +0100, Roger Pau Monné wrote: >On Thu, Nov 29, 2018 at 12:43:25PM +0800, Chao Gao wrote: >> On Wed, Nov 28, 2018 at 04:22:09PM +0100, Roger Pau Monné wrote: >> >On Wed, Nov 28, 2018 at 01:34:16PM +0800, Chao Gao wrote: >> >> This patch ports microcode improvement

Re: [Xen-devel] [PATCH v4 6/6] x86/microcode: Synchronize late microcode loading

2018-11-29 Thread Boris Ostrovsky
On 11/29/18 4:56 AM, Roger Pau Monné wrote: > On Thu, Nov 29, 2018 at 12:43:25PM +0800, Chao Gao wrote: >> On Wed, Nov 28, 2018 at 04:22:09PM +0100, Roger Pau Monné wrote: >>> On Wed, Nov 28, 2018 at 01:34:16PM +0800, Chao Gao wrote: >>> @@ -311,13 +350,45 @@ int microcode_update(XEN_GUE

Re: [Xen-devel] [PATCH v4 6/6] x86/microcode: Synchronize late microcode loading

2018-11-29 Thread Roger Pau Monné
On Thu, Nov 29, 2018 at 12:43:25PM +0800, Chao Gao wrote: > On Wed, Nov 28, 2018 at 04:22:09PM +0100, Roger Pau Monné wrote: > >On Wed, Nov 28, 2018 at 01:34:16PM +0800, Chao Gao wrote: > >> This patch ports microcode improvement patches from linux kernel. > >> > >> Before you read any further: th

Re: [Xen-devel] [PATCH v4 6/6] x86/microcode: Synchronize late microcode loading

2018-11-28 Thread Chao Gao
On Wed, Nov 28, 2018 at 04:22:09PM +0100, Roger Pau Monné wrote: >On Wed, Nov 28, 2018 at 01:34:16PM +0800, Chao Gao wrote: >> This patch ports microcode improvement patches from linux kernel. >> >> Before you read any further: the early loading method is still the >> preferred one and you should

Re: [Xen-devel] [PATCH v4 6/6] x86/microcode: Synchronize late microcode loading

2018-11-28 Thread Roger Pau Monné
On Wed, Nov 28, 2018 at 01:34:16PM +0800, Chao Gao wrote: > This patch ports microcode improvement patches from linux kernel. > > Before you read any further: the early loading method is still the > preferred one and you should always do that. The following patch is > improving the late loading me