Re: [Xen-devel] [PATCH v3 1/3] xen/flask: Drop the gen-policy.py script

2019-12-09 Thread Jan Beulich
On 09.12.2019 18:01, Andrew Cooper wrote: > On 09/12/2019 13:38, Jan Beulich wrote: >> On 07.12.2019 22:16, Andrew Cooper wrote: >>> --- /dev/null >>> +++ b/xen/xsm/flask/flask-policy.S >>> @@ -0,0 +1,20 @@ >>> +.section .init.rodata, "a", %progbits >>> + >>> +/* const unsigned char xsm_fla

Re: [Xen-devel] [PATCH v3 1/3] xen/flask: Drop the gen-policy.py script

2019-12-09 Thread Daniel De Graaf
On 12/7/19 4:16 PM, Andrew Cooper wrote: The script is Python 2 specific, and fails with string/binary issues with Python 3: Traceback (most recent call last): File "gen-policy.py", line 14, in for char in sys.stdin.read(): File "/usr/lib/python3.5/codecs.py", line 321, in d

Re: [Xen-devel] [PATCH v3 1/3] xen/flask: Drop the gen-policy.py script

2019-12-09 Thread Andrew Cooper
On 09/12/2019 13:38, Jan Beulich wrote: > On 07.12.2019 22:16, Andrew Cooper wrote: >> --- /dev/null >> +++ b/xen/xsm/flask/flask-policy.S >> @@ -0,0 +1,20 @@ >> +.section .init.rodata, "a", %progbits >> + >> +/* const unsigned char xsm_flask_init_policy[] __initconst */ >> +.align

Re: [Xen-devel] [PATCH v3 1/3] xen/flask: Drop the gen-policy.py script

2019-12-09 Thread Jan Beulich
On 07.12.2019 22:16, Andrew Cooper wrote: > --- /dev/null > +++ b/xen/xsm/flask/flask-policy.S > @@ -0,0 +1,20 @@ > +.section .init.rodata, "a", %progbits > + > +/* const unsigned char xsm_flask_init_policy[] __initconst */ > +.align 4 I'm afraid .align is not universal enough to b

Re: [Xen-devel] [PATCH v3 1/3] xen/flask: Drop the gen-policy.py script

2019-12-09 Thread George Dunlap
On Sat, Dec 7, 2019 at 9:17 PM Andrew Cooper wrote: > > The script is Python 2 specific, and fails with string/binary issues with > Python 3: > > Traceback (most recent call last): > File "gen-policy.py", line 14, in > for char in sys.stdin.read(): > File "/usr/lib/python3.5/codec