Re: [Xen-devel] [PATCH v2 3/3] x86emul: consolidate CR4 handling

2018-12-04 Thread Jan Beulich
>>> On 03.12.18 at 20:37, wrote: > On 06/11/2018 13:45, Jan Beulich wrote: >> Now that there's an almost unconditional CR4 read right at the beginning >> of x86_emulate(), centralize its reading there and use result and value >> everywhere else without further invoking the hook. >> >> Subsequently

Re: [Xen-devel] [PATCH v2 3/3] x86emul: consolidate CR4 handling

2018-12-03 Thread Andrew Cooper
On 06/11/2018 13:45, Jan Beulich wrote: > Now that there's an almost unconditional CR4 read right at the beginning > of x86_emulate(), centralize its reading there and use result and value > everywhere else without further invoking the hook. > > Subsequently we may want to consider having the calle