Re: [Xen-devel] [PATCH v2 10/10] xen: add cloc target

2018-05-24 Thread Stefano Stabellini
On Thu, 24 May 2018, Jan Beulich wrote: > >>> On 23.05.18 at 20:21, wrote: > > On Wed, 23 May 2018, Jan Beulich wrote: > >> >>> On 22.05.18 at 22:08, wrote: > >> > On Tue, 22 May 2018, Jan Beulich wrote: > >> >> >>> On 22.05.18 at 02:53, wrote: > >> >> > + $(eval tmpfile := $(shell mktemp))

Re: [Xen-devel] [PATCH v2 10/10] xen: add cloc target

2018-05-24 Thread Jan Beulich
>>> On 23.05.18 at 20:21, wrote: > On Wed, 23 May 2018, Jan Beulich wrote: >> >>> On 22.05.18 at 22:08, wrote: >> > On Tue, 22 May 2018, Jan Beulich wrote: >> >> >>> On 22.05.18 at 02:53, wrote: >> >> > + $(eval tmpfile := $(shell mktemp)) >> >> > + $(foreach f, $(shell find $(BASEDI

Re: [Xen-devel] [PATCH v2 10/10] xen: add cloc target

2018-05-23 Thread Stefano Stabellini
On Wed, 23 May 2018, Jan Beulich wrote: > >>> On 22.05.18 at 22:08, wrote: > > On Tue, 22 May 2018, Jan Beulich wrote: > >> >>> On 22.05.18 at 02:53, wrote: > >> > +$(eval tmpfile := $(shell mktemp)) > >> > +$(foreach f, $(shell find $(BASEDIR) -name *.o.d), \ > >> > +

Re: [Xen-devel] [PATCH v2 10/10] xen: add cloc target

2018-05-23 Thread Jan Beulich
>>> On 22.05.18 at 22:08, wrote: > On Tue, 22 May 2018, Jan Beulich wrote: >> >>> On 22.05.18 at 02:53, wrote: >> > + $(eval tmpfile := $(shell mktemp)) >> > + $(foreach f, $(shell find $(BASEDIR) -name *.o.d), \ >> > + $(eval path := $(dir $(f))) \ >> > + $(eval name := $(she

Re: [Xen-devel] [PATCH v2 10/10] xen: add cloc target

2018-05-22 Thread Stefano Stabellini
On Tue, 22 May 2018, Jan Beulich wrote: > >>> On 22.05.18 at 02:53, wrote: > > --- a/xen/Makefile > > +++ b/xen/Makefile > > @@ -267,3 +267,14 @@ $(KCONFIG_CONFIG): > > include/config/auto.conf.cmd: ; > > > > -include $(BASEDIR)/include/config/auto.conf.cmd > > + > > +.PHONY: cloc > > +cloc: b

Re: [Xen-devel] [PATCH v2 10/10] xen: add cloc target

2018-05-22 Thread Jan Beulich
>>> On 22.05.18 at 02:53, wrote: > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -267,3 +267,14 @@ $(KCONFIG_CONFIG): > include/config/auto.conf.cmd: ; > > -include $(BASEDIR)/include/config/auto.conf.cmd > + > +.PHONY: cloc > +cloc: build Not sure here - wouldn't it be reasonable to have no d