Re: [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion

2019-04-01 Thread HÃ¥kon Alstadheim
Den 01.04.2019 11:34, skrev Kevin Wolf: Yes, for 512 accesses on native 4k disks with O_DIRECT, the QEMU block layer performs the necessary RMW. Of course, it still comes with a performance penalty, so you want to avoid such setups, but they do work. I suspect that the approximately 1/10 -th

Re: [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion

2019-04-01 Thread Paul Durrant
> -Original Message- [snip] > > > > > > The old implementation has the sector size hardcoded: > > > > > > #define BLOCK_SIZE 512 > > > > > > Whereas the qdevified version uses DEFINE_BLOCK_PROPERTIES(), which > > > includes user-visible options for logical/physical_block_size. > > > >

Re: [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion

2019-04-01 Thread Kevin Wolf
roject.org; qemu-bl...@nongnu.org; qemu-de...@nongnu.org; > > Stefano Stabellini > > ; Max Reitz ; Stefan Hajnoczi > > > > Subject: Re: [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion > > > > Am 28.03.2019 um 12:46 hat Andrew Cooper geschrieben:

Re: [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion

2019-04-01 Thread Paul Durrant
Max Reitz ; Stefan Hajnoczi > > Subject: Re: [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion > > Am 28.03.2019 um 12:46 hat Andrew Cooper geschrieben: > > On 28/03/2019 11:40, Anthony PERARD wrote: > > > On Wed, Mar 27, 2019 at 08:32:28PM +0

Re: [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion

2019-04-01 Thread Paul Durrant
r > >>> Sent: 27 March 2019 18:20 > >>> To: Paul Durrant ; > >>> xen-devel@lists.xenproject.org; qemu-bl...@nongnu.org; > >>> qemu-de...@nongnu.org > >>> Cc: Kevin Wolf ; Stefano Stabellini > >>> ; Max Reitz > >>> ; S

Re: [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion

2019-03-28 Thread Kevin Wolf
:20 > >>> To: Paul Durrant ; > >>> xen-devel@lists.xenproject.org; qemu-bl...@nongnu.org; > >>> qemu-de...@nongnu.org > >>> Cc: Kevin Wolf ; Stefano Stabellini > >>> ; Max Reitz > >>> ; Stefan Hajnoczi ; Anthony > >>

Re: [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion

2019-03-28 Thread Andrew Cooper
>>> qemu-bl...@nongnu.org; >>> qemu-de...@nongnu.org >>> Cc: Kevin Wolf ; Stefano Stabellini >>> ; Max Reitz >>> ; Stefan Hajnoczi ; Anthony Perard >>> >>> Subject: Re: [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion >>>

Re: [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion

2019-03-28 Thread Anthony PERARD
; > Cc: Kevin Wolf ; Stefano Stabellini > > ; Max Reitz > > ; Stefan Hajnoczi ; Anthony Perard > > > > Subject: Re: [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion > > > > On 27/03/2019 17:32, Paul Durrant wrote: > > > The Xen blkif p

Re: [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion

2019-03-27 Thread Paul Durrant
ard > > Subject: Re: [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion > > On 27/03/2019 17:32, Paul Durrant wrote: > > The Xen blkif protocol is confusing but discussion with the maintainer > > has clarified that sector based quantities in requests and th

Re: [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion

2019-03-27 Thread Andrew Cooper
On 27/03/2019 17:32, Paul Durrant wrote: > The Xen blkif protocol is confusing but discussion with the maintainer > has clarified that sector based quantities in requests and the 'sectors' > value advertized in xenstore should always be in terms of 512-byte > units and not the advertised logical 's