Re: [Xen-devel] [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64

2019-06-17 Thread Christoph Hellwig
On Thu, Jun 13, 2019 at 05:00:57PM -0400, Konrad Rzeszutek Wilk wrote: > > As Christoph didn't react when I posted possible solutions I think I'll > > just modify patch 3 according to Jan's comment and post V3. > > OK, will await that patchset. Thank you! > > BTW, your patch #1 should be upstream

Re: [Xen-devel] [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64

2019-06-13 Thread Konrad Rzeszutek Wilk
> > > > #2 patch says: > > > > "> To be symmetric with setting the flag only after having made the > > region > > > contiguous, and to avoid (perhaps just theoretical) races, wouldn't > > it be > > > better to clear the flag before calling > > xen_destroy_contiguous_region()? > >

Re: [Xen-devel] [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64

2019-06-13 Thread Juergen Gross
On 13.06.19 16:23, Konrad Rzeszutek Wilk wrote: On Wed, Jun 05, 2019 at 04:24:06PM +0200, Juergen Gross wrote: On 05.06.19 16:13, Konrad Rzeszutek Wilk wrote: On Tue, Jun 04, 2019 at 03:41:40PM -0400, Boris Ostrovsky wrote: On 6/4/19 12:51 PM, Stefano Stabellini wrote: On Mon, 3 Jun 2019, Bor

Re: [Xen-devel] [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64

2019-06-13 Thread Konrad Rzeszutek Wilk
On Wed, Jun 05, 2019 at 04:24:06PM +0200, Juergen Gross wrote: > On 05.06.19 16:13, Konrad Rzeszutek Wilk wrote: > > On Tue, Jun 04, 2019 at 03:41:40PM -0400, Boris Ostrovsky wrote: > > > On 6/4/19 12:51 PM, Stefano Stabellini wrote: > > > > On Mon, 3 Jun 2019, Boris Ostrovsky wrote: > > > > > On 6

Re: [Xen-devel] [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64

2019-06-05 Thread Juergen Gross
On 05.06.19 16:13, Konrad Rzeszutek Wilk wrote: On Tue, Jun 04, 2019 at 03:41:40PM -0400, Boris Ostrovsky wrote: On 6/4/19 12:51 PM, Stefano Stabellini wrote: On Mon, 3 Jun 2019, Boris Ostrovsky wrote: On 6/3/19 2:25 PM, Stefano Stabellini wrote: On Tue, 28 May 2019, Boris Ostrovsky wrote: O

Re: [Xen-devel] [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64

2019-06-05 Thread Konrad Rzeszutek Wilk
On Tue, Jun 04, 2019 at 03:41:40PM -0400, Boris Ostrovsky wrote: > On 6/4/19 12:51 PM, Stefano Stabellini wrote: > > On Mon, 3 Jun 2019, Boris Ostrovsky wrote: > >> On 6/3/19 2:25 PM, Stefano Stabellini wrote: > >>> On Tue, 28 May 2019, Boris Ostrovsky wrote: > On 5/28/19 6:48 PM, Stefano Stab

Re: [Xen-devel] [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64

2019-06-04 Thread Boris Ostrovsky
On 6/4/19 12:51 PM, Stefano Stabellini wrote: > On Mon, 3 Jun 2019, Boris Ostrovsky wrote: >> On 6/3/19 2:25 PM, Stefano Stabellini wrote: >>> On Tue, 28 May 2019, Boris Ostrovsky wrote: On 5/28/19 6:48 PM, Stefano Stabellini wrote: > From: Stefano Stabellini > > On arm64 swiotlb

Re: [Xen-devel] [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64

2019-06-04 Thread Stefano Stabellini
On Mon, 3 Jun 2019, Boris Ostrovsky wrote: > On 6/3/19 2:25 PM, Stefano Stabellini wrote: > > On Tue, 28 May 2019, Boris Ostrovsky wrote: > >> On 5/28/19 6:48 PM, Stefano Stabellini wrote: > >>> From: Stefano Stabellini > >>> > >>> On arm64 swiotlb is often (not always) already initialized by mem_

Re: [Xen-devel] [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64

2019-06-03 Thread Boris Ostrovsky
On 6/3/19 2:25 PM, Stefano Stabellini wrote: > On Tue, 28 May 2019, Boris Ostrovsky wrote: >> On 5/28/19 6:48 PM, Stefano Stabellini wrote: >>> From: Stefano Stabellini >>> >>> On arm64 swiotlb is often (not always) already initialized by mem_init. >>> We don't want to initialize it twice, which w

Re: [Xen-devel] [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64

2019-06-03 Thread Stefano Stabellini
On Tue, 28 May 2019, Boris Ostrovsky wrote: > On 5/28/19 6:48 PM, Stefano Stabellini wrote: > > From: Stefano Stabellini > > > > On arm64 swiotlb is often (not always) already initialized by mem_init. > > We don't want to initialize it twice, which would trigger a second > > memory allocation. Mor

Re: [Xen-devel] [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64

2019-05-28 Thread Boris Ostrovsky
On 5/28/19 6:48 PM, Stefano Stabellini wrote: > From: Stefano Stabellini > > On arm64 swiotlb is often (not always) already initialized by mem_init. > We don't want to initialize it twice, which would trigger a second > memory allocation. Moreover, the second memory pool is typically made of > hig