Re: [Xen-devel] [PATCH v2] SVM: limit GIF=0 region

2018-08-29 Thread Jan Beulich
>>> On 29.08.18 at 19:55, wrote: > On 29/08/18 07:26, Jan Beulich wrote: > On 29.08.18 at 01:06, wrote: >>> Furthermore, to fix LBR handling, the first thing I'd have to do is >>> revert this, so please leave it as it is. >> Mind being a little more specific as to the whys here? > > When vmc

Re: [Xen-devel] [PATCH v2] SVM: limit GIF=0 region

2018-08-29 Thread Andrew Cooper
On 29/08/18 07:26, Jan Beulich wrote: On 29.08.18 at 01:06, wrote: >> On 15/08/18 07:09, Jan Beulich wrote: >>> @@ -96,13 +101,12 @@ __UNLIKELY_END(nsvm_hap) >>> SPEC_CTRL_ENTRY_FROM_HVM/* Req: b=curr %rsp=regs/cpuinfo, >>> Clob: acd */ >>> /* WARNING! `ret`, `call *`,

Re: [Xen-devel] [PATCH v2] SVM: limit GIF=0 region

2018-08-28 Thread Jan Beulich
>>> On 29.08.18 at 01:06, wrote: > On 15/08/18 07:09, Jan Beulich wrote: >> @@ -96,13 +101,12 @@ __UNLIKELY_END(nsvm_hap) >> SPEC_CTRL_ENTRY_FROM_HVM/* Req: b=curr %rsp=regs/cpuinfo, Clob: >> acd */ >> /* WARNING! `ret`, `call *`, `jmp *` not safe before this point. */ >>

Re: [Xen-devel] [PATCH v2] SVM: limit GIF=0 region

2018-08-28 Thread Andrew Cooper
On 15/08/18 07:09, Jan Beulich wrote: > Use EFLAGS.IF for all ordinary purposes; there's in particular no need > to unduly defer NMI/#MC. Clear/set GIF solely around VMRUN itself. This > has the additional advantage that svm_stgi_label now indeed marks the > only place where GIF gets set. > > A not

Re: [Xen-devel] [PATCH v2] SVM: limit GIF=0 region

2018-08-28 Thread Boris Ostrovsky
On 08/15/2018 02:09 AM, Jan Beulich wrote: > Use EFLAGS.IF for all ordinary purposes; there's in particular no need > to unduly defer NMI/#MC. Clear/set GIF solely around VMRUN itself. This > has the additional advantage that svm_stgi_label now indeed marks the > only place where GIF gets set. > >