Re: [Xen-devel] [PATCH for-next RFC 3/4] pygrub: convert python files with 2to3

2019-03-06 Thread Wei Liu
On Wed, Mar 06, 2019 at 11:46:24AM +, Andrew Cooper wrote: > On 06/03/2019 11:31, Wei Liu wrote: > > On Tue, Mar 05, 2019 at 05:51:04PM +, Andrew Cooper wrote: > >> On 05/03/2019 16:42, Wei Liu wrote: > >>> Signed-off-by: Wei Liu > >>> --- > >>> Not sure this works with python 2.4, but it

Re: [Xen-devel] [PATCH for-next RFC 3/4] pygrub: convert python files with 2to3

2019-03-06 Thread Andrew Cooper
On 06/03/2019 11:31, Wei Liu wrote: > On Tue, Mar 05, 2019 at 05:51:04PM +, Andrew Cooper wrote: >> On 05/03/2019 16:42, Wei Liu wrote: >>> Signed-off-by: Wei Liu >>> --- >>> Not sure this works with python 2.4, but it should work with 2.7 since >>> the changes look more or less in the same ve

Re: [Xen-devel] [PATCH for-next RFC 3/4] pygrub: convert python files with 2to3

2019-03-06 Thread Wei Liu
On Tue, Mar 05, 2019 at 05:51:04PM +, Andrew Cooper wrote: > On 05/03/2019 16:42, Wei Liu wrote: > > Signed-off-by: Wei Liu > > --- > > Not sure this works with python 2.4, but it should work with 2.7 since > > the changes look more or less in the same vein as the changes in > > libxl. > > > >

Re: [Xen-devel] [PATCH for-next RFC 3/4] pygrub: convert python files with 2to3

2019-03-05 Thread Andrew Cooper
On 05/03/2019 16:42, Wei Liu wrote: > Signed-off-by: Wei Liu > --- > Not sure this works with python 2.4, but it should work with 2.7 since > the changes look more or less in the same vein as the changes in > libxl. > > The conversion of the import is interesting. This definitely needs > some test