Re: [Xen-devel] [PATCH 8/9] vm_event: Add vm_event_ng interface

2019-06-06 Thread Jan Beulich
>>> On 06.06.19 at 15:48, wrote: > On Thu, 2019-06-06 at 02:37 -0600, Jan Beulich wrote: >> In which case maybe use vmalloc() and then assign_pages()? >> Jan > Unfortunately I wasn't able to make it work: > I replaced the buffer allocation with this code: > > impl->slots = vzalloc(impl->n

Re: [Xen-devel] [PATCH 8/9] vm_event: Add vm_event_ng interface

2019-06-06 Thread Petre Ovidiu PIRCALABU
On Thu, 2019-06-06 at 02:37 -0600, Jan Beulich wrote: > > > > On 05.06.19 at 19:01, wrote: > > > > On Tue, 2019-06-04 at 15:43 +0100, Andrew Cooper wrote: > > > On 30/05/2019 15:18, Petre Pircalabu wrote: > > > > +static int vm_event_channels_alloc_buffer(struct > > > > vm_event_channels_domain *

Re: [Xen-devel] [PATCH 8/9] vm_event: Add vm_event_ng interface

2019-06-06 Thread Jan Beulich
>>> On 05.06.19 at 19:01, wrote: > On Tue, 2019-06-04 at 15:43 +0100, Andrew Cooper wrote: >> On 30/05/2019 15:18, Petre Pircalabu wrote: >> > +static int vm_event_channels_alloc_buffer(struct >> > vm_event_channels_domain *impl) >> > +{ >> > +int i, rc = -ENOMEM; >> > + >> > +for ( i = 0;

Re: [Xen-devel] [PATCH 8/9] vm_event: Add vm_event_ng interface

2019-06-05 Thread Petre Ovidiu PIRCALABU
On Tue, 2019-06-04 at 15:43 +0100, Andrew Cooper wrote: > On 30/05/2019 15:18, Petre Pircalabu wrote: > > > > Signed-off-by: Petre Pircalabu > > There are a number of concerns here. > > First and foremost, why is a new domctl being added? Surely this > should > just be a "type of ring access"

Re: [Xen-devel] [PATCH 8/9] vm_event: Add vm_event_ng interface

2019-06-04 Thread Andrew Cooper
On 30/05/2019 15:18, Petre Pircalabu wrote: > In high throughput introspection scenarios where lots of monitor > vm_events are generated, the ring buffer can fill up before the monitor > application gets a chance to handle all the requests thus blocking > other vcpus which will have to wait for a s