Re: [Xen-devel] [PATCH 5/9] x86: relocate pvh_info

2018-01-19 Thread Jan Beulich
>>> On 19.01.18 at 11:53, wrote: > On Thu, Jan 18, 2018 at 06:16:48PM +, Wei Liu wrote: >> diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S >> index 0f652cea11..2f94c286d5 100644 >> --- a/xen/arch/x86/boot/head.S >> +++ b/xen/arch/x86/boot/head.S >> @@ -414,6 +414,7 @@ __pvh_st

Re: [Xen-devel] [PATCH 5/9] x86: relocate pvh_info

2018-01-19 Thread Roger Pau Monné
On Thu, Jan 18, 2018 at 06:16:48PM +, Wei Liu wrote: > diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S > index 0f652cea11..2f94c286d5 100644 > --- a/xen/arch/x86/boot/head.S > +++ b/xen/arch/x86/boot/head.S > @@ -414,6 +414,7 @@ __pvh_start: > > /* Set trampoline_phy

Re: [Xen-devel] [PATCH 5/9] x86: relocate pvh_info

2018-01-19 Thread Jan Beulich
>>> On 19.01.18 at 11:10, wrote: > On 18/01/18 18:16, Wei Liu wrote: >> Modify early boot code to relocate pvh info as well, so that we can be >> sure __va in __start_xen works. >> >> Signed-off-by: Wei Liu > > :( > > It was a fear of code like this which caused me to go with the gross > hack i

Re: [Xen-devel] [PATCH 5/9] x86: relocate pvh_info

2018-01-19 Thread Andrew Cooper
On 18/01/18 18:16, Wei Liu wrote: > Modify early boot code to relocate pvh info as well, so that we can be > sure __va in __start_xen works. > > Signed-off-by: Wei Liu :( It was a fear of code like this which caused me to go with the gross hack in the short term. Let me see if I can clean it up

Re: [Xen-devel] [PATCH 5/9] x86: relocate pvh_info

2018-01-19 Thread Jan Beulich
>>> On 18.01.18 at 19:16, wrote: > Modify early boot code to relocate pvh info as well, so that we can be > sure __va in __start_xen works. > > Signed-off-by: Wei Liu Reviewed-by: Jan Beulich with one cosmetic request: > @@ -29,6 +29,10 @@ asm ( > #include "../../../include/xen/multiboot.h"