> From: Andrew Cooper [mailto:andrew.coop...@citrix.com]
> Sent: Saturday, February 23, 2019 3:13 AM
>
> It is unclear why this abstraction exists, but iommu_qi_ctrl() returns
> possibly NULL and every user unconditionally dereferences the result. In
> practice, I can't spot a path where iommu is
>>> On 25.02.19 at 12:07, wrote:
> On 25/02/2019 10:59, Jan Beulich wrote:
> On 25.02.19 at 11:02, wrote:
From: Andrew Cooper [mailto:andrew.coop...@citrix.com]
Sent: 22 February 2019 19:13
--- a/xen/drivers/passthrough/vtd/qinval.c
+++ b/xen/drivers/passthrough/vtd/q
On 25/02/2019 10:59, Jan Beulich wrote:
On 25.02.19 at 11:02, wrote:
>>> From: Andrew Cooper [mailto:andrew.coop...@citrix.com]
>>> Sent: 22 February 2019 19:13
>>>
>>> --- a/xen/drivers/passthrough/vtd/qinval.c
>>> +++ b/xen/drivers/passthrough/vtd/qinval.c
>>> @@ -84,7 +84,7 @@ static int _
>>> On 25.02.19 at 11:02, wrote:
>> From: Andrew Cooper [mailto:andrew.coop...@citrix.com]
>> Sent: 22 February 2019 19:13
>>
>> --- a/xen/drivers/passthrough/vtd/qinval.c
>> +++ b/xen/drivers/passthrough/vtd/qinval.c
>> @@ -84,7 +84,7 @@ static int __must_check
>> queue_invalidate_context_sync(
> -Original Message-
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com]
> Sent: 22 February 2019 19:13
> To: Xen-devel
> Cc: Andrew Cooper ; Jan Beulich
> ; Paul Durrant
> ; Kevin Tian
> Subject: [PATCH 3/6] x86/vtd: Drop struct qi_ctrl
>
> It is unclear why this abstraction exist
