Re: [Xen-devel] [PATCH 29/57] ARM: new VGIC: Implement virtual IRQ injection

2018-03-07 Thread Julien Grall
Hi Andre, On 03/07/2018 11:22 AM, Andre Przywara wrote: On 07/03/18 11:02, Julien Grall wrote: Overall this patch looks good. Few comments below. On 03/05/2018 04:03 PM, Andre Przywara wrote: +/* + * Only valid injection if changing level for level-triggered IRQs or for a + * rising edge. + *

Re: [Xen-devel] [PATCH 29/57] ARM: new VGIC: Implement virtual IRQ injection

2018-03-07 Thread Andre Przywara
Hi, On 07/03/18 11:02, Julien Grall wrote: > Hi Andre, > > Overall this patch looks good. Few comments below. > > On 03/05/2018 04:03 PM, Andre Przywara wrote: >> +/* >> + * Only valid injection if changing level for level-triggered IRQs or >> for a >> + * rising edge. >> + */ >> +static bool vg

Re: [Xen-devel] [PATCH 29/57] ARM: new VGIC: Implement virtual IRQ injection

2018-03-07 Thread Julien Grall
Hi Andre, Overall this patch looks good. Few comments below. On 03/05/2018 04:03 PM, Andre Przywara wrote: +/* + * Only valid injection if changing level for level-triggered IRQs or for a + * rising edge. + */ +static bool vgic_validate_injection(struct vgic_irq *irq, bool level) +{ +if ( i