Re: [Xen-devel] [PATCH] x86/vvmx: set CR4 before CR0

2019-06-27 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Thursday, June 27, 2019 3:02 AM > > From: Sergey Dyasli > > Otherwise hvm_set_cr0() will check the wrong CR4 bits (L1 instead of L2 > and vice-versa). > > Signed-off-by: Sergey Dyasli > Reviewed-by: Andrew Cooper Acked-by: Kevi

Re: [Xen-devel] [PATCH] x86/vvmx: set CR4 before CR0

2019-06-27 Thread Andrew Cooper
On 27/06/2019 09:37, Roger Pau Monné wrote: > On Wed, Jun 26, 2019 at 08:02:12PM +0100, Andrew Cooper wrote: >> From: Sergey Dyasli >> >> Otherwise hvm_set_cr0() will check the wrong CR4 bits (L1 instead of L2 >> and vice-versa). >> >> Signed-off-by: Sergey Dyasli >> Reviewed-by: Andrew Cooper >

Re: [Xen-devel] [PATCH] x86/vvmx: set CR4 before CR0

2019-06-27 Thread Roger Pau Monné
On Wed, Jun 26, 2019 at 08:02:12PM +0100, Andrew Cooper wrote: > From: Sergey Dyasli > > Otherwise hvm_set_cr0() will check the wrong CR4 bits (L1 instead of L2 > and vice-versa). > > Signed-off-by: Sergey Dyasli > Reviewed-by: Andrew Cooper Reviewed-by: Roger Pau Monné > --- > CC: Jan Beul