Re: [Xen-devel] [PATCH] x86/link: Don't merge .init.text and .init.data

2018-02-27 Thread Jan Beulich
>>> On 26.02.18 at 20:01, wrote: >> Putting all init-time code and data in a single section is a perfectly >> valid thing to do imo. > > Having our debug symbols borderline unusable, isn't valid. > > Certainly not to work around what you yourself identify as a theoretical > issue in the first pl

Re: [Xen-devel] [PATCH] x86/link: Don't merge .init.text and .init.data

2018-02-26 Thread Andrew Cooper
On 12/01/18 16:05, Jan Beulich wrote: On 12.01.18 at 16:41, wrote: >> On 12/01/18 11:23, Jan Beulich wrote: >>> Even it you make .init.data its own section again, some >>> garbage will remain (mainly due to the trampoline data). >> That is far easier to spot an isolate, because it is tiny and

Re: [Xen-devel] [PATCH] x86/link: Don't merge .init.text and .init.data

2018-01-12 Thread Jan Beulich
>>> On 12.01.18 at 16:41, wrote: > On 12/01/18 11:23, Jan Beulich wrote: >> Even it you make .init.data its own section again, some >> garbage will remain (mainly due to the trampoline data). > > That is far easier to spot an isolate, because it is tiny and reasonably > obviously bounded. Well,

Re: [Xen-devel] [PATCH] x86/link: Don't merge .init.text and .init.data

2018-01-12 Thread Andrew Cooper
On 12/01/18 11:23, Jan Beulich wrote: On 11.01.18 at 15:17, wrote: >> c/s 1308f0170c merged .init.text and .init.data, because EFI might properly >> write-protect r/o sections. >> >> However, this change makes xen-syms unusable for disassembly analysis. In >> particular, searching for indire

Re: [Xen-devel] [PATCH] x86/link: Don't merge .init.text and .init.data

2018-01-12 Thread Jan Beulich
>>> On 11.01.18 at 15:17, wrote: > c/s 1308f0170c merged .init.text and .init.data, because EFI might properly > write-protect r/o sections. > > However, this change makes xen-syms unusable for disassembly analysis. In > particular, searching for indirect branches as part of the SP2/Spectre > mi

Re: [Xen-devel] [PATCH] x86/link: Don't merge .init.text and .init.data

2018-01-11 Thread Konrad Rzeszutek Wilk
On Thu, Jan 11, 2018 at 03:06:37PM +, Andrew Cooper wrote: > On 11/01/18 14:58, Konrad Rzeszutek Wilk wrote: > > On Thu, Jan 11, 2018 at 02:17:57PM +, Andrew Cooper wrote: > >> c/s 1308f0170c merged .init.text and .init.data, because EFI might properly > >> write-protect r/o sections. > >>

Re: [Xen-devel] [PATCH] x86/link: Don't merge .init.text and .init.data

2018-01-11 Thread Andrew Cooper
On 11/01/18 14:58, Konrad Rzeszutek Wilk wrote: > On Thu, Jan 11, 2018 at 02:17:57PM +, Andrew Cooper wrote: >> c/s 1308f0170c merged .init.text and .init.data, because EFI might properly >> write-protect r/o sections. >> >> However, this change makes xen-syms unusable for disassembly analysis.

Re: [Xen-devel] [PATCH] x86/link: Don't merge .init.text and .init.data

2018-01-11 Thread Konrad Rzeszutek Wilk
On Thu, Jan 11, 2018 at 02:17:57PM +, Andrew Cooper wrote: > c/s 1308f0170c merged .init.text and .init.data, because EFI might properly > write-protect r/o sections. > > However, this change makes xen-syms unusable for disassembly analysis. In s/this makes/that made/ > particular, searching