Re: [Xen-devel] [PATCH] trace: fix build with gcc9

2019-05-08 Thread George Dunlap
On 3/7/19 10:34 AM, Jan Beulich wrote: > While I've not observed this myself, gcc 9 (imo validly) reportedly may > complain > > trace.c: In function '__trace_hypercall': > trace.c:826:19: error: taking address of packed member of 'struct > ' may result in an unaligned pointer value > [-Werror=add

Re: [Xen-devel] [PATCH] trace: fix build with gcc9

2019-05-08 Thread Jan Beulich
>>> On 07.05.19 at 19:33, wrote: > On 3/8/19 12:14 PM, Jan Beulich wrote: > On 08.03.19 at 12:58, wrote: >>> If that’s the case, what about doing something like the attached instead? >>> It avoids introducing a not-very-obvious BUILD_BUG_ON(), and also I think >>> makes the algorithm a (ti

Re: [Xen-devel] [PATCH] trace: fix build with gcc9

2019-05-07 Thread George Dunlap
On 3/8/19 12:14 PM, Jan Beulich wrote: On 08.03.19 at 12:58, wrote: > >> >>> On Mar 8, 2019, at 7:11 AM, Jan Beulich wrote: >>> >> George Dunlap 03/07/19 1:02 PM >>> On 3/7/19 10:34 AM, Jan Beulich wrote: > While I've not observed this myself, gcc 9 (imo validly) reportedly ma

Re: [Xen-devel] [PATCH] trace: fix build with gcc9

2019-03-08 Thread Jan Beulich
>>> On 08.03.19 at 12:58, wrote: > >> On Mar 8, 2019, at 7:11 AM, Jan Beulich wrote: >> > George Dunlap 03/07/19 1:02 PM >>> >>> On 3/7/19 10:34 AM, Jan Beulich wrote: While I've not observed this myself, gcc 9 (imo validly) reportedly may complain trace.c: In functio

Re: [Xen-devel] [PATCH] trace: fix build with gcc9

2019-03-08 Thread George Dunlap
> On Mar 8, 2019, at 7:11 AM, Jan Beulich wrote: > George Dunlap 03/07/19 1:02 PM >>> >> On 3/7/19 10:34 AM, Jan Beulich wrote: >>> While I've not observed this myself, gcc 9 (imo validly) reportedly may >>> complain >>> >>> trace.c: In function '__trace_hypercall': >>> trace.c:826:19: e

Re: [Xen-devel] [PATCH] trace: fix build with gcc9

2019-03-07 Thread Jan Beulich
>>> George Dunlap 03/07/19 1:02 PM >>> >On 3/7/19 10:34 AM, Jan Beulich wrote: >> While I've not observed this myself, gcc 9 (imo validly) reportedly may >> complain >> >> trace.c: In function '__trace_hypercall': >> trace.c:826:19: error: taking address of packed member of 'struct >> ' may resu

Re: [Xen-devel] [PATCH] trace: fix build with gcc9

2019-03-07 Thread George Dunlap
On 3/7/19 10:34 AM, Jan Beulich wrote: > While I've not observed this myself, gcc 9 (imo validly) reportedly may > complain > > trace.c: In function '__trace_hypercall': > trace.c:826:19: error: taking address of packed member of 'struct > ' may result in an unaligned pointer value > [-Werror=add

Re: [Xen-devel] [PATCH] trace: fix build with gcc9

2019-03-07 Thread Jan Beulich
>>> On 07.03.19 at 12:40, wrote: > On 07/03/2019 10:34, Jan Beulich wrote: >> While I've not observed this myself, gcc 9 (imo validly) reportedly may >> complain >> >> trace.c: In function '__trace_hypercall': >> trace.c:826:19: error: taking address of packed member of 'struct >> ' may result in

Re: [Xen-devel] [PATCH] trace: fix build with gcc9

2019-03-07 Thread Andrew Cooper
On 07/03/2019 10:34, Jan Beulich wrote: > While I've not observed this myself, gcc 9 (imo validly) reportedly may > complain > > trace.c: In function '__trace_hypercall': > trace.c:826:19: error: taking address of packed member of 'struct > ' may result in an unaligned pointer value > [-Werror=add