Re: [Xen-devel] [PATCH] mm: make opt_bootscrub non-init

2018-11-26 Thread Jan Beulich
>>> On 26.11.18 at 13:49, wrote: > On Mon, Nov 26, 2018 at 05:18:20AM -0700, Jan Beulich wrote: >> Furthermore I doubt writing this down would help, because for >> such apparently simple things no-one goes hunt for related >> documentation. I think the only future proof course of action >> would b

Re: [Xen-devel] [PATCH] mm: make opt_bootscrub non-init

2018-11-26 Thread Roger Pau Monné
On Mon, Nov 26, 2018 at 05:18:20AM -0700, Jan Beulich wrote: > >>> On 26.11.18 at 13:04, wrote: > > On Mon, Nov 26, 2018 at 03:06:16AM -0700, Jan Beulich wrote: > >> >>> On 23.11.18 at 15:30, wrote: > >> > LLVM code generation can attempt to load from a variable in the next > >> > condition of an

Re: [Xen-devel] [PATCH] mm: make opt_bootscrub non-init

2018-11-26 Thread Jan Beulich
>>> On 26.11.18 at 13:25, wrote: > May I ask what are the downsides? Do you expect a lot of false positive? Having to split code paths, to introduce redundancy, or to move code/data out of .init.* that could in fact live there are all possible issues. Plus the __ref{,data} annotation that Linux h

Re: [Xen-devel] [PATCH] mm: make opt_bootscrub non-init

2018-11-26 Thread Julien Grall
Hi Jan, On 26/11/2018 12:18, Jan Beulich wrote: On 26.11.18 at 13:04, wrote: On Mon, Nov 26, 2018 at 03:06:16AM -0700, Jan Beulich wrote: On 23.11.18 at 15:30, wrote: LLVM code generation can attempt to load from a variable in the next condition of an expression under certain circumstances,

Re: [Xen-devel] [PATCH] mm: make opt_bootscrub non-init

2018-11-26 Thread Jan Beulich
>>> On 26.11.18 at 13:04, wrote: > On Mon, Nov 26, 2018 at 03:06:16AM -0700, Jan Beulich wrote: >> >>> On 23.11.18 at 15:30, wrote: >> > LLVM code generation can attempt to load from a variable in the next >> > condition of an expression under certain circumstances, thus turning >> > the followin

Re: [Xen-devel] [PATCH] mm: make opt_bootscrub non-init

2018-11-26 Thread Roger Pau Monné
On Mon, Nov 26, 2018 at 03:06:16AM -0700, Jan Beulich wrote: > >>> On 23.11.18 at 15:30, wrote: > > LLVM code generation can attempt to load from a variable in the next > > condition of an expression under certain circumstances, thus turning > > the following condition: > > > > if ( system_state

Re: [Xen-devel] [PATCH] mm: make opt_bootscrub non-init

2018-11-26 Thread Jan Beulich
>>> On 23.11.18 at 15:30, wrote: > LLVM code generation can attempt to load from a variable in the next > condition of an expression under certain circumstances, thus turning > the following condition: > > if ( system_state < SYS_STATE_active && opt_bootscrub == BOOTSCRUB_IDLE ) > > Into: > > 0

Re: [Xen-devel] [PATCH] mm: make opt_bootscrub non-init

2018-11-24 Thread Wei Liu
On Fri, Nov 23, 2018 at 03:30:02PM +0100, Roger Pau Monne wrote: > LLVM code generation can attempt to load from a variable in the next > condition of an expression under certain circumstances, thus turning > the following condition: > > if ( system_state < SYS_STATE_active && opt_bootscrub == BOO

Re: [Xen-devel] [PATCH] mm: make opt_bootscrub non-init

2018-11-23 Thread Sergey Dyasli
On 23/11/2018 14:30, Roger Pau Monne wrote: > LLVM code generation can attempt to load from a variable in the next > condition of an expression under certain circumstances, thus turning > the following condition: > > if ( system_state < SYS_STATE_active && opt_bootscrub == BOOTSCRUB_IDLE ) > > In

Re: [Xen-devel] [PATCH] mm: make opt_bootscrub non-init

2018-11-23 Thread Julien Grall
On 23/11/2018 14:30, Roger Pau Monne wrote: LLVM code generation can attempt to load from a variable in the next condition of an expression under certain circumstances, thus turning the following condition: if ( system_state < SYS_STATE_active && opt_bootscrub == BOOTSCRUB_IDLE ) Into: 0xfff

Re: [Xen-devel] [PATCH] mm: make opt_bootscrub non-init

2018-11-23 Thread Andrew Cooper
On 23/11/2018 14:30, Roger Pau Monne wrote: > LLVM code generation can attempt to load from a variable in the next > condition of an expression under certain circumstances, thus turning > the following condition: > > if ( system_state < SYS_STATE_active && opt_bootscrub == BOOTSCRUB_IDLE ) > > Into