Re: [Xen-devel] [PATCH] libxlu: Handle += in config files

2019-09-20 Thread Ian Jackson
Ian Jackson writes ("Re: [PATCH] libxlu: Handle += in config files"): > Anthony PERARD writes ("Re: [PATCH] libxlu: Handle += in config files"): > > I wonder if instead of doing += on all strings, we should instead have > > `xl' whitelist the few options where += would make sense. (and at that > >

Re: [Xen-devel] [PATCH] libxlu: Handle += in config files

2019-09-17 Thread Ian Jackson
Anthony PERARD writes ("Re: [PATCH] libxlu: Handle += in config files"): > I wonder if instead of doing += on all strings, we should instead have > `xl' whitelist the few options where += would make sense. (and at that > point, it would be easy to add a ' ' where is make sense, like > "cmdline"s. B

Re: [Xen-devel] [PATCH] libxlu: Handle += in config files

2019-08-16 Thread Anthony PERARD
On Fri, Aug 16, 2019 at 12:47:07PM +, Wei Liu wrote: > On Tue, Aug 13, 2019 at 05:42:15PM +0100, Anthony PERARD wrote: > > On Tue, Aug 13, 2019 at 04:47:23PM +0100, Andrew Cooper wrote: > > > Error between user and terminal. :) > > > > > > I'd sync'd xl and libxl.so, but not libxlu.so > > > >

Re: [Xen-devel] [PATCH] libxlu: Handle += in config files

2019-08-16 Thread Wei Liu
On Tue, Aug 13, 2019 at 05:42:15PM +0100, Anthony PERARD wrote: > On Tue, Aug 13, 2019 at 04:47:23PM +0100, Andrew Cooper wrote: > > Error between user and terminal. :) > > > > I'd sync'd xl and libxl.so, but not libxlu.so > > I actually made the same mistake first time I tried. > > > Ok, so tha

Re: [Xen-devel] [PATCH] libxlu: Handle += in config files

2019-08-13 Thread Anthony PERARD
On Tue, Aug 13, 2019 at 04:47:23PM +0100, Andrew Cooper wrote: > Error between user and terminal. :) > > I'd sync'd xl and libxl.so, but not libxlu.so I actually made the same mistake first time I tried. > Ok, so that is working now.  I think 'cmdline+=" dom0=pvh > dom0-iommu=none"' is slightly

Re: [Xen-devel] [PATCH] libxlu: Handle += in config files

2019-08-13 Thread Andrew Cooper
On 13/08/2019 16:30, Anthony PERARD wrote: > On Tue, Aug 13, 2019 at 04:06:33PM +0100, Andrew Cooper wrote: >> On 13/08/2019 15:48, Anthony PERARD wrote: >>> Handle += of both strings and lists. >>> >>> If += is used for config options expected to be numbers, then a >>> warning is printed and the c

Re: [Xen-devel] [PATCH] libxlu: Handle += in config files

2019-08-13 Thread Anthony PERARD
On Tue, Aug 13, 2019 at 04:06:33PM +0100, Andrew Cooper wrote: > On 13/08/2019 15:48, Anthony PERARD wrote: > > Handle += of both strings and lists. > > > > If += is used for config options expected to be numbers, then a > > warning is printed and the config option ignored (because xl ignores > > c

Re: [Xen-devel] [PATCH] libxlu: Handle += in config files

2019-08-13 Thread Andrew Cooper
On 13/08/2019 15:48, Anthony PERARD wrote: > Handle += of both strings and lists. > > If += is used for config options expected to be numbers, then a > warning is printed and the config option ignored (because xl ignores > config options with errors). > > This is to be used for development purposes