Re: [Xen-devel] [PATCH] libxl: made vm mac address assignment deterministic

2018-09-12 Thread George Dunlap
On 09/12/2018 10:54 AM, Marcus Granado wrote: >> Wei Liu writes ("Re: [PATCH] libxl: made vm mac address assignment >> deterministic"): >>> On Wed, Sep 05, 2018 at 12:25:55PM +, Joshua Perrett wrote: >>> > Uses MD5 on the host mac address, vm name and vif index to generate >>> the >>> > last th

Re: [Xen-devel] [PATCH] libxl: made vm mac address assignment deterministic

2018-09-12 Thread Marcus Granado
Wei Liu writes ("Re: [PATCH] libxl: made vm mac address assignment deterministic"): On Wed, Sep 05, 2018 at 12:25:55PM +, Joshua Perrett wrote: > Uses MD5 on the host mac address, vm name and vif index to generate the > last three bytes of the vm mac address (for each vm). There is no such

Re: [Xen-devel] [PATCH] libxl: made vm mac address assignment deterministic

2018-09-06 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH] libxl: made vm mac address assignment deterministic"): > On Wed, Sep 05, 2018 at 12:25:55PM +, Joshua Perrett wrote: > > Uses MD5 on the host mac address, vm name and vif index to generate the > > last three bytes of the vm mac address (for each vm). There is no s

Re: [Xen-devel] [PATCH] libxl: made vm mac address assignment deterministic

2018-09-06 Thread Wei Liu
On Wed, Sep 05, 2018 at 12:25:55PM +, Joshua Perrett wrote: > Uses MD5 on the host mac address, vm name and vif index to generate the > last three bytes of the vm mac address (for each vm). > > It uses the vif index to account for multiple vifs. > > MD5 code is originally from the public doma

Re: [Xen-devel] [PATCH] libxl: made vm mac address assignment deterministic

2018-08-31 Thread Wei Liu
On Thu, Aug 30, 2018 at 03:18:04PM +, Joshua Perrett wrote: > Uses MD5 on the host mac address, vm name and vif index to generate the > last three bytes of the vm mac address (for each vm). > > It uses the vif index to account for multiple vifs. > > MD5 code is originally from the public doma

Re: [Xen-devel] [PATCH] libxl: made vm mac address assignment deterministic

2018-08-30 Thread Wei Liu
Also CC George We had a race -- I commented on your patch on github. I will redo my review here. On Wed, Aug 29, 2018 at 04:34:28PM +, Joshua Perrett wrote: > Uses MD5 on the host mac address, vm name and vif index to generate the last > three > bytes of the vm mac address (for each vm). > I