Re: [Xen-devel] [PATCH] [v2] xen: avoid link error on ARM

2019-03-05 Thread Juergen Gross
On 05/03/2019 17:49, Arnd Bergmann wrote: > On Tue, Mar 5, 2019 at 3:57 PM Juergen Gross wrote: >> On 05/03/2019 14:43, Boris Ostrovsky wrote: >>> On 3/5/19 8:30 AM, Arnd Bergmann wrote: > @@ -809,15 +789,7 @@ static long privcmd_ioctl_mmap_resource(struct file *file, void __user *udat

Re: [Xen-devel] [PATCH] [v2] xen: avoid link error on ARM

2019-03-05 Thread Arnd Bergmann
On Tue, Mar 5, 2019 at 3:57 PM Juergen Gross wrote: > On 05/03/2019 14:43, Boris Ostrovsky wrote: > > On 3/5/19 8:30 AM, Arnd Bergmann wrote: > >> @@ -809,15 +789,7 @@ static long privcmd_ioctl_mmap_resource(struct file > >> *file, void __user *udata) > >> goto out; > >> > >> i

Re: [Xen-devel] [PATCH] [v2] xen: avoid link error on ARM

2019-03-05 Thread Juergen Gross
On 05/03/2019 14:43, Boris Ostrovsky wrote: > On 3/5/19 8:30 AM, Arnd Bergmann wrote: >> >> diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c >> index b24ddac1604b..290b6aca7e1d 100644 >> --- a/drivers/xen/privcmd.c >> +++ b/drivers/xen/privcmd.c >> @@ -723,26 +723,6 @@ static long privc

Re: [Xen-devel] [PATCH] [v2] xen: avoid link error on ARM

2019-03-05 Thread Boris Ostrovsky
On 3/5/19 8:30 AM, Arnd Bergmann wrote: > > diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c > index b24ddac1604b..290b6aca7e1d 100644 > --- a/drivers/xen/privcmd.c > +++ b/drivers/xen/privcmd.c > @@ -723,26 +723,6 @@ static long privcmd_ioctl_restrict(struct file *file, > void __user

Re: [Xen-devel] [PATCH] [v2] xen: avoid link error on ARM

2019-03-05 Thread Juergen Gross
On 05/03/2019 14:30, Arnd Bergmann wrote: > Building the privcmd code as a loadable module on ARM, we get > a link error due to the private cache management functions: > > ERROR: "__sync_icache_dcache" [drivers/xen/xen-privcmd.ko] undefined! > > Move the code into a new file that is always built