Re: [XEN PATCH 3/7] xen/arm: address MISRA C:2012 Rule 2.1

2023-12-11 Thread Nicola Vetrini
On 2023-12-11 15:14, Julien Grall wrote: On 11/12/2023 13:06, Michal Orzel wrote: On 11/12/2023 13:29, Julien Grall wrote: Hi, On 11/12/2023 10:30, Nicola Vetrini wrote: The "return 1;" statements at the end of some cases in the switch of function 'vgic_v3_its_mmio_write' in 'vcig-v3-its.

Re: [XEN PATCH 3/7] xen/arm: address MISRA C:2012 Rule 2.1

2023-12-11 Thread Julien Grall
On 11/12/2023 13:06, Michal Orzel wrote: On 11/12/2023 13:29, Julien Grall wrote: Hi, On 11/12/2023 10:30, Nicola Vetrini wrote: The "return 1;" statements at the end of some cases in the switch of function 'vgic_v3_its_mmio_write' in 'vcig-v3-its.c' cause the unreachability of the "ret

Re: [XEN PATCH 3/7] xen/arm: address MISRA C:2012 Rule 2.1

2023-12-11 Thread Michal Orzel
On 11/12/2023 13:29, Julien Grall wrote: > > > Hi, > > On 11/12/2023 10:30, Nicola Vetrini wrote: >> The "return 1;" statements at the end of some cases in the switch >> of function 'vgic_v3_its_mmio_write' in 'vcig-v3-its.c' cause the >> unreachability of the "return 1;" statement after the

Re: [XEN PATCH 3/7] xen/arm: address MISRA C:2012 Rule 2.1

2023-12-11 Thread Julien Grall
Hi, On 11/12/2023 10:30, Nicola Vetrini wrote: The "return 1;" statements at the end of some cases in the switch of function 'vgic_v3_its_mmio_write' in 'vcig-v3-its.c' cause the unreachability of the "return 1;" statement after the switch, thus violating MISRA C:2012 Rule 2.1: "A project shall