On 05.10.2023 01:32, Stefano Stabellini wrote:
> On Wed, 4 Oct 2023, Luca Fancellu wrote:
>>> On 4 Oct 2023, at 11:29, Nicola Vetrini wrote:
>>> On 04/10/2023 12:06, Luca Fancellu wrote:
Hi Nicola,
> On 4 Oct 2023, at 10:56, andrew.coop...@citrix.com wrote:
> On 03/10/2023 9:46 pm, St
On Wed, 11 Oct 2023, Julien Grall wrote:
> On 11/10/2023 11:53, Luca Fancellu wrote:
> >
> > > > >
> > > > > Luca answered to a similar, more generic, question a few days ago
> > > > > about
> > > > > Coverity: https://marc.info/?l=xen-devel&m=169657904027210
> > > > Interesting.
> > > > >
> > >
On 11/10/2023 11:53, Luca Fancellu wrote:
Luca answered to a similar, more generic, question a few days ago about
Coverity: https://marc.info/?l=xen-devel&m=169657904027210
Interesting.
So even if we get cppcheck to work like that, we would lose Coverity
support.
I think my suggestion w
>>>
>>> Luca answered to a similar, more generic, question a few days ago about
>>> Coverity: https://marc.info/?l=xen-devel&m=169657904027210
>> Interesting.
>>>
>>> So even if we get cppcheck to work like that, we would lose Coverity
>>> support.
>> I think my suggestion was probably misunders
On 11/10/2023 10:45, Julien Grall wrote:
Hi Stefano,
On 11/10/2023 00:39, Stefano Stabellini wrote:
On Tue, 10 Oct 2023, Julien Grall wrote:
Hi Stefano,
On 09/10/2023 23:19, Stefano Stabellini wrote:
I am not sure this is better. This is a long line to read. But this
is a
personal opin
Hi Stefano,
On 11/10/2023 00:39, Stefano Stabellini wrote:
On Tue, 10 Oct 2023, Julien Grall wrote:
Hi Stefano,
On 09/10/2023 23:19, Stefano Stabellini wrote:
I am not sure this is better. This is a long line to read. But this is a
personal opinion.
On the technical side, can we easily teac
On Tue, 10 Oct 2023, Julien Grall wrote:
> Hi Stefano,
>
> On 09/10/2023 23:19, Stefano Stabellini wrote:
> > >
> > > I am not sure this is better. This is a long line to read. But this is a
> > > personal opinion.
> > >
> > > On the technical side, can we easily teach a tool to format this kind
Hi Stefano,
On 09/10/2023 23:19, Stefano Stabellini wrote:
I am not sure this is better. This is a long line to read. But this is a
personal opinion.
On the technical side, can we easily teach a tool to format this kind of
exception? If not, then this should not be an exception we should imple
On 10/10/2023 09:29, Luca Fancellu wrote:
/* SAF-x-safe */
if ( modrm_mod == MASK_EXTR(instr_modrm, 0300) && (modrm_reg & 7) ==
MASK_EXTR(instr_modrm, 0070) && (modrm_rm & 7) ==
MASK_EXTR(instr_modrm,
0007) )
Any other ideas?
Could we have a number in the comment to indicate the number of
>
>>> /* SAF-x-safe */
>>> if ( modrm_mod == MASK_EXTR(instr_modrm, 0300) && (modrm_reg & 7) ==
>>> MASK_EXTR(instr_modrm, 0070) && (modrm_rm & 7) == MASK_EXTR(instr_modrm,
>>> 0007) )
>>>
>>> Any other ideas?
>>
>> Could we have a number in the comment to indicate the number of lines the
>> co
On Mon, 9 Oct 2023, Julien Grall wrote:
> On 07/10/2023 01:43, Stefano Stabellini wrote:
> > On Fri, 6 Oct 2023, Luca Fancellu wrote:
> > > > On 6 Oct 2023, at 02:02, Stefano Stabellini
> > > > wrote:
> > > >
> > > > On Thu, 5 Oct 2023, Luca Fancellu wrote:
> > > > > > On 5 Oct 2023, at 00:32, St
Hi,
On 07/10/2023 01:43, Stefano Stabellini wrote:
On Fri, 6 Oct 2023, Luca Fancellu wrote:
On 6 Oct 2023, at 02:02, Stefano Stabellini wrote:
On Thu, 5 Oct 2023, Luca Fancellu wrote:
On 5 Oct 2023, at 00:32, Stefano Stabellini wrote:
On Wed, 4 Oct 2023, Luca Fancellu wrote:
On 4 Oct 2023
>>>
>>> Right so the results would be all off by a few lines of code so when
>>> you go to read the report generated by cppcheck, the references
>>> wouldn't match anymore.
>>>
>>> Before giving up and accepting that we are constrained to only formats
>>> that don't change the LOC numbers, can we
On Fri, 6 Oct 2023, Luca Fancellu wrote:
> > On 6 Oct 2023, at 02:02, Stefano Stabellini wrote:
> >
> > On Thu, 5 Oct 2023, Luca Fancellu wrote:
> >>> On 5 Oct 2023, at 00:32, Stefano Stabellini
> >>> wrote:
> >>>
> >>> On Wed, 4 Oct 2023, Luca Fancellu wrote:
> > On 4 Oct 2023, at 11:29,
> On 6 Oct 2023, at 02:02, Stefano Stabellini wrote:
>
> On Thu, 5 Oct 2023, Luca Fancellu wrote:
>>> On 5 Oct 2023, at 00:32, Stefano Stabellini wrote:
>>>
>>> On Wed, 4 Oct 2023, Luca Fancellu wrote:
> On 4 Oct 2023, at 11:29, Nicola Vetrini
> wrote:
> On 04/10/2023 12:06, Luc
On Thu, 5 Oct 2023, Luca Fancellu wrote:
> > On 5 Oct 2023, at 00:32, Stefano Stabellini wrote:
> >
> > On Wed, 4 Oct 2023, Luca Fancellu wrote:
> >>> On 4 Oct 2023, at 11:29, Nicola Vetrini
> >>> wrote:
> >>> On 04/10/2023 12:06, Luca Fancellu wrote:
> Hi Nicola,
> > On 4 Oct 2023, at
> On 5 Oct 2023, at 00:32, Stefano Stabellini wrote:
>
> On Wed, 4 Oct 2023, Luca Fancellu wrote:
>>> On 4 Oct 2023, at 11:29, Nicola Vetrini wrote:
>>> On 04/10/2023 12:06, Luca Fancellu wrote:
Hi Nicola,
> On 4 Oct 2023, at 10:56, andrew.coop...@citrix.com wrote:
> On 03/10/2023
On Wed, 4 Oct 2023, Luca Fancellu wrote:
> > On 4 Oct 2023, at 11:29, Nicola Vetrini wrote:
> > On 04/10/2023 12:06, Luca Fancellu wrote:
> >> Hi Nicola,
> >>> On 4 Oct 2023, at 10:56, andrew.coop...@citrix.com wrote:
> >>> On 03/10/2023 9:46 pm, Stefano Stabellini wrote:
> On Tue, 3 Oct 2023
On 04/10/2023 12:52, Luca Fancellu wrote:
On 4 Oct 2023, at 11:29, Nicola Vetrini
wrote:
On 04/10/2023 12:06, Luca Fancellu wrote:
Hi Nicola,
On 4 Oct 2023, at 10:56, andrew.coop...@citrix.com wrote:
On 03/10/2023 9:46 pm, Stefano Stabellini wrote:
On Tue, 3 Oct 2023, Nicola Vetrini wrote:
> On 4 Oct 2023, at 12:17, Andrew Cooper wrote:
>
> On 04/10/2023 11:52 am, Luca Fancellu wrote:
>>
>> From the documentation:
>>
>> In the Xen codebase, these tags will be used to document and suppress
>> findings:
>>
>> - SAF-X-safe: This tag means that the next line of code contains a fi
On 04/10/2023 11:52 am, Luca Fancellu wrote:
> From the documentation:
>
> In the Xen codebase, these tags will be used to document and suppress
> findings:
>
> - SAF-X-safe: This tag means that the next line of code contains a
> finding, but
> the non compliance to the checker is a
> On 4 Oct 2023, at 11:29, Nicola Vetrini wrote:
>
> On 04/10/2023 12:06, Luca Fancellu wrote:
>> Hi Nicola,
>>> On 4 Oct 2023, at 10:56, andrew.coop...@citrix.com wrote:
>>> On 03/10/2023 9:46 pm, Stefano Stabellini wrote:
On Tue, 3 Oct 2023, Nicola Vetrini wrote:
> As specified in ru
On 04/10/2023 12:06, Luca Fancellu wrote:
Hi Nicola,
On 4 Oct 2023, at 10:56, andrew.coop...@citrix.com wrote:
On 03/10/2023 9:46 pm, Stefano Stabellini wrote:
On Tue, 3 Oct 2023, Nicola Vetrini wrote:
As specified in rules.rst, these constants can be used
in the code.
Their deviation is no
Hi Nicola,
> On 4 Oct 2023, at 10:56, andrew.coop...@citrix.com wrote:
>
> On 03/10/2023 9:46 pm, Stefano Stabellini wrote:
>> On Tue, 3 Oct 2023, Nicola Vetrini wrote:
>>
>>> As specified in rules.rst, these constants can be used
>>> in the code.
>>> Their deviation is now accomplished by using
On 03/10/2023 9:46 pm, Stefano Stabellini wrote:
> On Tue, 3 Oct 2023, Nicola Vetrini wrote:
>> As specified in rules.rst, these constants can be used
>> in the code.
>> Their deviation is now accomplished by using a SAF comment,
>> rather than an ECLAIR configuration.
>>
>> Signed-off-by: Nicola V
On Tue, 3 Oct 2023, Nicola Vetrini wrote:
> As specified in rules.rst, these constants can be used
> in the code.
> Their deviation is now accomplished by using a SAF comment,
> rather than an ECLAIR configuration.
>
> Signed-off-by: Nicola Vetrini
"SAF" discussion aside that can be resolved els
On Tue, 3 Oct 2023, Andrew Cooper wrote:
> On 03/10/2023 6:14 pm, Luca Fancellu wrote:
> >
> >> On 3 Oct 2023, at 17:17, andrew.coop...@citrix.com wrote:
> >>
> >> On 03/10/2023 4:37 pm, Nicola Vetrini wrote:
> >>> As specified in rules.rst, these constants can be used
> >>> in the code.
> >>> Thei
On 03/10/2023 6:14 pm, Luca Fancellu wrote:
>
>> On 3 Oct 2023, at 17:17, andrew.coop...@citrix.com wrote:
>>
>> On 03/10/2023 4:37 pm, Nicola Vetrini wrote:
>>> As specified in rules.rst, these constants can be used
>>> in the code.
>>> Their deviation is now accomplished by using a SAF comment,
>
> On 3 Oct 2023, at 17:17, andrew.coop...@citrix.com wrote:
>
> On 03/10/2023 4:37 pm, Nicola Vetrini wrote:
>> As specified in rules.rst, these constants can be used
>> in the code.
>> Their deviation is now accomplished by using a SAF comment,
>> rather than an ECLAIR configuration.
>>
>> Si
On 03/10/2023 4:37 pm, Nicola Vetrini wrote:
> As specified in rules.rst, these constants can be used
> in the code.
> Their deviation is now accomplished by using a SAF comment,
> rather than an ECLAIR configuration.
>
> Signed-off-by: Nicola Vetrini
> ---
> automation/eclair_analysis/ECLAIR/dev
30 matches
Mail list logo
