Re: [PATCH v7 7/8] xen/riscv: page table handling

2024-09-27 Thread Jan Beulich
On 27.09.2024 13:32, oleksii.kuroc...@gmail.com wrote: > Just to be sure. Do you mean the following: > > diff --git a/xen/arch/riscv/pt.c b/xen/arch/riscv/pt.c > index d7eb207ddc..6cd2e595b6 100644 > --- a/xen/arch/riscv/pt.c > +++ b/xen/arch/riscv/pt.c > @@ -209,24 +209,15 @@ static int pt_update

Re: [PATCH v7 7/8] xen/riscv: page table handling

2024-09-27 Thread oleksii . kurochko
On Fri, 2024-09-27 at 11:15 +0200, Jan Beulich wrote: > On 27.09.2024 10:49, oleksii.kuroc...@gmail.com wrote: > > On Wed, 2024-09-25 at 16:58 +0200, Jan Beulich wrote: > > > On 25.09.2024 16:50, oleksii.kuroc...@gmail.com wrote: > > > > On Wed, 2024-09-25 at 16:22 +0200, Jan Beulich wrote: > > > >

Re: [PATCH v7 7/8] xen/riscv: page table handling

2024-09-27 Thread Jan Beulich
On 27.09.2024 10:49, oleksii.kuroc...@gmail.com wrote: > On Wed, 2024-09-25 at 16:58 +0200, Jan Beulich wrote: >> On 25.09.2024 16:50, oleksii.kuroc...@gmail.com wrote: >>> On Wed, 2024-09-25 at 16:22 +0200, Jan Beulich wrote: On 25.09.2024 12:07, oleksii.kuroc...@gmail.com wrote: > On Tue

Re: [PATCH v7 7/8] xen/riscv: page table handling

2024-09-27 Thread oleksii . kurochko
On Wed, 2024-09-25 at 16:58 +0200, Jan Beulich wrote: > On 25.09.2024 16:50, oleksii.kuroc...@gmail.com wrote: > > On Wed, 2024-09-25 at 16:22 +0200, Jan Beulich wrote: > > > On 25.09.2024 12:07, oleksii.kuroc...@gmail.com wrote: > > > > On Tue, 2024-09-24 at 15:31 +0200, Jan Beulich wrote: > > > >

Re: [PATCH v7 7/8] xen/riscv: page table handling

2024-09-25 Thread Jan Beulich
On 25.09.2024 16:50, oleksii.kuroc...@gmail.com wrote: > On Wed, 2024-09-25 at 16:22 +0200, Jan Beulich wrote: >> On 25.09.2024 12:07, oleksii.kuroc...@gmail.com wrote: >>> On Tue, 2024-09-24 at 15:31 +0200, Jan Beulich wrote: On 24.09.2024 13:30, oleksii.kuroc...@gmail.com wrote: > On Tue

Re: [PATCH v7 7/8] xen/riscv: page table handling

2024-09-25 Thread oleksii . kurochko
On Wed, 2024-09-25 at 16:22 +0200, Jan Beulich wrote: > On 25.09.2024 12:07, oleksii.kuroc...@gmail.com wrote: > > On Tue, 2024-09-24 at 15:31 +0200, Jan Beulich wrote: > > > On 24.09.2024 13:30, oleksii.kuroc...@gmail.com wrote: > > > > On Tue, 2024-09-24 at 12:49 +0200, Jan Beulich wrote: > > > >

Re: [PATCH v7 7/8] xen/riscv: page table handling

2024-09-25 Thread Jan Beulich
On 25.09.2024 12:07, oleksii.kuroc...@gmail.com wrote: > On Tue, 2024-09-24 at 15:31 +0200, Jan Beulich wrote: >> On 24.09.2024 13:30, oleksii.kuroc...@gmail.com wrote: >>> On Tue, 2024-09-24 at 12:49 +0200, Jan Beulich wrote: On 13.09.2024 17:57, Oleksii Kurochko wrote: > +static int pt_n

Re: [PATCH v7 7/8] xen/riscv: page table handling

2024-09-25 Thread oleksii . kurochko
On Tue, 2024-09-24 at 15:31 +0200, Jan Beulich wrote: > On 24.09.2024 13:30, oleksii.kuroc...@gmail.com wrote: > > On Tue, 2024-09-24 at 12:49 +0200, Jan Beulich wrote: > > > On 13.09.2024 17:57, Oleksii Kurochko wrote: > > > > +static int pt_next_level(bool alloc_tbl, pte_t **table, > > > > unsign

Re: [PATCH v7 7/8] xen/riscv: page table handling

2024-09-24 Thread Jan Beulich
On 24.09.2024 13:30, oleksii.kuroc...@gmail.com wrote: > On Tue, 2024-09-24 at 12:49 +0200, Jan Beulich wrote: >> On 13.09.2024 17:57, Oleksii Kurochko wrote: >>> +static int pt_next_level(bool alloc_tbl, pte_t **table, unsigned >>> int offset) >>> +{ >>> +    pte_t *entry; >>> +    mfn_t mfn; >>>

Re: [PATCH v7 7/8] xen/riscv: page table handling

2024-09-24 Thread oleksii . kurochko
On Tue, 2024-09-24 at 12:49 +0200, Jan Beulich wrote: > On 13.09.2024 17:57, Oleksii Kurochko wrote: > > > > @@ -68,6 +108,52 @@ static inline bool pte_is_valid(pte_t p) > > return p.pte & PTE_VALID; > >  } > >   > > +/* > > + * From the RISC-V spec: > > + *   The V bit indicates whether the

Re: [PATCH v7 7/8] xen/riscv: page table handling

2024-09-24 Thread Jan Beulich
On 13.09.2024 17:57, Oleksii Kurochko wrote: > @@ -34,15 +39,50 @@ > #define PTE_LEAF_DEFAULT(PTE_VALID | PTE_READABLE | PTE_WRITABLE) > #define PTE_TABLE (PTE_VALID) > > +#define PAGE_HYPERVISOR_RO (PTE_VALID | PTE_READABLE) > #define PAGE_HYPERVISOR_RW