Re: [PATCH v6] Avoid crash calling PrintErrMesg from efi_multiboot2

2025-04-04 Thread Jan Beulich
On 20.03.2025 15:33, Frediano Ziglio wrote: > On Thu, Mar 6, 2025 at 3:02 PM Frediano Ziglio > wrote: >> >> On Thu, Mar 6, 2025 at 2:26 PM Jan Beulich wrote: >>> >>> On 26.02.2025 19:54, Marek Marczykowski-Górecki wrote: On Mon, Feb 24, 2025 at 02:31:00PM +, Frediano Ziglio wrote: >

Re: [PATCH v6] Avoid crash calling PrintErrMesg from efi_multiboot2

2025-03-20 Thread Jan Beulich
On 20.03.2025 21:10, Frediano Ziglio wrote: > On Thu, Mar 20, 2025 at 3:15 PM Jan Beulich wrote: >> >> On 20.03.2025 15:33, Frediano Ziglio wrote: >>> On Thu, Mar 6, 2025 at 3:02 PM Frediano Ziglio >>> wrote: On Thu, Mar 6, 2025 at 2:26 PM Jan Beulich wrote: > > On 26.02.2025 1

Re: [PATCH v6] Avoid crash calling PrintErrMesg from efi_multiboot2

2025-03-20 Thread Frediano Ziglio
On Thu, Mar 20, 2025 at 3:15 PM Jan Beulich wrote: > > On 20.03.2025 15:33, Frediano Ziglio wrote: > > On Thu, Mar 6, 2025 at 3:02 PM Frediano Ziglio > > wrote: > >> > >> On Thu, Mar 6, 2025 at 2:26 PM Jan Beulich wrote: > >>> > >>> On 26.02.2025 19:54, Marek Marczykowski-Górecki wrote: > O

Re: [PATCH v6] Avoid crash calling PrintErrMesg from efi_multiboot2

2025-03-20 Thread Frediano Ziglio
On Thu, Mar 6, 2025 at 3:02 PM Frediano Ziglio wrote: > > On Thu, Mar 6, 2025 at 2:26 PM Jan Beulich wrote: > > > > On 26.02.2025 19:54, Marek Marczykowski-Górecki wrote: > > > On Mon, Feb 24, 2025 at 02:31:00PM +, Frediano Ziglio wrote: > > >> On Mon, Feb 24, 2025 at 1:16 PM Marek Marczykows

Re: [PATCH v6] Avoid crash calling PrintErrMesg from efi_multiboot2

2025-03-08 Thread Jan Beulich
On 26.02.2025 19:54, Marek Marczykowski-Górecki wrote: > On Mon, Feb 24, 2025 at 02:31:00PM +, Frediano Ziglio wrote: >> On Mon, Feb 24, 2025 at 1:16 PM Marek Marczykowski-Górecki >> wrote: >>> >>> On Mon, Feb 24, 2025 at 12:57:13PM +, Frediano Ziglio wrote: On Fri, Feb 21, 2025 at 8:

Re: [PATCH v6] Avoid crash calling PrintErrMesg from efi_multiboot2

2025-03-06 Thread Frediano Ziglio
On Thu, Mar 6, 2025 at 2:26 PM Jan Beulich wrote: > > On 26.02.2025 19:54, Marek Marczykowski-Górecki wrote: > > On Mon, Feb 24, 2025 at 02:31:00PM +, Frediano Ziglio wrote: > >> On Mon, Feb 24, 2025 at 1:16 PM Marek Marczykowski-Górecki > >> wrote: > >>> > >>> On Mon, Feb 24, 2025 at 12:57:1

Re: [PATCH v6] Avoid crash calling PrintErrMesg from efi_multiboot2

2025-02-26 Thread Jan Beulich
On 26.02.2025 19:54, Marek Marczykowski-Górecki wrote: > On Mon, Feb 24, 2025 at 02:31:00PM +, Frediano Ziglio wrote: >> On Mon, Feb 24, 2025 at 1:16 PM Marek Marczykowski-Górecki >> wrote: >>> >>> On Mon, Feb 24, 2025 at 12:57:13PM +, Frediano Ziglio wrote: On Fri, Feb 21, 2025 at 8:

Re: [PATCH v6] Avoid crash calling PrintErrMesg from efi_multiboot2

2025-02-26 Thread Marek Marczykowski-Górecki
On Mon, Feb 24, 2025 at 02:31:00PM +, Frediano Ziglio wrote: > On Mon, Feb 24, 2025 at 1:16 PM Marek Marczykowski-Górecki > wrote: > > > > On Mon, Feb 24, 2025 at 12:57:13PM +, Frediano Ziglio wrote: > > > On Fri, Feb 21, 2025 at 8:20 PM Marek Marczykowski-Górecki > > > wrote: > > > > > >

Re: [PATCH v6] Avoid crash calling PrintErrMesg from efi_multiboot2

2025-02-24 Thread Frediano Ziglio
On Mon, Feb 24, 2025 at 1:16 PM Marek Marczykowski-Górecki wrote: > > On Mon, Feb 24, 2025 at 12:57:13PM +, Frediano Ziglio wrote: > > On Fri, Feb 21, 2025 at 8:20 PM Marek Marczykowski-Górecki > > wrote: > > > > > > On Mon, Feb 17, 2025 at 04:26:59PM +, Frediano Ziglio wrote: > > > > Alt

Re: [PATCH v6] Avoid crash calling PrintErrMesg from efi_multiboot2

2025-02-24 Thread Marek Marczykowski-Górecki
On Mon, Feb 24, 2025 at 12:57:13PM +, Frediano Ziglio wrote: > On Fri, Feb 21, 2025 at 8:20 PM Marek Marczykowski-Górecki > wrote: > > > > On Mon, Feb 17, 2025 at 04:26:59PM +, Frediano Ziglio wrote: > > > Although code is compiled with -fpic option data is not position > > > independent.

Re: [PATCH v6] Avoid crash calling PrintErrMesg from efi_multiboot2

2025-02-24 Thread Frediano Ziglio
On Fri, Feb 21, 2025 at 8:20 PM Marek Marczykowski-Górecki wrote: > > On Mon, Feb 17, 2025 at 04:26:59PM +, Frediano Ziglio wrote: > > Although code is compiled with -fpic option data is not position > > independent. This causes data pointer to become invalid if > > code is not relocated prope

Re: [PATCH v6] Avoid crash calling PrintErrMesg from efi_multiboot2

2025-02-21 Thread Marek Marczykowski-Górecki
On Mon, Feb 17, 2025 at 04:26:59PM +, Frediano Ziglio wrote: > Although code is compiled with -fpic option data is not position > independent. This causes data pointer to become invalid if > code is not relocated properly which is what happens for > efi_multiboot2 which is called by multiboot e

Re: [PATCH v6] Avoid crash calling PrintErrMesg from efi_multiboot2

2025-02-20 Thread Frediano Ziglio
On Thu, Feb 20, 2025 at 7:32 AM Jan Beulich wrote: > > On 19.02.2025 17:34, Frediano Ziglio wrote: > > On Mon, Feb 17, 2025 at 4:56 PM Jan Beulich wrote: > >> On 17.02.2025 17:52, Frediano Ziglio wrote: > >>> On Mon, Feb 17, 2025 at 4:41 PM Andrew Cooper > >>> wrote: > On 17/02/2025 4:31 p

Re: [PATCH v6] Avoid crash calling PrintErrMesg from efi_multiboot2

2025-02-19 Thread Jan Beulich
On 19.02.2025 17:34, Frediano Ziglio wrote: > On Mon, Feb 17, 2025 at 4:56 PM Jan Beulich wrote: >> On 17.02.2025 17:52, Frediano Ziglio wrote: >>> On Mon, Feb 17, 2025 at 4:41 PM Andrew Cooper >>> wrote: On 17/02/2025 4:31 pm, Jan Beulich wrote: > On 17.02.2025 17:26, Frediano Ziglio w

Re: [PATCH v6] Avoid crash calling PrintErrMesg from efi_multiboot2

2025-02-19 Thread Frediano Ziglio
On Mon, Feb 17, 2025 at 4:56 PM Jan Beulich wrote: > > On 17.02.2025 17:52, Frediano Ziglio wrote: > > On Mon, Feb 17, 2025 at 4:41 PM Andrew Cooper > > wrote: > >> > >> On 17/02/2025 4:31 pm, Jan Beulich wrote: > >>> On 17.02.2025 17:26, Frediano Ziglio wrote: > --- a/xen/common/efi/efi-co

Re: [PATCH v6] Avoid crash calling PrintErrMesg from efi_multiboot2

2025-02-18 Thread Andrew Cooper
On 18/02/2025 12:05 pm, Frediano Ziglio wrote: > On Mon, Feb 17, 2025 at 4:56 PM Jan Beulich wrote: >> On 17.02.2025 17:52, Frediano Ziglio wrote: >>> On Mon, Feb 17, 2025 at 4:41 PM Andrew Cooper >>> wrote: On 17/02/2025 4:31 pm, Jan Beulich wrote: > On 17.02.2025 17:26, Frediano Zigli

Re: [PATCH v6] Avoid crash calling PrintErrMesg from efi_multiboot2

2025-02-18 Thread Frediano Ziglio
On Mon, Feb 17, 2025 at 4:56 PM Jan Beulich wrote: > > On 17.02.2025 17:52, Frediano Ziglio wrote: > > On Mon, Feb 17, 2025 at 4:41 PM Andrew Cooper > > wrote: > >> > >> On 17/02/2025 4:31 pm, Jan Beulich wrote: > >>> On 17.02.2025 17:26, Frediano Ziglio wrote: > --- a/xen/common/efi/efi-co

Re: [PATCH v6] Avoid crash calling PrintErrMesg from efi_multiboot2

2025-02-17 Thread Jan Beulich
On 17.02.2025 17:52, Frediano Ziglio wrote: > On Mon, Feb 17, 2025 at 4:41 PM Andrew Cooper > wrote: >> >> On 17/02/2025 4:31 pm, Jan Beulich wrote: >>> On 17.02.2025 17:26, Frediano Ziglio wrote: --- a/xen/common/efi/efi-common.mk +++ b/xen/common/efi/efi-common.mk @@ -2,6 +2,7 @@

Re: [PATCH v6] Avoid crash calling PrintErrMesg from efi_multiboot2

2025-02-17 Thread Frediano Ziglio
On Mon, Feb 17, 2025 at 4:41 PM Andrew Cooper wrote: > > On 17/02/2025 4:31 pm, Jan Beulich wrote: > > On 17.02.2025 17:26, Frediano Ziglio wrote: > >> --- a/xen/common/efi/efi-common.mk > >> +++ b/xen/common/efi/efi-common.mk > >> @@ -2,6 +2,7 @@ EFIOBJ-y := boot.init.o pe.init.o ebmalloc.o runti

Re: [PATCH v6] Avoid crash calling PrintErrMesg from efi_multiboot2

2025-02-17 Thread Andrew Cooper
On 17/02/2025 4:31 pm, Jan Beulich wrote: > On 17.02.2025 17:26, Frediano Ziglio wrote: >> --- a/xen/common/efi/efi-common.mk >> +++ b/xen/common/efi/efi-common.mk >> @@ -2,6 +2,7 @@ EFIOBJ-y := boot.init.o pe.init.o ebmalloc.o runtime.o >> EFIOBJ-$(CONFIG_COMPAT) += compat.o >> >> CFLAGS-y +=

Re: [PATCH v6] Avoid crash calling PrintErrMesg from efi_multiboot2

2025-02-17 Thread Jan Beulich
On 17.02.2025 17:26, Frediano Ziglio wrote: > --- a/xen/common/efi/efi-common.mk > +++ b/xen/common/efi/efi-common.mk > @@ -2,6 +2,7 @@ EFIOBJ-y := boot.init.o pe.init.o ebmalloc.o runtime.o > EFIOBJ-$(CONFIG_COMPAT) += compat.o > > CFLAGS-y += -fshort-wchar > +CFLAGS-y += -fno-jump-tables > C