Re: [PATCH v4 3/5] tools/libs/foreignmemory: Fix PAGE_SIZE redefinition error

2021-07-13 Thread Costin Lupu
Hi Jan, First of all sorry for breaking the stubdom build. Please see inline. On 7/13/21 9:47 AM, Jan Beulich wrote: > On 08.06.2021 14:35, Costin Lupu wrote: >> --- a/tools/libs/foreignmemory/private.h >> +++ b/tools/libs/foreignmemory/private.h >> @@ -1,6 +1,7 @@ >> #ifndef XENFOREIGNMEMORY_PR

Re: [PATCH v4 3/5] tools/libs/foreignmemory: Fix PAGE_SIZE redefinition error

2021-07-12 Thread Jan Beulich
On 08.06.2021 14:35, Costin Lupu wrote: > --- a/tools/libs/foreignmemory/private.h > +++ b/tools/libs/foreignmemory/private.h > @@ -1,6 +1,7 @@ > #ifndef XENFOREIGNMEMORY_PRIVATE_H > #define XENFOREIGNMEMORY_PRIVATE_H > > +#include > #include > > #include At the risk of repeating what m

Re: [PATCH v4 3/5] tools/libs/foreignmemory: Fix PAGE_SIZE redefinition error

2021-07-08 Thread Julien Grall
Hi Costin, On 08/06/2021 13:35, Costin Lupu wrote: If PAGE_SIZE is already defined in the system (e.g. in /usr/include/limits.h header) then gcc will trigger a redefinition error because of -Werror. This patch replaces usage of PAGE_* macros with XC_PAGE_* macros in order to avoid confusion betw