Re: [PATCH v4 1/6] xen: implement byteswap

2022-05-23 Thread Jan Beulich
On 23.05.2022 13:00, Jan Beulich wrote: > On 23.05.2022 12:07, Roger Pau Monné wrote: >> Likewise the __ORDER_{BIG,LITTLE}_ENDIAN__ defines would be better >> placed in byteswap.h itself if possible IMO, since it's not strictly >> related to the compiler. > > These need to live in per-arch headers

Re: [PATCH v4 1/6] xen: implement byteswap

2022-05-23 Thread Jan Beulich
On 23.05.2022 12:07, Roger Pau Monné wrote: > On Mon, May 23, 2022 at 05:52:17AM -0400, Lin Liu wrote: >> diff --git a/xen/include/xen/compiler.h b/xen/include/xen/compiler.h >> index 933aec09a9..ae029afa14 100644 >> --- a/xen/include/xen/compiler.h >> +++ b/xen/include/xen/compiler.h >> @@ -185,4

Re: [PATCH v4 1/6] xen: implement byteswap

2022-05-23 Thread Roger Pau Monné
On Mon, May 23, 2022 at 05:52:17AM -0400, Lin Liu wrote: > diff --git a/xen/include/xen/compiler.h b/xen/include/xen/compiler.h > index 933aec09a9..ae029afa14 100644 > --- a/xen/include/xen/compiler.h > +++ b/xen/include/xen/compiler.h > @@ -185,4 +185,28 @@ > # define CLANG_DISABLE_WARN_GCC_COMPA