Re: [PATCH v4 02/21] IOMMU: simplify unmap-on-error in iommu_map()

2022-05-03 Thread Roger Pau Monné
On Tue, May 03, 2022 at 04:37:29PM +0200, Jan Beulich wrote: > On 03.05.2022 12:25, Roger Pau Monné wrote: > > On Mon, Apr 25, 2022 at 10:32:10AM +0200, Jan Beulich wrote: > >> As of 68a8aa5d7264 ("iommu: make map and unmap take a page count, > >> similar to flush") there's no need anymore to have

Re: [PATCH v4 02/21] IOMMU: simplify unmap-on-error in iommu_map()

2022-05-03 Thread Jan Beulich
On 03.05.2022 12:25, Roger Pau Monné wrote: > On Mon, Apr 25, 2022 at 10:32:10AM +0200, Jan Beulich wrote: >> As of 68a8aa5d7264 ("iommu: make map and unmap take a page count, >> similar to flush") there's no need anymore to have a loop here. >> >> Suggested-by: Roger Pau Monné >> Signed-off-by: J

Re: [PATCH v4 02/21] IOMMU: simplify unmap-on-error in iommu_map()

2022-05-03 Thread Roger Pau Monné
On Mon, Apr 25, 2022 at 10:32:10AM +0200, Jan Beulich wrote: > As of 68a8aa5d7264 ("iommu: make map and unmap take a page count, > similar to flush") there's no need anymore to have a loop here. > > Suggested-by: Roger Pau Monné > Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné I wond

Re: [PATCH v4 02/21] IOMMU: simplify unmap-on-error in iommu_map()

2022-04-27 Thread Jan Beulich
On 27.04.2022 15:16, Andrew Cooper wrote: > On 25/04/2022 09:32, Jan Beulich wrote: >> --- a/xen/drivers/passthrough/iommu.c >> +++ b/xen/drivers/passthrough/iommu.c >> @@ -308,11 +308,9 @@ int iommu_map(struct domain *d, dfn_t df >> d->domain_id, dfn_x(dfn_add(dfn, i)), >>

Re: [PATCH v4 02/21] IOMMU: simplify unmap-on-error in iommu_map()

2022-04-27 Thread Andrew Cooper
On 25/04/2022 09:32, Jan Beulich wrote: > As of 68a8aa5d7264 ("iommu: make map and unmap take a page count, > similar to flush") there's no need anymore to have a loop here. > > Suggested-by: Roger Pau Monné > Signed-off-by: Jan Beulich > --- > v3: New. > > --- a/xen/drivers/passthrough/iommu.c >