Re: [PATCH v3 4/7] x86/vmx: add do_vmtrace_op

2020-06-29 Thread Michał Leszczyński
- 23 cze 2020 o 13:54, Andrew Cooper andrew.coop...@citrix.com napisał(a): > Overall, the moving parts of this series needs to split out into rather > more patches. > > First, in patch 3, the hvm_funcs.pt_supported isn't the place for that > to live.  You want a global "bool vmtrace_supported"

Re: [PATCH v3 4/7] x86/vmx: add do_vmtrace_op

2020-06-23 Thread Andrew Cooper
On 22/06/2020 19:11, Michał Leszczyński wrote: > diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c > index 5bb47583b3..5899df52c3 100644 > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -58,6 +58,7 @@ > #include > #include > #include > +#include You cannot inclu