Re: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-23 Thread Julien Grall
Hi, On 23/03/2022 13:58, Luca Fancellu wrote: On 22 Mar 2022, at 14:01, Julien Grall wrote: Hi, On 22/03/2022 09:52, Luca Fancellu wrote: Can you document why this is necessary on x86 but not on other architectures? Hi Julien, I received the warning by Juergen here: https://patchwork.kern

Re: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-23 Thread Luca Fancellu
> On 22 Mar 2022, at 14:01, Julien Grall wrote: > > Hi, > > On 22/03/2022 09:52, Luca Fancellu wrote: > > Can you document why this is necessary on x86 but not on other > architectures? Hi Julien, I received the warning by Juergen here: https://patchwork.kernel.or

Re: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-22 Thread Stefano Stabellini
On Tue, 22 Mar 2022, Luca Fancellu wrote: > >> +- cpupool-sched (optional) > >> + > >> +Must be a string having the name of a Xen scheduler, it has no effect > >> when > >> +used in conjunction of a cpupool-id equal to zero, in that case the > >> +default Xen scheduler is selected (sch

Re: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-22 Thread Julien Grall
Hi, On 22/03/2022 09:52, Luca Fancellu wrote: Can you document why this is necessary on x86 but not on other architectures? Hi Julien, I received the warning by Juergen here: https://patchwork.kernel.org/comment/24740762/ that at least on x86 there could be some problems if cpu0 is not in cp

Re: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-22 Thread Luca Fancellu
>>> >>> Can you document why this is necessary on x86 but not on other >>> architectures? >> Hi Julien, >> I received the warning by Juergen here: >> https://patchwork.kernel.org/comment/24740762/ that at least on x86 there >> could be >> some problems if cpu0 is not in cpupool0, I tested it on

Re: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-22 Thread Bertrand Marquis
Hi Julien, > On 22 Mar 2022, at 10:16, Julien Grall wrote: > > Hi, > > On 22/03/2022 08:47, Bertrand Marquis wrote: >> Hi Julien, >>> On 22 Mar 2022, at 09:35, Bertrand Marquis wrote: >>> >>> Hi Julien, >>> On 21 Mar 2022, at 18:44, Julien Grall wrote: Hi Bertrand, >>>

Re: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-22 Thread Julien Grall
Hi, On 22/03/2022 08:47, Bertrand Marquis wrote: Hi Julien, On 22 Mar 2022, at 09:35, Bertrand Marquis wrote: Hi Julien, On 21 Mar 2022, at 18:44, Julien Grall wrote: Hi Bertrand, On 21/03/2022 17:19, Bertrand Marquis wrote: On 21 Mar 2022, at 17:36, Julien Grall wrote: So I don’t kn

Re: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-22 Thread Luca Fancellu
>> +- cpupool-sched (optional) >> + >> +Must be a string having the name of a Xen scheduler, it has no effect >> when >> +used in conjunction of a cpupool-id equal to zero, in that case the >> +default Xen scheduler is selected (sched=<...> boot argument). >> +Check the sched=<...

Re: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-22 Thread Bertrand Marquis
Hi Julien, > On 22 Mar 2022, at 09:35, Bertrand Marquis wrote: > > Hi Julien, > >> On 21 Mar 2022, at 18:44, Julien Grall wrote: >> >> Hi Bertrand, >> >> On 21/03/2022 17:19, Bertrand Marquis wrote: On 21 Mar 2022, at 17:36, Julien Grall wrote: > So I don’t know why on x86 we must

Re: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-22 Thread Bertrand Marquis
Hi Julien, > On 21 Mar 2022, at 18:44, Julien Grall wrote: > > Hi Bertrand, > > On 21/03/2022 17:19, Bertrand Marquis wrote: >>> On 21 Mar 2022, at 17:36, Julien Grall wrote: So I don’t know why on x86 we must have cpu0 in cpupool0, maybe x86 maintainer have more knowledge about tha

Re: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-21 Thread Stefano Stabellini
On Fri, 18 Mar 2022, Luca Fancellu wrote: > Introduce a way to create different cpupools at boot time, this is > particularly useful on ARM big.LITTLE system where there might be the > need to have different cpupools for each type of core, but also > systems using NUMA can have different cpu pools

Re: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-21 Thread Julien Grall
Hi Bertrand, On 21/03/2022 17:19, Bertrand Marquis wrote: On 21 Mar 2022, at 17:36, Julien Grall wrote: So I don’t know why on x86 we must have cpu0 in cpupool0, maybe x86 maintainer have more knowledge about that and I can put a comment here. On Arm, we are not yet supporting all the CPU f

Re: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-21 Thread Bertrand Marquis
Hi Julien, > On 21 Mar 2022, at 17:36, Julien Grall wrote: > > Hi, > > On 21/03/2022 15:58, Luca Fancellu wrote: >>> On 18 Mar 2022, at 16:12, Julien Grall wrote: >>> >>> Hi Luca, >>> >>> I only skimmed through the series. I have one question below: >>> >>> On 18/03/2022 15:25, Luca Fancell

Re: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-21 Thread Julien Grall
Hi, On 21/03/2022 15:58, Luca Fancellu wrote: On 18 Mar 2022, at 16:12, Julien Grall wrote: Hi Luca, I only skimmed through the series. I have one question below: On 18/03/2022 15:25, Luca Fancellu wrote: +void __init btcpupools_allocate_pools(void) +{ +unsigned int i; +bool add_

Re: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-21 Thread Luca Fancellu
> On 18 Mar 2022, at 16:12, Julien Grall wrote: > > Hi Luca, > > I only skimmed through the series. I have one question below: > > On 18/03/2022 15:25, Luca Fancellu wrote: >> +void __init btcpupools_allocate_pools(void) >> +{ >> +unsigned int i; >> +bool add_extra_cpupool = false; >>

Re: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-21 Thread Luca Fancellu
> On 21 Mar 2022, at 09:10, Jan Beulich wrote: > > On 18.03.2022 16:25, Luca Fancellu wrote: >> --- a/xen/common/Makefile >> +++ b/xen/common/Makefile >> @@ -1,5 +1,6 @@ >> obj-$(CONFIG_ARGO) += argo.o >> obj-y += bitmap.o >> +obj-$(CONFIG_BOOT_TIME_CPUPOOLS) += boot_cpupools.o > > By the loo

Re: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-21 Thread Jan Beulich
On 18.03.2022 16:25, Luca Fancellu wrote: > --- a/xen/common/Makefile > +++ b/xen/common/Makefile > @@ -1,5 +1,6 @@ > obj-$(CONFIG_ARGO) += argo.o > obj-y += bitmap.o > +obj-$(CONFIG_BOOT_TIME_CPUPOOLS) += boot_cpupools.o By the looks of it you appear to want to specify boot_cpupools.init.o here

Re: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-18 Thread Julien Grall
Hi Luca, I only skimmed through the series. I have one question below: On 18/03/2022 15:25, Luca Fancellu wrote: +void __init btcpupools_allocate_pools(void) +{ +unsigned int i; +bool add_extra_cpupool = false; + +/* + * If there are no cpupools, the value of next_pool_id is zer