Re: [PATCH v3 10/34] xen/riscv: introduce bitops.h

2024-01-19 Thread Oleksii
On Fri, 2024-01-19 at 10:14 +0100, Jan Beulich wrote: > On 19.01.2024 10:09, Oleksii wrote: > > On Thu, 2024-01-18 at 12:03 +0100, Jan Beulich wrote: > > > On 22.12.2023 16:12, Oleksii Kurochko wrote: > > > > --- /dev/null > > > > +++ b/xen/include/asm-generic/bitops/bitops-bits.h > > > > @@ -0,0 +

Re: [PATCH v3 10/34] xen/riscv: introduce bitops.h

2024-01-19 Thread Jan Beulich
On 19.01.2024 10:16, Oleksii wrote: > On Thu, 2024-01-18 at 12:01 +0100, Jan Beulich wrote: >> On 18.01.2024 10:43, Oleksii wrote: >>> On Wed, 2024-01-17 at 14:42 +0100, Jan Beulich wrote: On 17.01.2024 12:37, Oleksii wrote: >> Also you want to make sure asm-generic/bitops/bit

Re: [PATCH v3 10/34] xen/riscv: introduce bitops.h

2024-01-19 Thread Oleksii
On Thu, 2024-01-18 at 12:01 +0100, Jan Beulich wrote: > On 18.01.2024 10:43, Oleksii wrote: > > On Wed, 2024-01-17 at 14:42 +0100, Jan Beulich wrote: > > > On 17.01.2024 12:37, Oleksii wrote: > > > > > > > > > > > > > > > > Also you want to make sure asm-generic/bitops/bitops- > > > > > > > > > bi

Re: [PATCH v3 10/34] xen/riscv: introduce bitops.h

2024-01-19 Thread Jan Beulich
On 19.01.2024 10:09, Oleksii wrote: > On Thu, 2024-01-18 at 12:03 +0100, Jan Beulich wrote: >> On 22.12.2023 16:12, Oleksii Kurochko wrote: >>> --- /dev/null >>> +++ b/xen/include/asm-generic/bitops/bitops-bits.h >>> @@ -0,0 +1,10 @@ >>> +/* SPDX-License-Identifier: GPL-2.0 */ >>> +#ifndef _ASM_GEN

Re: [PATCH v3 10/34] xen/riscv: introduce bitops.h

2024-01-19 Thread Oleksii
On Thu, 2024-01-18 at 12:03 +0100, Jan Beulich wrote: > On 22.12.2023 16:12, Oleksii Kurochko wrote: > > --- /dev/null > > +++ b/xen/include/asm-generic/bitops/bitops-bits.h > > @@ -0,0 +1,10 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +#ifndef _ASM_GENERIC_BITOPS_BITS_H_ > > +#define _ASM_G

Re: [PATCH v3 10/34] xen/riscv: introduce bitops.h

2024-01-18 Thread Jan Beulich
On 22.12.2023 16:12, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/include/asm-generic/bitops/bitops-bits.h > @@ -0,0 +1,10 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef _ASM_GENERIC_BITOPS_BITS_H_ > +#define _ASM_GENERIC_BITOPS_BITS_H_ > + > +#define BITOP_BITS_PER_WORD 32 > +#

Re: [PATCH v3 10/34] xen/riscv: introduce bitops.h

2024-01-18 Thread Jan Beulich
On 18.01.2024 10:43, Oleksii wrote: > On Wed, 2024-01-17 at 14:42 +0100, Jan Beulich wrote: >> On 17.01.2024 12:37, Oleksii wrote: >> Also you want to make sure asm-generic/bitops/bitops- bits.h is really in use here, or else an arch overriding / not

Re: [PATCH v3 10/34] xen/riscv: introduce bitops.h

2024-01-18 Thread Oleksii
On Wed, 2024-01-17 at 14:42 +0100, Jan Beulich wrote: > On 17.01.2024 12:37, Oleksii wrote: > > > > > > > > > > > > Also you want to make sure asm-generic/bitops/bitops- > > > > > > > bits.h > > > > > > > is > > > > > > > really in use here, or else an arch overriding / not > > > > > > > using > >

Re: [PATCH v3 10/34] xen/riscv: introduce bitops.h

2024-01-17 Thread Jan Beulich
On 17.01.2024 12:37, Oleksii wrote: >> Also you want to make sure asm-generic/bitops/bitops-bits.h >> is >> really in use here, or else an arch overriding / not using >> that >> header may end up screwed. > I am not really understand what do you mean. Could you please >

Re: [PATCH v3 10/34] xen/riscv: introduce bitops.h

2024-01-17 Thread Oleksii
> > > > > > > > Also you want to make sure asm-generic/bitops/bitops-bits.h > > > > > is > > > > > really in use here, or else an arch overriding / not using > > > > > that > > > > > header may end up screwed. > > > > I am not really understand what do you mean. Could you please > > > > explain a

Re: [PATCH v3 10/34] xen/riscv: introduce bitops.h

2024-01-17 Thread Jan Beulich
On 17.01.2024 12:13, Oleksii wrote: > On Tue, 2024-01-16 at 14:24 +0100, Jan Beulich wrote: >> On 16.01.2024 14:06, Oleksii wrote: >>> On Mon, 2024-01-15 at 17:44 +0100, Jan Beulich wrote: On 22.12.2023 16:12, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/include/asm-generic/bito

Re: [PATCH v3 10/34] xen/riscv: introduce bitops.h

2024-01-17 Thread Oleksii
On Tue, 2024-01-16 at 14:24 +0100, Jan Beulich wrote: > On 16.01.2024 14:06, Oleksii wrote: > > On Mon, 2024-01-15 at 17:44 +0100, Jan Beulich wrote: > > > On 22.12.2023 16:12, Oleksii Kurochko wrote: > > > > +#define test_and_set_bit   __test_and_set_bit > > > > +#define test_and_clear_bit __test_

Re: [PATCH v3 10/34] xen/riscv: introduce bitops.h

2024-01-16 Thread Jan Beulich
On 16.01.2024 14:06, Oleksii wrote: > On Mon, 2024-01-15 at 17:44 +0100, Jan Beulich wrote: >> On 22.12.2023 16:12, Oleksii Kurochko wrote: >>> +#define test_and_set_bit   __test_and_set_bit >>> +#define test_and_clear_bit __test_and_clear_bit >> >> I realize test-and-change have no present users,

Re: [PATCH v3 10/34] xen/riscv: introduce bitops.h

2024-01-16 Thread Oleksii
On Mon, 2024-01-15 at 17:44 +0100, Jan Beulich wrote: > On 22.12.2023 16:12, Oleksii Kurochko wrote: > > --- /dev/null > > +++ b/xen/arch/riscv/include/asm/bitops.h > > @@ -0,0 +1,267 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* Copyright (C) 2012 Regents of the University of California *

Re: [PATCH v3 10/34] xen/riscv: introduce bitops.h

2024-01-15 Thread Jan Beulich
On 22.12.2023 16:12, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/arch/riscv/include/asm/bitops.h > @@ -0,0 +1,267 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* Copyright (C) 2012 Regents of the University of California */ > + > +#ifndef _ASM_RISCV_BITOPS_H > +#define _ASM_RISCV_BITOPS_