Re: [PATCH v3 09/14] xen/asm-generic: introduce generic header altp2m.h

2023-11-27 Thread Jan Beulich
On 27.11.2023 12:48, Oleksii wrote: > On Fri, 2023-11-24 at 14:18 +0100, Jan Beulich wrote: >> On 24.11.2023 14:00, Michal Orzel wrote: >>> On 17/11/2023 13:24, Oleksii Kurochko wrote: --- a/xen/arch/arm/include/asm/altp2m.h +++ /dev/null @@ -1,39 +0,0 @@ -/* - * Alternate

Re: [PATCH v3 09/14] xen/asm-generic: introduce generic header altp2m.h

2023-11-27 Thread Oleksii
On Fri, 2023-11-24 at 14:18 +0100, Jan Beulich wrote: > On 24.11.2023 14:00, Michal Orzel wrote: > > On 17/11/2023 13:24, Oleksii Kurochko wrote: > > > --- a/xen/arch/arm/include/asm/altp2m.h > > > +++ /dev/null > > > @@ -1,39 +0,0 @@ > > > -/* > > > - * Alternate p2m > > > - * > > > - * Copyright

Re: [PATCH v3 09/14] xen/asm-generic: introduce generic header altp2m.h

2023-11-24 Thread Jan Beulich
On 17.11.2023 13:24, Oleksii Kurochko wrote: > is common between archs so it is moved to > asm-generic. Here and elsewhere: The statement above can be read that the same applies to all arch-s (in which case the header would better move to include/xen/). Since this isn't true for x86, may I sugges

Re: [PATCH v3 09/14] xen/asm-generic: introduce generic header altp2m.h

2023-11-24 Thread Jan Beulich
On 24.11.2023 14:00, Michal Orzel wrote: > On 17/11/2023 13:24, Oleksii Kurochko wrote: >> --- a/xen/arch/arm/include/asm/altp2m.h >> +++ /dev/null >> @@ -1,39 +0,0 @@ >> -/* >> - * Alternate p2m >> - * >> - * Copyright (c) 2014, Intel Corporation. > Shouldn't this copyright be moved to generic hea

Re: [PATCH v3 09/14] xen/asm-generic: introduce generic header altp2m.h

2023-11-24 Thread Michal Orzel
Hi, On 17/11/2023 13:24, Oleksii Kurochko wrote: > > > is common between archs so it is moved to > asm-generic. > > Arm and PPC were switched to asm-generic version of altp2m.h. > > Signed-off-by: Oleksii Kurochko > --- > Changes in V3: > - Drop Arm and PPC's altp2m.h > - Update the commit