Re: [PATCH v3] iscsi_ibft: Fix finding the iBFT under Xen Dom 0

2023-06-09 Thread Dave Hansen
On 6/9/23 08:22, Konrad Rzeszutek Wilk wrote: > Dave, are you OK with the change in where the reserve call is made? The move makes logical sense. I'm not 100% confident it won't regress anything, but the blast radius should be limited to iSCSI. But, yeah, I'm OK with it.

Re: [PATCH v3] iscsi_ibft: Fix finding the iBFT under Xen Dom 0

2023-06-09 Thread Juergen Gross
On 09.06.23 17:27, Konrad Rzeszutek Wilk wrote: Usually I put it in my tree (ibft) but since it is so simple and the user is Xen it would make more sense to do it via the Xen tree (Juergen). Works for me. Juergen Thx On Fri, Jun 9, 2023, 11:16 AM Dave Hansen

Re: [PATCH v3] iscsi_ibft: Fix finding the iBFT under Xen Dom 0

2023-06-09 Thread Konrad Rzeszutek Wilk
Usually I put it in my tree (ibft) but since it is so simple and the user is Xen it would make more sense to do it via the Xen tree (Juergen). Thx On Fri, Jun 9, 2023, 11:16 AM Dave Hansen wrote: > On 6/5/23 03:28, Ross Lagerwall wrote: > > The result of these changes is that it is possible to

Re: [PATCH v3] iscsi_ibft: Fix finding the iBFT under Xen Dom 0

2023-06-09 Thread Konrad Rzeszutek Wilk
Feel free to add my Acked-by. Dave, are you OK with the change in where the reserve call is made? Thx On Fri, Jun 9, 2023, 11:08 AM Juergen Gross wrote: > On 05.06.23 12:28, Ross Lagerwall wrote: > > To facilitate diskless iSCSI boot, the firmware can place a table of > > configuration details

Re: [PATCH v3] iscsi_ibft: Fix finding the iBFT under Xen Dom 0

2023-06-09 Thread Dave Hansen
On 6/5/23 03:28, Ross Lagerwall wrote: > The result of these changes is that it is possible to boot a diskless > Xen + Dom0 running off an iSCSI disk whereas previously it would fail to > find the iBFT and consequently, the iSCSI root disk. Acked-by: Dave Hansen # for x86 The work in this patch

Re: [PATCH v3] iscsi_ibft: Fix finding the iBFT under Xen Dom 0

2023-06-09 Thread Juergen Gross
On 05.06.23 12:28, Ross Lagerwall wrote: To facilitate diskless iSCSI boot, the firmware can place a table of configuration details in memory called the iBFT. The presence of this table is not specified, nor is the precise location (and it's not in the E820) so the kernel has to search for a magi

Re: [PATCH v3] iscsi_ibft: Fix finding the iBFT under Xen Dom 0

2023-06-09 Thread Ross Lagerwall
sen > ; x...@kernel.org ; Juergen > Gross ; Boris Ostrovsky ; Peter > Jones ; Konrad Rzeszutek Wilk > Subject: Re: [PATCH v3] iscsi_ibft: Fix finding the iBFT under Xen Dom 0 >   > It looks fine to me, but could I ask you to triple check that on > non-Xen it still detects the i

Re: [PATCH v3] iscsi_ibft: Fix finding the iBFT under Xen Dom 0

2023-06-08 Thread Konrad Rzeszutek Wilk
It looks fine to me, but could I ask you to triple check that on non-Xen it still detects the iBFT? Thx! On Mon, Jun 5, 2023 at 6:28 AM Ross Lagerwall wrote: > > To facilitate diskless iSCSI boot, the firmware can place a table of > configuration details in memory called the iBFT. The presence o