Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-15 Thread Juergen Gross
On 15.03.22 09:40, Luca Fancellu wrote: Hmm, this will fail the ASSERT(spin_is_locked(&cpupool_lock)) in __cpupool_find_by_id(). I think you need to use cpupool_get_by_id() and cpupool_put() by making them globally visible (move their prototypes to sched.h). Hi Juergen, Yes I was thinking m

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-15 Thread Luca Fancellu
> Hmm, this will fail the ASSERT(spin_is_locked(&cpupool_lock)) in > __cpupool_find_by_id(). > > I think you need to use cpupool_get_by_id() and cpupool_put() by making them > globally visible (move their prototypes to sched.h). Hi Juergen, Yes I was thinking more to a __init wrapper that take

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-14 Thread Juergen Gross
On 12.03.22 01:10, Stefano Stabellini wrote: On Fri, 11 Mar 2022, Luca Fancellu wrote: On Thu, 10 Mar 2022, Luca Fancellu wrote: Introduce a way to create different cpupools at boot time, this is particularly useful on ARM big.LITTLE system where there might be the need to have different cpupoo

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-11 Thread Stefano Stabellini
On Fri, 11 Mar 2022, Luca Fancellu wrote: > > On Thu, 10 Mar 2022, Luca Fancellu wrote: > >> Introduce a way to create different cpupools at boot time, this is > >> particularly useful on ARM big.LITTLE system where there might be the > >> need to have different cpupools for each type of core, but

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-11 Thread Luca Fancellu
> On 11 Mar 2022, at 14:11, Luca Fancellu wrote: > > Hi Stefano, > >> On 11 Mar 2022, at 03:57, Stefano Stabellini wrote: >> >> On Thu, 10 Mar 2022, Luca Fancellu wrote: >>> Introduce a way to create different cpupools at boot time, this is >>> particularly useful on ARM big.LITTLE system wh

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-11 Thread Luca Fancellu
Hi Stefano, > On 11 Mar 2022, at 03:57, Stefano Stabellini wrote: > > On Thu, 10 Mar 2022, Luca Fancellu wrote: >> Introduce a way to create different cpupools at boot time, this is >> particularly useful on ARM big.LITTLE system where there might be the >> need to have different cpupools for ea

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-11 Thread Jan Beulich
On 11.03.2022 12:29, Luca Fancellu wrote: >> On 11 Mar 2022, at 10:18, Juergen Gross wrote: >> On 11.03.22 10:46, Jan Beulich wrote: >>> On 11.03.2022 10:29, Juergen Gross wrote: On 11.03.22 09:56, Luca Fancellu wrote: >> On 11 Mar 2022, at 08:09, Juergen Gross wrote: >> On 10.03.22

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-11 Thread Juergen Gross
On 11.03.22 12:29, Luca Fancellu wrote: On 11 Mar 2022, at 10:18, Juergen Gross wrote: On 11.03.22 10:46, Jan Beulich wrote: On 11.03.2022 10:29, Juergen Gross wrote: On 11.03.22 09:56, Luca Fancellu wrote: On 11 Mar 2022, at 08:09, Juergen Gross wrote: On 10.03.22 18:10, Luca Fancellu w

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-11 Thread Luca Fancellu
> On 11 Mar 2022, at 10:18, Juergen Gross wrote: > > On 11.03.22 10:46, Jan Beulich wrote: >> On 11.03.2022 10:29, Juergen Gross wrote: >>> On 11.03.22 09:56, Luca Fancellu wrote: > On 11 Mar 2022, at 08:09, Juergen Gross wrote: > On 10.03.22 18:10, Luca Fancellu wrote: >> --- /dev

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-11 Thread Juergen Gross
On 11.03.22 10:46, Jan Beulich wrote: On 11.03.2022 10:29, Juergen Gross wrote: On 11.03.22 09:56, Luca Fancellu wrote: On 11 Mar 2022, at 08:09, Juergen Gross wrote: On 10.03.22 18:10, Luca Fancellu wrote: --- /dev/null +++ b/xen/common/boot_cpupools.c @@ -0,0 +1,212 @@ +/* SPDX-License-Iden

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-11 Thread Jan Beulich
On 11.03.2022 10:29, Juergen Gross wrote: > On 11.03.22 09:56, Luca Fancellu wrote: >>> On 11 Mar 2022, at 08:09, Juergen Gross wrote: >>> On 10.03.22 18:10, Luca Fancellu wrote: --- /dev/null +++ b/xen/common/boot_cpupools.c @@ -0,0 +1,212 @@ +/* SPDX-License-Identifier: GPL-2

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-11 Thread Juergen Gross
On 11.03.22 09:56, Luca Fancellu wrote: Hi Juergen, Thanks for your review On 11 Mar 2022, at 08:09, Juergen Gross wrote: On 10.03.22 18:10, Luca Fancellu wrote: Introduce a way to create different cpupools at boot time, this is particularly useful on ARM big.LITTLE system where there might

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-11 Thread Luca Fancellu
Hi Juergen, Thanks for your review > On 11 Mar 2022, at 08:09, Juergen Gross wrote: > > On 10.03.22 18:10, Luca Fancellu wrote: >> Introduce a way to create different cpupools at boot time, this is >> particularly useful on ARM big.LITTLE system where there might be the >> need to have differen

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-11 Thread Juergen Gross
On 10.03.22 18:10, Luca Fancellu wrote: Introduce a way to create different cpupools at boot time, this is particularly useful on ARM big.LITTLE system where there might be the need to have different cpupools for each type of core, but also systems using NUMA can have different cpu pools for each

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-10 Thread Jan Beulich
On 10.03.2022 18:10, Luca Fancellu wrote: > +chosen { > + > +sched: sched_a { > +compatible = "xen,scheduler"; > +sched-name = "null"; > +}; > +cpupool_a { > +compatible = "xen,cpupool"; > +cpupool-cpus = <&a53_1 &a53_2>; > +}; > +cpupool_b { > +

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-10 Thread Stefano Stabellini
On Thu, 10 Mar 2022, Luca Fancellu wrote: > Introduce a way to create different cpupools at boot time, this is > particularly useful on ARM big.LITTLE system where there might be the > need to have different cpupools for each type of core, but also > systems using NUMA can have different cpu pools