Re: [PATCH v2 3/5] x86: don't override INVALID_M2P_ENTRY with SHARED_M2P_ENTRY

2020-08-24 Thread Andrew Cooper
On 24/08/2020 13:34, Jan Beulich wrote: > While in most cases code ahead of the invocation of set_gpfn_from_mfn() > deals with shared pages, at least in set_typed_p2m_entry() I can't spot > such handling (it's entirely possible there's code missing there). Let's > try to play safe and add an extra

Re: [PATCH v2 3/5] x86: don't override INVALID_M2P_ENTRY with SHARED_M2P_ENTRY

2020-08-24 Thread Tamas K Lengyel
On Mon, Aug 24, 2020 at 9:06 AM Jan Beulich wrote: > > On 24.08.2020 15:00, Andrew Cooper wrote: > > On 24/08/2020 13:34, Jan Beulich wrote: > >> While in most cases code ahead of the invocation of set_gpfn_from_mfn() > >> deals with shared pages, at least in set_typed_p2m_entry() I can't spot > >

Re: [PATCH v2 3/5] x86: don't override INVALID_M2P_ENTRY with SHARED_M2P_ENTRY

2020-08-24 Thread Jan Beulich
On 24.08.2020 15:00, Andrew Cooper wrote: > On 24/08/2020 13:34, Jan Beulich wrote: >> While in most cases code ahead of the invocation of set_gpfn_from_mfn() >> deals with shared pages, at least in set_typed_p2m_entry() I can't spot >> such handling (it's entirely possible there's code missing the