Re: [PATCH v2 11/11] x86/bitops: Use the POPCNT instruction when available

2024-09-04 Thread Andrew Cooper
On 29/08/2024 3:36 pm, Jan Beulich wrote: > On 29.08.2024 00:03, Andrew Cooper wrote: >> +asm ( >> +".type arch_generic_hweightl, STT_FUNC\n\t" >> +".globl arch_generic_hweightl\n\t" >> +".hidden arch_generic_hweightl\n\t" >> +".balign " STR(CONFIG_FUNCTION_ALIGNMENT) ", 0x90\n\t" >

Re: [PATCH v2 11/11] x86/bitops: Use the POPCNT instruction when available

2024-09-04 Thread Andrew Cooper
On 02/09/2024 9:06 am, Jan Beulich wrote: > On 30.08.2024 22:03, Andrew Cooper wrote: >> On 29/08/2024 3:36 pm, Jan Beulich wrote: >>> On 29.08.2024 00:03, Andrew Cooper wrote: It has existed in x86 CPUs since 2008, so we're only 16 years late adding support. With all the other scafoldin

Re: [PATCH v2 11/11] x86/bitops: Use the POPCNT instruction when available

2024-09-02 Thread Jan Beulich
On 30.08.2024 22:03, Andrew Cooper wrote: > On 29/08/2024 3:36 pm, Jan Beulich wrote: >> On 29.08.2024 00:03, Andrew Cooper wrote: >>> It has existed in x86 CPUs since 2008, so we're only 16 years late adding >>> support. With all the other scafolding in place, implement arch_hweightl() >>> for x8

Re: [PATCH v2 11/11] x86/bitops: Use the POPCNT instruction when available

2024-08-30 Thread Andrew Cooper
On 29/08/2024 3:36 pm, Jan Beulich wrote: > On 29.08.2024 00:03, Andrew Cooper wrote: >> It has existed in x86 CPUs since 2008, so we're only 16 years late adding >> support. With all the other scafolding in place, implement arch_hweightl() >> for x86. >> >> The only complication is that the call

Re: [PATCH v2 11/11] x86/bitops: Use the POPCNT instruction when available

2024-08-29 Thread Jan Beulich
On 29.08.2024 00:03, Andrew Cooper wrote: > It has existed in x86 CPUs since 2008, so we're only 16 years late adding > support. With all the other scafolding in place, implement arch_hweightl() > for x86. > > The only complication is that the call to arch_generic_hweightl() is behind > the compi