Re: [PATCH v2 01/10] x86/mtrr: fix MTRR fixup on APs

2022-08-22 Thread Juergen Gross
On 22.08.22 10:28, Borislav Petkov wrote: On Mon, Aug 22, 2022 at 07:17:40AM +0200, Juergen Gross wrote: And then there is mtrr_state_warn() in arch/x86/kernel/cpu/mtrr/generic.c which has a comment saying: /* Some BIOS's are messed up and don't set all MTRRs the same! */ That thing also says

Re: [PATCH v2 01/10] x86/mtrr: fix MTRR fixup on APs

2022-08-22 Thread Borislav Petkov
On Mon, Aug 22, 2022 at 07:17:40AM +0200, Juergen Gross wrote: > And then there is mtrr_state_warn() in arch/x86/kernel/cpu/mtrr/generic.c > which has a comment saying: > > /* Some BIOS's are messed up and don't set all MTRRs the same! */ That thing also says: pr_info("mtrr: probably you

Re: [PATCH v2 01/10] x86/mtrr: fix MTRR fixup on APs

2022-08-21 Thread Juergen Gross
On 21.08.22 23:41, Borislav Petkov wrote: On Sun, Aug 21, 2022 at 02:25:59PM +0200, Borislav Petkov wrote: Fix that by using percpu variables for saving the MSR contents. Cc: sta...@vger.kernel.org Signed-off-by: Juergen Gross --- I thought adding a "Fixes:" tag for the kernel's initial git co

Re: [PATCH v2 01/10] x86/mtrr: fix MTRR fixup on APs

2022-08-21 Thread Borislav Petkov
On Sun, Aug 21, 2022 at 02:25:59PM +0200, Borislav Petkov wrote: > > Fix that by using percpu variables for saving the MSR contents. > > > > Cc: sta...@vger.kernel.org > > Signed-off-by: Juergen Gross > > --- > > I thought adding a "Fixes:" tag for the kernel's initial git commit > > would maybe

Re: [PATCH v2 01/10] x86/mtrr: fix MTRR fixup on APs

2022-08-21 Thread Borislav Petkov
On Sat, Aug 20, 2022 at 11:25:24AM +0200, Juergen Gross wrote: > When booting or resuming the system MTRR state is saved on the boot > processor and then this state is loaded into MTRRs of all other cpus. s/cpu/CPU/g Pls check all commit messages. > During update of the MTRRs the MTRR mechanism

Re: [PATCH v2 01/10] x86/mtrr: fix MTRR fixup on APs

2022-08-20 Thread Greg KH
On Sat, Aug 20, 2022 at 11:25:24AM +0200, Juergen Gross wrote: > When booting or resuming the system MTRR state is saved on the boot > processor and then this state is loaded into MTRRs of all other cpus. > During update of the MTRRs the MTRR mechanism needs to be disabled by > writing the related