Re: [PATCH v1 10/14] xen/riscv: implementation of aplic and imsic operations

2025-04-30 Thread Oleksii Kurochko
On 4/28/25 10:54 AM, Jan Beulich wrote: +ASSERT(spin_is_locked(&desc->lock)); If this lock (which is an IRQ-safe one) is necessarily held, ... +spin_lock_irqsave(&aplic.lock, flags); ... you can use just spin_lock() here. +clear_bit(_IRQ_DISABLED, &desc->status); Why an atomic

Re: [PATCH v1 10/14] xen/riscv: implementation of aplic and imsic operations

2025-04-28 Thread Jan Beulich
On 28.04.2025 10:12, Oleksii Kurochko wrote: > On 4/17/25 8:25 AM, Jan Beulich wrote: >> On 16.04.2025 21:05, Oleksii Kurochko wrote: >>> On 4/15/25 2:46 PM, Jan Beulich wrote: On 08.04.2025 17:57, Oleksii Kurochko wrote: > Introduce interrupt controller descriptor for host APLIC to descri

Re: [PATCH v1 10/14] xen/riscv: implementation of aplic and imsic operations

2025-04-28 Thread Oleksii Kurochko
On 4/17/25 8:25 AM, Jan Beulich wrote: On 16.04.2025 21:05, Oleksii Kurochko wrote: On 4/15/25 2:46 PM, Jan Beulich wrote: On 08.04.2025 17:57, Oleksii Kurochko wrote: Introduce interrupt controller descriptor for host APLIC to describe the low-lovel hardare. It includes implementation of the

Re: [PATCH v1 10/14] xen/riscv: implementation of aplic and imsic operations

2025-04-27 Thread Jan Beulich
On 25.04.2025 21:31, Oleksii Kurochko wrote: > > On 4/22/25 9:02 AM, Jan Beulich wrote: >> On 18.04.2025 12:43, Oleksii Kurochko wrote: >>> On 4/15/25 4:53 PM, Jan Beulich wrote: On 08.04.2025 17:57, Oleksii Kurochko wrote: > --- a/xen/arch/riscv/imsic.c > +++ b/xen/arch/riscv/imsic.c

Re: [PATCH v1 10/14] xen/riscv: implementation of aplic and imsic operations

2025-04-25 Thread Oleksii Kurochko
On 4/22/25 9:02 AM, Jan Beulich wrote: On 18.04.2025 12:43, Oleksii Kurochko wrote: On 4/15/25 4:53 PM, Jan Beulich wrote: On 08.04.2025 17:57, Oleksii Kurochko wrote: --- a/xen/arch/riscv/imsic.c +++ b/xen/arch/riscv/imsic.c @@ -14,12 +14,68 @@ #include #include #include +#includ

Re: [PATCH v1 10/14] xen/riscv: implementation of aplic and imsic operations

2025-04-22 Thread Jan Beulich
On 18.04.2025 12:43, Oleksii Kurochko wrote: > > On 4/15/25 4:53 PM, Jan Beulich wrote: >> On 08.04.2025 17:57, Oleksii Kurochko wrote: >>> --- a/xen/arch/riscv/imsic.c >>> +++ b/xen/arch/riscv/imsic.c >>> @@ -14,12 +14,68 @@ >>> #include >>> #include >>> #include >>> +#include >>> #in

Re: [PATCH v1 10/14] xen/riscv: implementation of aplic and imsic operations

2025-04-18 Thread Oleksii Kurochko
On 4/15/25 4:53 PM, Jan Beulich wrote: On 08.04.2025 17:57, Oleksii Kurochko wrote: --- a/xen/arch/riscv/imsic.c +++ b/xen/arch/riscv/imsic.c @@ -14,12 +14,68 @@ #include #include #include +#include #include #include static struct imsic_config imsic_cfg; +#define imsi

Re: [PATCH v1 10/14] xen/riscv: implementation of aplic and imsic operations

2025-04-16 Thread Jan Beulich
On 16.04.2025 21:05, Oleksii Kurochko wrote: > On 4/15/25 2:46 PM, Jan Beulich wrote: >> On 08.04.2025 17:57, Oleksii Kurochko wrote: >>> Introduce interrupt controller descriptor for host APLIC to describe >>> the low-lovel hardare. It includes implementation of the following >>> functions: >>>

Re: [PATCH v1 10/14] xen/riscv: implementation of aplic and imsic operations

2025-04-16 Thread Oleksii Kurochko
On 4/15/25 2:46 PM, Jan Beulich wrote: On 08.04.2025 17:57, Oleksii Kurochko wrote: Introduce interrupt controller descriptor for host APLIC to describe the low-lovel hardare. It includes implementation of the following functions: - aplic_irq_startup() - aplic_irq_shutdown() - aplic_irq_e

Re: [PATCH v1 10/14] xen/riscv: implementation of aplic and imsic operations

2025-04-15 Thread Jan Beulich
On 08.04.2025 17:57, Oleksii Kurochko wrote: > --- a/xen/arch/riscv/imsic.c > +++ b/xen/arch/riscv/imsic.c > @@ -14,12 +14,68 @@ > #include > #include > #include > +#include > #include > > #include > > static struct imsic_config imsic_cfg; > > +#define imsic_csr_set(c, v) \ >

Re: [PATCH v1 10/14] xen/riscv: implementation of aplic and imsic operations

2025-04-15 Thread Jan Beulich
On 08.04.2025 17:57, Oleksii Kurochko wrote: > Introduce interrupt controller descriptor for host APLIC to describe > the low-lovel hardare. It includes implementation of the following functions: > - aplic_irq_startup() > - aplic_irq_shutdown() > - aplic_irq_enable() > - aplic_irq_disable() >