Re: [PATCH v1 0/6] tools/ocaml/xenstored: simplify code

2020-08-27 Thread Edwin Torok
> > > Cc: Ian Jackson; d...@recoil.org; w...@xen.org > > > Subject: Re: [PATCH v1 0/6] tools/ocaml/xenstored: simplify code > > > > > > On Mon, 2020-08-17 at 14:56 +0200, Christian Lindig wrote: > > > > This all looks good - I left a small comment

Re: [PATCH v1 0/6] tools/ocaml/xenstored: simplify code

2020-08-27 Thread Wei Liu
> ideas about this. > > > > > > From: Edwin Torok > > Sent: 18 August 2020 08:28 > > To: Christian Lindig; xen-devel@lists.xenproject.org > > Cc: Ian Jackson; d...@recoil.org; w...@xen.org > > Subject: Re: [PATCH v1 0/6] too

Re: [PATCH v1 0/6] tools/ocaml/xenstored: simplify code

2020-08-18 Thread Andrew Cooper
n Torok > Sent: 18 August 2020 08:28 > To: Christian Lindig; xen-devel@lists.xenproject.org > Cc: Ian Jackson; d...@recoil.org; w...@xen.org > Subject: Re: [PATCH v1 0/6] tools/ocaml/xenstored: simplify code > > On Mon, 2020-08-17 at 14:56 +0200, Christian Lindig wrote: >> This

Re: [PATCH v1 0/6] tools/ocaml/xenstored: simplify code

2020-08-18 Thread Christian Lindig
@lists.xenproject.org Cc: Ian Jackson; d...@recoil.org; w...@xen.org Subject: Re: [PATCH v1 0/6] tools/ocaml/xenstored: simplify code On Mon, 2020-08-17 at 14:56 +0200, Christian Lindig wrote: > This all looks good - I left a small comment on one of the patches > and I agree that this needs testing.

Re: [PATCH v1 0/6] tools/ocaml/xenstored: simplify code

2020-08-18 Thread Edwin Torok
On Mon, 2020-08-17 at 14:56 +0200, Christian Lindig wrote: > This all looks good - I left a small comment on one of the patches > and I agree that this needs testing. I also wonder about > compatibility with earlier OCaml releases that we support but I see > no real obstacles. > I've developed th

Re: [PATCH v1 0/6] tools/ocaml/xenstored: simplify code

2020-08-17 Thread Christian Lindig
From: Edwin Torok Sent: 14 August 2020 23:11 To: xen-devel@lists.xenproject.org Cc: Edwin Torok; Christian Lindig; David Scott; Ian Jackson; Wei Liu Subject: [PATCH v1 0/6] tools/ocaml/xenstored: simplify code Fix warnings, and delete some obsolete code. o

Re: [PATCH v1 0/6] tools/ocaml/xenstored: simplify code

2020-08-17 Thread Christian Lindig
I am going to look at this in more detail. In general, all of this are welcome changes. The main problem with select/poll is emulation of select behaviour which creates a lot of lists and consequently memory garbage at high frequency. This change is not yet addressing that but by dropping select