Re: [PATCH for-next 5/6] xen: Add files needed for minimal riscv build

2021-05-13 Thread Connor Davis
On 3/12/21 10:09 AM, Jan Beulich wrote: On 25.02.2021 16:24, Connor Davis wrote: --- a/xen/include/public/hvm/save.h +++ b/xen/include/public/hvm/save.h @@ -106,6 +106,8 @@ DECLARE_HVM_SAVE_TYPE(END, 0, struct hvm_save_end); #include "../arch-x86/hvm/save.h" #elif defined(__arm__) || defin

Re: [PATCH for-next 5/6] xen: Add files needed for minimal riscv build

2021-03-12 Thread Jan Beulich
On 25.02.2021 16:24, Connor Davis wrote: > --- /dev/null > +++ b/xen/include/public/arch-riscv.h > @@ -0,0 +1,183 @@ > +/** > + * arch-riscv.h > + * > + * Guest OS interface to RISC-V Xen. > + * Initially based on the ARM i

Re: [PATCH for-next 5/6] xen: Add files needed for minimal riscv build

2021-03-12 Thread Jan Beulich
On 25.02.2021 16:24, Connor Davis wrote: > --- a/xen/drivers/char/serial.c > +++ b/xen/drivers/char/serial.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include Btw - changes like this one would better be split off, so they would come with a justification / description. A file

Re: [PATCH for-next 5/6] xen: Add files needed for minimal riscv build

2021-02-26 Thread Connor Davis
On Thu, Feb 25, 2021 at 05:06:46PM -0800, Stefano Stabellini wrote: > On Thu, 25 Feb 2021, Andrew Cooper wrote: > > On 25/02/2021 15:24, Connor Davis wrote: > > > Add the minimum code required to get xen to build with > > > XEN_TARGET_ARCH=riscv64. It is minimal in the sense that every file and > >

Re: [PATCH for-next 5/6] xen: Add files needed for minimal riscv build

2021-02-26 Thread Andrew Cooper
On 26/02/2021 16:21, Bob Eshleman wrote: >>> On 2/25/21 3:14 PM, Andrew Cooper wrote: >>> >>> It sounds like you'd prefer no common to start and none of the >>> arch_* calls it relies on? >> We definitely want "stuff compiled under RISC-V" to be caught in CI, but >> that doesn't mean "wedge all of

Re: [PATCH for-next 5/6] xen: Add files needed for minimal riscv build

2021-02-26 Thread Bob Eshleman
>> On 2/25/21 3:14 PM, Andrew Cooper wrote: >> >> It sounds like you'd prefer no common to start and none of the >> arch_* calls it relies on? > > We definitely want "stuff compiled under RISC-V" to be caught in CI, but > that doesn't mean "wedge all of common in with stubs to begin with". > > Ho

Re: [PATCH for-next 5/6] xen: Add files needed for minimal riscv build

2021-02-26 Thread Andrew Cooper
On 26/02/2021 15:30, Bob Eshleman wrote: > On 2/25/21 3:14 PM, Andrew Cooper wrote: >> Well - this is orders of magnitude more complicated than it ought to >> be.  An empty head.S doesn't (well - shouldn't) need the overwhelming >> majority of this. >> >> Do you know how all of this is being pulled

Re: [PATCH for-next 5/6] xen: Add files needed for minimal riscv build

2021-02-26 Thread Bob Eshleman
On 2/25/21 3:14 PM, Andrew Cooper wrote: > > Well - this is orders of magnitude more complicated than it ought to > be.  An empty head.S doesn't (well - shouldn't) need the overwhelming > majority of this. > > Do you know how all of this is being pulled in?  Is it from attempting > to compile com

Re: [PATCH for-next 5/6] xen: Add files needed for minimal riscv build

2021-02-25 Thread Connor Davis
On Thu, Feb 25, 2021 at 11:14:53PM +, Andrew Cooper wrote: > On 25/02/2021 15:24, Connor Davis wrote: > > Add the minimum code required to get xen to build with > > XEN_TARGET_ARCH=riscv64. It is minimal in the sense that every file and > > function added is required for a successful build, giv

Re: [PATCH for-next 5/6] xen: Add files needed for minimal riscv build

2021-02-25 Thread Stefano Stabellini
On Thu, 25 Feb 2021, Andrew Cooper wrote: > On 25/02/2021 15:24, Connor Davis wrote: > > Add the minimum code required to get xen to build with > > XEN_TARGET_ARCH=riscv64. It is minimal in the sense that every file and > > function added is required for a successful build, given the .config > > ge

Re: [PATCH for-next 5/6] xen: Add files needed for minimal riscv build

2021-02-25 Thread Andrew Cooper
On 25/02/2021 15:24, Connor Davis wrote: > Add the minimum code required to get xen to build with > XEN_TARGET_ARCH=riscv64. It is minimal in the sense that every file and > function added is required for a successful build, given the .config > generated from riscv64_defconfig. The function impleme